From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49DF1C47258 for ; Wed, 31 Jan 2024 09:49:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A73BB6B006E; Wed, 31 Jan 2024 04:49:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A23E46B007E; Wed, 31 Jan 2024 04:49:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EB536B0081; Wed, 31 Jan 2024 04:49:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 80F676B006E for ; Wed, 31 Jan 2024 04:49:24 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 50316160CBB for ; Wed, 31 Jan 2024 09:49:24 +0000 (UTC) X-FDA: 81739133448.26.602828F Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf13.hostedemail.com (Postfix) with ESMTP id 6E1E42000B for ; Wed, 31 Jan 2024 09:49:22 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mutgZg+H; spf=pass (imf13.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706694562; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QlHWxlUqyXnTVwbRvj+J/cXzpPAlxBWkdZIjC12r5XI=; b=jBGVpqI7n+aPQrysi47a7yI2ePDbktjXMkZCZbwUAf1dnI5A/uKCHFLe8rK68iudzc+rd8 O+WERmSp5yEQ5dkzMC6tPgxjU0aw510WoSAYlkHz7U2WSJATvK+RESvND13ovK94gIrBQZ 34uE+/Oq/DaGvtixgAqI/06AMMmsnoQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706694562; a=rsa-sha256; cv=none; b=ZdG2VAhci0eSBNKtvd46wmCKEphNzCLOJd5lI55/zwIeOAKsnUkEib+axGW0FA7BqwE+rL SHPfRDDD/TaSIDqkPwRtOifn1eJfaxp/vHih5kJcM8/4NKC9I9oyrWAgiFNk7JIzW1kqJQ E8qloC6Or/m2h1WsxF9Kv3XwFPlRReI= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mutgZg+H; spf=pass (imf13.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-51109060d6aso4934427e87.2 for ; Wed, 31 Jan 2024 01:49:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706694560; x=1707299360; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=QlHWxlUqyXnTVwbRvj+J/cXzpPAlxBWkdZIjC12r5XI=; b=mutgZg+H6m+dOB6PKPOmHaqstQiK6uwBlYGda8C4Fxd4p/0xQmRy9Rc0zv9uFLTECd u1QdgiNSDK8SjsW1LQxxWl3RCExspsg7K3oY2J4+XknMbznUkSRezPxJ3IluwxhEyOlo l7ghyhlE4bvpkBR9zXhK24ORVV7cif02SF99QjjYTajvEPCHps8xRS42GHI9dIB1ITMR Owpvx+qGHKpW+EPVl2NCYCERsuNvan0BnxZ3hu6F0I5hT5nW40U3gYZG2a0PNvjaRRA3 0Dki8sjRJlomBZayl+NNr47AnpB+6cMyq3UW729FwPho9I9GQ6itI/PNthbpYWb/JN4t b2eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706694560; x=1707299360; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QlHWxlUqyXnTVwbRvj+J/cXzpPAlxBWkdZIjC12r5XI=; b=tDNQpoWCEq+XneYhwFYNgjkKgSBc35p/+B24UHF3PE9G0AP3yr6OosZb9PgyIGaPcu 6i9WGumciqrEc3e4ahJkTXRD9VlkzvIXlwUBpIob/5wpn0sVc+3muufU5FPvaTx5cgTY q+XJnRMhkjjoGUc6GZ8tFPqFHPGT75i7F0MnRfIJ116Dbc0RJbTd8JCH5GvoLiN4Dvrw ejg/z3VKzxse1Tv8gcJe50Kk9BZTy/7SRk0y5uw2Z3QrOylr1dmTtSOhDlrLFMuA4cBM /uFYsR5Zi8m1hAiq4CwGd4RNxQFfb+Ac1hYmKO6RUGGoH0tEUUXCxbl6zZR5B3E6pgXW PjVQ== X-Gm-Message-State: AOJu0YwURMhRYLPZE8p5IfyoK19+iR/ua6ecdN1KwWdoa/1GjyXJx/zf OHyU0UkCriyOOK8rJoJWyUQ9CWHobU1KrH2t2Kc2dvQgN2jUzNim X-Google-Smtp-Source: AGHT+IGe9pSSTvEwxUOmgQQdOJSgWSmwSkZ/D5P+RgNjbFhDreI/xzRdL/S4QjkYb1titXb+nSd7Mg== X-Received: by 2002:a05:6512:b90:b0:511:1b29:244a with SMTP id b16-20020a0565120b9000b005111b29244amr1003440lfv.6.1706694560560; Wed, 31 Jan 2024 01:49:20 -0800 (PST) Received: from pc636 (host-90-233-198-33.mobileonline.telia.com. [90.233.198.33]) by smtp.gmail.com with ESMTPSA id er15-20020a05651248cf00b005110bbfcea0sm1151141lfb.169.2024.01.31.01.49.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 01:49:20 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 31 Jan 2024 10:49:17 +0100 To: Lorenzo Stoakes Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , Dave Chinner , Oleksiy Avramchenko Subject: Re: [PATCH 2/2] mm: vmalloc: Refactor vmalloc_dump_obj() function Message-ID: References: <20240124180920.50725-1-urezki@gmail.com> <20240124180920.50725-2-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: fxaezaitigrbfmc6rf55gmtdcfae3esr X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6E1E42000B X-Rspam-User: X-HE-Tag: 1706694562-955830 X-HE-Meta: U2FsdGVkX198bmtYOMP6JRJMVDnibFMXtuSM0/eF2cXK7ylZI4WJjHcV9awL9c6I13RKW7RmpUp0Zt4HcTmOtP0MOzru/3AhGNWrXCEFyWKVDD2L7WtWJjzbKQqOy/st8Feo4Z0unK7OlyBQH5A+Aguq7X6cYzdC04lSk3CnKEJcdKak124oRTJuKSUyw+TdiIZnSzyBhzlQC6KmnuR/e7yRavIKWPtFzeclzfORzylvct4DPbpdVg9GDh2tCNJ0C7IL9uYNSEBslfMWHsxaQxUYGCr+qaG384Gs7z+Ue+mV34VeVkW9Zdpnx1m/+Ip/H8nJq7wV8UYFWFgBMeAyV+1hFq0bIVDQ42ob+VwJCMtMrf/rClU2w1PacpjadnmvDDbVNCVU4wrja3tk8hNHRyz3xsBl2gvt+5QOaTfPY7LwiqBiDgsePlFHK0FVmtA2qoFLTKuceC5bKFiUn/APf8P4S8RDNWd0FVxhBKCPZyH+CU0EHEZOhfbZRM8pLd7WflRf3HxJy2rU1LMYCUUi39OB8Jvxwm7WfYqhYVBKhxgS7cUVy1DF3v9ZCktcRrwdvtvhVc6edJeXjtqxXBF+1muOPDQ/vNuJGxEQUURU0FY0LvVr9nDsiXJEw/F51ifDVMJVGmdLdqWbcRJIgbcvuYqUTB7n+/VCKwJaJJ/jwwjRwzl+k3vDatAvy64xWA7k7psyyq5pa3coaUAIu+bVCASl9bMBkHYy1KJg8e3wB3U1i5jUIAMdStU0voIIzOMi/OO/kO9NJKBHx38a/ST97WB6eqlIE3v3dcaUSwv43RfgZihwd+uJ2HUjkKb3bNqOf29g/2prF1IA6B02piGyLcO/Viy4Vpz8e7x8ygE+qTcQgKHzeX8rHRKA6ZInWC6QiNqmT43xhs1V3jhJtgqyVVGvQrNN5moXGt/73aH4nfTGmxyvGJZjt+b9+gbiJizT67awSA1JcOaLMEEilrD X+/s278w B9iLsZRX7NHsW0HLgMTQRslzyIJEZMrtApQm1jjuqxFoVyXQiFBjnGwocwvlOXuwFXF+2iCzu8d5dYhU4Ht6Iv1vnHBXMtz3f7QXR5Cw5uo9cllMBS859qpl7ib9vLbpayXZKHf9iVN5uF3QX1OaeZmEfru7rLy4k92HWKEG8PehMBPBSZPKzmbp1Jdjosfx90LHM1KceM6D4zD35bydUk5lGNyMDtXAQa4/558tZrEtisqkk0aVW2zw81dllUV5IQ4HjXGfP+eaniNoSdVohSQLgjngzakr896SFTMO82nfyakOfJRji0VONJkt9Ngooq4YOodzLpW1+QzeHI72wqHA0TsqZGIKdQNG0BQAEFgRSfX0dMjVtsGQozeH2Mt5JPtZInx0hDLvS1z97kFU2pT8OXCB8yAbY9KUmYjj+1DUF7dZMiArxn4eHKLoscOgiRxV7YUcdQ/68g+HEJUfd6gSd3czneY75QFqmVC66HYbS62epGMLVJTZ0/Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 30, 2024 at 06:50:48PM +0000, Lorenzo Stoakes wrote: > On Wed, Jan 24, 2024 at 07:09:20PM +0100, Uladzislau Rezki (Sony) wrote: > > This patch tends to simplify the function in question, > > by removing an extra stack "objp" variable, returning > > back to an early exit approach if spin_trylock() fails > > or VA was not found. > > > > Signed-off-by: Uladzislau Rezki (Sony) > > --- > > mm/vmalloc.c | 33 +++++++++++++++++---------------- > > 1 file changed, 17 insertions(+), 16 deletions(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index b8be601b056d..449f45b0e474 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -4696,34 +4696,35 @@ void pcpu_free_vm_areas(struct vm_struct **vms, int nr_vms) > > #ifdef CONFIG_PRINTK > > bool vmalloc_dump_obj(void *object) > > { > > - void *objp = (void *)PAGE_ALIGN((unsigned long)object); > > const void *caller; > > + struct vm_struct *vm; > > struct vmap_area *va; > > struct vmap_node *vn; > > unsigned long addr; > > unsigned int nr_pages; > > - bool success = false; > > - > > - vn = addr_to_node((unsigned long)objp); > > > > - if (spin_trylock(&vn->busy.lock)) { > > - va = __find_vmap_area((unsigned long)objp, &vn->busy.root); > > + addr = PAGE_ALIGN((unsigned long) object); > > + vn = addr_to_node(addr); > > > > - if (va && va->vm) { > > - addr = (unsigned long)va->vm->addr; > > - caller = va->vm->caller; > > - nr_pages = va->vm->nr_pages; > > - success = true; > > - } > > + if (!spin_trylock(&vn->busy.lock)) > > + return false; > > > > + va = __find_vmap_area(addr, &vn->busy.root); > > + if (!va || !va->vm) { > > spin_unlock(&vn->busy.lock); > > + return false; > > } > > > > - if (success) > > - pr_cont(" %u-page vmalloc region starting at %#lx allocated at %pS\n", > > - nr_pages, addr, caller); > > + vm = va->vm; > > + addr = (unsigned long) vm->addr; > > Hmm not so nice to reuse addr here for something different, might be nice > to have separate obj_addr and vm_addr or something. But it's not critical! > > > + caller = vm->caller; > > + nr_pages = vm->nr_pages; > > + spin_unlock(&vn->busy.lock); > > > > - return success; > > + pr_cont(" %u-page vmalloc region starting at %#lx allocated at %pS\n", > > + nr_pages, addr, caller); > > + > > + return true; > > } > > #endif > > > > -- > > 2.39.2 > > > > Other than the nit, which I don't insist on, this is a big improvement so, > > Reviewed-by: Lorenzo Stoakes > Thanks! -- Uladzislau Rezki