From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25451C46CD2 for ; Tue, 30 Jan 2024 16:02:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 997B96B0085; Tue, 30 Jan 2024 11:02:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9474A6B0087; Tue, 30 Jan 2024 11:02:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C1D26B0088; Tue, 30 Jan 2024 11:02:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 692EF6B0085 for ; Tue, 30 Jan 2024 11:02:00 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 381D91408A7 for ; Tue, 30 Jan 2024 16:02:00 +0000 (UTC) X-FDA: 81736443600.07.C3AF202 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2085.outbound.protection.outlook.com [40.107.244.85]) by imf05.hostedemail.com (Postfix) with ESMTP id 9A8E21000F0 for ; Tue, 30 Jan 2024 16:01:22 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=memverge.com header.s=selector2 header.b=PCkNHK7V; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=memverge.com; spf=pass (imf05.hostedemail.com: domain of gregory.price@memverge.com designates 40.107.244.85 as permitted sender) smtp.mailfrom=gregory.price@memverge.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1706630483; a=rsa-sha256; cv=pass; b=SyQBo8zAL3vWqhIjPLspYqHzRiEcTJ3b2kLQHaJKL9LsiGZyQ2o1e1+zmj2wWnVO1gDrNp fl3FWO2/ysgcU4LPOHWjPLVt+p5J58SjaBglgMDnJI1vwYepHfFNrA/yMRcV9+uEge8spf 0Q+giYuxJM3cGoj+DSwAa2RD+KBfQtg= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=memverge.com header.s=selector2 header.b=PCkNHK7V; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=memverge.com; spf=pass (imf05.hostedemail.com: domain of gregory.price@memverge.com designates 40.107.244.85 as permitted sender) smtp.mailfrom=gregory.price@memverge.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706630483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6jUElSWu+KsiSo6u5p3dXkMBEktbyZPMRQkyS2WfUrY=; b=ykjyJoFYTfK9a7XEUOJRa4pLqXhNOKsM7bNnwKSaclT6N9XNN6swceQmPE4k3M8syaBpSv b3nl0/XhIyXgDUiivprGpCk6no0reenSID8z1mTww30b88/zwY3scYnX1XA3IECVE2ZR0a Osw91coS/TZJIzlODIEQU3Sfq23NWfQ= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H33mTFA6Y9HKqDaLvOJv82Y0ObYCzJeXyG+MlTTFeUXV3CjpksmCq13pecMrW5A0UJE1zov2E60t8gUPTP4Hezh5801ThGnBUjESZDx6KiyQOdWNrNhU9xi7E0jbS2+eAh6T8+rQcgu6AC9dBJxwKxH2MkcofkXAC2AvgLxBK3LCL8GfI5wYYlNDSORRCtI+ISs05848VdDEWlwgwoo0zJNHBhQUFsQCE69hrRP/bgRQAW9AcUGXDPEWcqXdlNwqOblGZvvyq4pFBPmQIkJXE8kmT2QhQfx8JAPaXQWOny8h3CcnRzzaUWpCJwv+YTW2VBGiVNxOhfceILcOCTwF3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6jUElSWu+KsiSo6u5p3dXkMBEktbyZPMRQkyS2WfUrY=; b=CfeOG1Uqydx7QwPh9G/1GymrBB3se0Naqs/DjOprUaDpPGLAlxTZVd83Axs0uWkC1+xE16AXWto/7pFGAC90x+y5wjIYqSUe+1KHgSaT3syCNum5Pwe6epaHCr3S1CDt/R4Kh9Qlc0K2r+FrotkNwVY/ajugKpNDP3RciErO7gpEBXYW79BZ+8V7OAnKQdyvza1F4PYWRYmizDuxReK/owPp77S0Oj3jAT2wH30H3mVOjdjPk/5CG63QPogGOMRtCBaDwUkUlsYa/hyAUJgFc1RSQc5dB5eCfZF03dQk4obPFIsiSrireoYSr8/nKzmMZS7ktrewAf1diXprO7XK7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=memverge.com; dmarc=pass action=none header.from=memverge.com; dkim=pass header.d=memverge.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=memverge.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6jUElSWu+KsiSo6u5p3dXkMBEktbyZPMRQkyS2WfUrY=; b=PCkNHK7VSBTlZyXB32qDK3Byfjw6c49Wy3oUMLsrsznZ6QOIBAB/TAPYDqqA71+MTvDC//qPqn9ctQhtnNOydpj9jDxeB7rWNV9hgG9QkrGz7tm6z8De9eAU/zHKSXSMPQOsbmSF/tbLMwEPQMH/rLyiXg/lxl7SwXQ91CGfwyY= Received: from SJ0PR17MB5512.namprd17.prod.outlook.com (2603:10b6:a03:394::19) by DM6PR17MB3739.namprd17.prod.outlook.com (2603:10b6:5:256::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.32; Tue, 30 Jan 2024 16:01:17 +0000 Received: from SJ0PR17MB5512.namprd17.prod.outlook.com ([fe80::7a04:dc86:2799:2f15]) by SJ0PR17MB5512.namprd17.prod.outlook.com ([fe80::7a04:dc86:2799:2f15%5]) with mapi id 15.20.7228.029; Tue, 30 Jan 2024 16:01:17 +0000 Date: Tue, 30 Jan 2024 11:01:12 -0500 From: Gregory Price To: "Huang, Ying" Cc: Gregory Price , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, corbet@lwn.net, akpm@linux-foundation.org, honggyu.kim@sk.com, rakie.kim@sk.com, hyeongtak.ji@sk.com, mhocko@kernel.org, vtavarespetr@micron.com, jgroves@micron.com, ravis.opensrc@micron.com, sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com, seungjun.ha@samsung.com, hannes@cmpxchg.org, dan.j.williams@intel.com Subject: Re: [PATCH v3 4/4] mm/mempolicy: change cur_il_weight to atomic and carry the node with it Message-ID: References: <20240125184345.47074-1-gregory.price@memverge.com> <20240125184345.47074-5-gregory.price@memverge.com> <87sf2klez8.fsf@yhuang6-desk2.ccr.corp.intel.com> <877cjsk0yd.fsf@yhuang6-desk2.ccr.corp.intel.com> <875xzbika0.fsf@yhuang6-desk2.ccr.corp.intel.com> <871q9ziel5.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871q9ziel5.fsf@yhuang6-desk2.ccr.corp.intel.com> X-ClientProxiedBy: SJ0PR03CA0367.namprd03.prod.outlook.com (2603:10b6:a03:3a1::12) To SJ0PR17MB5512.namprd17.prod.outlook.com (2603:10b6:a03:394::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR17MB5512:EE_|DM6PR17MB3739:EE_ X-MS-Office365-Filtering-Correlation-Id: 72d8323d-0182-41a4-1515-08dc21acb117 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HALUlA9xAa2lwX0E1fD0e6DHPglS2NrC2ROp97bPmdu52wjmCXIxqjBG5iJDiFg43wMRbzXtW0vRW9gB7Rz58cWVzD0EctfxrS0wZaXn0qSTbQwpfxCvviqvsVTJhtzIEp0scZLkUiFf8S1LvATYstjeNI/cfyX6TWGichLKw797vS6XReImG5vjuillTUp1uA0cUkCkMtb87rQL/jaG9jn6Q0nYGzHaa4u/Iv29p7IYUkjWDkUs0PQMTj+65gIxyKl5MEwU8br0hqYgKGEhr0ZMEy6LhNIHbsH/lIpjohOxXttbA7zWjX6BYv/2Xrt2TriNM0ughQ5KnXAHKQTuRjI5kTVt++mYzXmXT12UJmUhuOEsqwx+2sQJ4g5UavNoXLIK14cbNijnQ23pCFQDDyLuNAbVVlPiLDnkYUVAR5wFmrevlTxJnGTt1btY5LPLyIkpKrLg7AZxLsO4NqfKiD7im8C5gPXZgtuqOj0kNRan1Ax0eOq5wz4FIb7sif4z/+OAM7SMbwBya0g5MTuE4dMTSK42XtjhGIU7UAF8noU8d4KYuVyBjmgB4qSiRqBj0jdsHfrVPZzsMbeb/LUAnHLx7Ve+cpNK1uu0HMl3TKs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR17MB5512.namprd17.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(376002)(39840400004)(396003)(366004)(346002)(230922051799003)(186009)(1800799012)(451199024)(64100799003)(41300700001)(2616005)(6666004)(6506007)(478600001)(26005)(4326008)(8936002)(4744005)(2906002)(7416002)(44832011)(5660300002)(66946007)(66476007)(6486002)(66556008)(316002)(8676002)(38100700002)(6916009)(86362001)(6512007)(36756003)(16393002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?T1mOio2Jk2nHZ1YMohF/ttVyPygV4EsRULDKs2TRZ/uoYceFvH2LVPFKv0A0?= =?us-ascii?Q?ukeM0+1oNSRa1bqH0vnfWmeH85aNT86MU/KlUzFGeUsAnnAwt1IvY73wi5Ca?= =?us-ascii?Q?2LnD8Kt6s5CWq8QLAX/PPFOArlR9PLSZ7vMCYCodYILW5DAO0BER1z7OhYxz?= =?us-ascii?Q?20xggUcsjWO6lWwvmTtko3HVq6NtBtPAUMgTfmZR2qFEPLATpgG/36wEq2s0?= =?us-ascii?Q?OOMYQBqHXziamusRwxaTk+o+k0L9qP9ScXSKjppdP74HrmEM6uBv1avtAbhe?= =?us-ascii?Q?8VZdHRmojb35dbXd4B8RmAW69KgoG9L7BNKcudKXUIG/1D5H4nC5m3rWnBDU?= =?us-ascii?Q?76ZsNvcMKlzYrDwi6PZSE9lvrccd1AcOcY3EOlwmg5Sk8bxT5b/G4crt4KHh?= =?us-ascii?Q?OSaKZQiOsNcnUXjyb0q4ksQGUI/i9vZkDbHnALuqoTpf64tL2lLpLSn0ZlY3?= =?us-ascii?Q?I0CSdLLBWZW1dJIZxwJ2yy4EehqiYy3Ylhoz+2BkmsT7C/CfuR4SHNvHnw90?= =?us-ascii?Q?/0cL6WlC6FWzsmmU0eXnO5bDWSWNIixBjvkIH9y9t9JixTXRtp+JB3wcUa65?= =?us-ascii?Q?iyA79EhlKeGBSPdcHUguFV65nk32F5SRxhEZoslZIkUlp2SfCzfuXZ1DYhtT?= =?us-ascii?Q?5FMKhelIbVORFG/0xqJAltJdncrNCbop0DjmLKl+4X2mWLJzKoguHitEx7bG?= =?us-ascii?Q?g9FvTMgUIG8JhDWCVLPJransK/kplmWJjLBDTAccXulN/SbctvFbLVibgioc?= =?us-ascii?Q?iQh22E3WLwyOx1aqb659WVAywIfUaevMg/MjpzYMSyaVV1iNFqJlYBYKZxAX?= =?us-ascii?Q?wRUAQ0BB61R8irgqy5DGBMe+cXbCQPT/7FeKJoWFGilguNmxjAee+hrzcyp2?= =?us-ascii?Q?/lM6RW+QMwRM3eubbLZ5iqSEpozvz1ulbLRflFnrtrNfJWFpiMiQEfFVBs/H?= =?us-ascii?Q?irSLIZRx4qouTXfLOn7CLJ1pscZ2TeVRTvOiTZ8+90NHRNd4wmLtQfwjEzOD?= =?us-ascii?Q?jWNRDnqTDdmrFzSkIpdYKcvBbuTCD0edn++R6JdgCHm+idZUGhOs7QQ3Qdyp?= =?us-ascii?Q?ACH7MP/n3vcPQY9NXPYVfOHoxpXnjdGMJiMl4ZodOgDirsvStqQ1ELZeeyNT?= =?us-ascii?Q?njSePnKy1TebVWQYISeJK3gPVxdukxwZIQbkP7EdxtE//sUCCe8iDWZ7Oj72?= =?us-ascii?Q?Va3/l2Djx/VkcPbZytd0K4rIdaCLvILrSLstue6slWqqe8/O1a5WaqO6sso/?= =?us-ascii?Q?JTYG7UA0/1BtyeRYmtnGO5IQrq2lKye0JMdKZruBAr8b1ehQkjdiULEJMz4X?= =?us-ascii?Q?Cc/19wHFZ69BGb0EPkHoZT2xA0wvmtuOKvANVog7SO/WOH/bJQYn97kt2NPa?= =?us-ascii?Q?zTUD71ZpOESQDWYsA0CnsjB2k7fkU08ZeI20men/bwtkjMErEGAEs06sQQtE?= =?us-ascii?Q?nmEvP19sy5M6KNfXz2cB90QVoMXcIpsSdP4R28CuYDm+MFpCpv+MnxBDLBCl?= =?us-ascii?Q?zlWrBEGJLsJ6rKy+bbU7N98UYf0i6+Jd030vVH/Wq3i9c2SQlO3WgHPdpKA4?= =?us-ascii?Q?5pXnIBnTmNYlU22CUL1N689M09mFKDco9lhu5fArsikuMJP5TdYX8YqmNpfL?= =?us-ascii?Q?bg=3D=3D?= X-OriginatorOrg: memverge.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72d8323d-0182-41a4-1515-08dc21acb117 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2024 16:01:17.0956 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iNjqhtuVvyxPopGgRVZJtSt7WpQvYqHs9D6Dj/eeEbpcuddi+O4Dpue3J/z+ahQDM7krL7JL3VRMb7jxkaqOy3eGgkBf+kv07qg6UJmH6bA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR17MB3739 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9A8E21000F0 X-Stat-Signature: 1xbqyunuh7h6gnfd8iwucj5bit9wj1xq X-HE-Tag: 1706630482-987393 X-HE-Meta: U2FsdGVkX1+4cX+gnFqHp7rLPvrcmlRJ/v5VuUUrXneYJNcvxK+Jf3NoSvsfQ9UwADS2yzJBIfAlJJoPgLAh8LQ2ADEMMeFzohwqtWaMfnIEPOlRMX1qb6O+RoS/RacivUd0w4TYuGjKUbfl85Ap2osZLVc8WK8ClZhEuUSrI8uK3Dz6wpjt4GXLXUEjRSE7/9xrR0S7OmjAb/qLQNCEmx/5fJngaTDf9wEjRlaZ4fq8PPFLG4bNxJxEm9ihaRI0kOPcdBCOBhRiTDpCrdHIoeTNWsFXx26HponXfaD6jFXgGWCZNkHl1Sm875jSERi3th1oP1Cth9qU9SgIGjasNUA9wR3EDfPK7nUM/WZ+ArYJ0WsYw7p3AfJVc5ZZlBSMFwQDyQrHJ2Z3aRnC1M9QPoN0yahCqITo7lGFikcSiQfcXzyrn35PU0PuFZ+grc5/gjkfw602vngKiLaxyPgiTAsP0Yb0GvRPvHAaYiu4Ung0pzZPLNtqV3kf2KMn9FLeQepJ3MWYKW/+R2pUClWrWj2JRasEXwgFdy0wqxmMyLYCAQ8blSJnwJYmxEarfnSB8ZDswrEbbZ/0rGsg2TY8D85/M8YOYe8Si8TfYdvz5XgBGzgkrYkUiBzvn0XRA2hfBS4HdOC7Eyj1E96XnoewX2I7z17LnFqiI3K+9PUYCMAR16pjPPrFBXpb03xSpYgJyxoyWVQxh4r+dvsB1XNwzCMxQ6rYBc4fI1+3/HVmfMQkW0g7yAKe0ThYMFaVS2o0AYSXxNhoI8GlDAQixns4Z5mo9UQBXwLvRphn7xSY5jhqNI/E2R3uk29/zMKf5kzQpFglcuGGMwbPGbbJE1W1iZdAe95yGCyRpj9XbHsFs1G0KTJUT6bhgkvjrVGTq5HJaX/VCbV02mxOKkFbeMl4fbqrWfs7nwGepWAG/62UqjzlONRKSuG7qocuAWFMySfi5vgvh1nbWbFQxSHbhkU UqfcKBhD Nh8V6NNIlOVv0Etv4yPWUtA3/HjKsbKtOlbB3d5atojT8i5MF/HECHkZ3CfSp9wDjB4bBEQpjLZPba1a8dpheavG6TnZWV/ieYydm5pTcTC3JZINLcM/eTv+pPo6M+kuoTPklYUvAoLQJfCekaCmIXEKEJMP7zhoEKaTyZMm/6BnkgjtQagScshloH7tkXTf93X6iBKBAc3uZz3Lbo3TChw+mJgLE2O6zw8gvsQcHbDZuWPICn7+udR09dut/+JfH6KaVqSnKXJeHAtxZfbGwv/xiCG98R88Jwi00BOY6oGSkV9OKs2wOkzCLpRZ9sCyezsMCtpjJrOpR5vAISevii/Z5fFtBmj1AkpBcKoHU1Gb9cLd73uwE/BS3ylsiYRFqRMkBMfX9MRYcGCk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 30, 2024 at 01:18:30PM +0800, Huang, Ying wrote: > Gregory Price writes: > > > For normal interleave, this isn't an issue because it always proceeds to > > the next node. The same is not true of weighted interleave, which may > > have a hanging weight in task->il_weight. > > So, I added a check as follows, > > node_isset(current->il_prev, policy->nodes) > > If prev node is removed from nodemask, allocation will proceed to the > next node. Otherwise, it's safe to use current->il_weight. > Funny enough I have this on one of my branches and dropped it, but after digging through everything - this should be sufficient. I'll just add il_weight next to il_prev and have a new set of patches out today. Code is already there, just needs one last cleanup pass. ~Gregory