From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAB29C47DDF for ; Tue, 30 Jan 2024 11:58:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BFFC6B0085; Tue, 30 Jan 2024 06:58:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 670A96B0087; Tue, 30 Jan 2024 06:58:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55E906B0089; Tue, 30 Jan 2024 06:58:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 470796B0085 for ; Tue, 30 Jan 2024 06:58:25 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4BED514048D for ; Tue, 30 Jan 2024 11:58:24 +0000 (UTC) X-FDA: 81735829728.02.33C7F77 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf28.hostedemail.com (Postfix) with ESMTP id 9ACD0C000B for ; Tue, 30 Jan 2024 11:58:22 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf28.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706615902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mbQOd8dOGGQHkMYd66FQkMKwA2DnoMvfFA7eCVAWlpg=; b=q8mx0kn9S9T5p3w6Z9Qk6RbfezmROxJMR85lUSegMN5WHXliLOJr8DcXTIH/xjtpDS9zq0 MjZwaqxE6vc5J+3p9DDVq+492PE1fsJHhnYWovpqVpA+jBrYDpYT5J2Fb6lbx9XABcK3gH yDTYRj3pn5/XGvRallCoRUvzT/JsNjQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf28.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706615902; a=rsa-sha256; cv=none; b=sf3QRwf3mJUJa20/7MyRq+lO9RXo5JREO1sQH253vtdTtixYBZJwAN1BY875SKqC1GP0SD /pGNh4BMpvII30eHgwE7fmerhcPaavXOvDKLgJ769HgspZuCrhy8mQz3rNK1GaIw6Z0oDt wEfe4XxAZUeYwXTdc/XHZAwwaOAJmqE= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7E04CDA7; Tue, 30 Jan 2024 03:59:05 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 878FB3F762; Tue, 30 Jan 2024 03:58:15 -0800 (PST) Date: Tue, 30 Jan 2024 11:58:04 +0000 From: Alexandru Elisei To: Anshuman Khandual Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v3 06/35] mm: cma: Make CMA_ALLOC_SUCCESS/FAIL count the number of pages Message-ID: References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-7-alexandru.elisei@arm.com> <0a71c87a-ae2c-4a61-8adb-3a51d6369b99@arm.com> <2cb8288c-5378-4968-a75b-8462b41998c6@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2cb8288c-5378-4968-a75b-8462b41998c6@arm.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9ACD0C000B X-Stat-Signature: p9a6x3s9cfe1efkfhf8w3dj3ew1s88uw X-HE-Tag: 1706615902-468896 X-HE-Meta: U2FsdGVkX19rzdatGWFntyDOpWcX/0YwM4Mmk+UtGcJ8NKYGkKLvn6I4R+hl3XgAb3XZphF6xooIedm+Tar52nPT7geDqARd7VBoiR0wAnbmV70AmQtv6ogjovvOA/8pTy6RzBCAWarzYjPra/ZXDJqE0nLfpF1tcnkO9UHr15rLqRiTSydDsYfZZrUnp4GNrOgb0amZbJVyxlTYokfeVGbxDCNVVpKHwTOOTu9vsYMhEbRFN4RGKVlNDD0EPVRfj5FuQCtUMC8vxD8ADA1FhlPLi3+4WEb39eLYeUkWHX/yWtQEfxa++VPcLt5jUU6umOeBDWijyMelemZZR0dpkW3PxYjWLGTJ+Ka//0Nff4Unnld0/zPWSR841qhUBsNpSxGG14vNALXhaPlZrjYoas14XrJ4s0B1PAE67yFpdPnd+ApNEwwDvZlX+9NrCP8lzVJ5kCCBvR7jEgGuSCkqt9xf74QDNF6RL1GmRzVgkp5gXSV+DOHVZoHlxf1x8vrbSiyG31DnReRFJlRyl1FDAqDLJXStfvPFtz62G9UrVsQy3WLgWmb3TOXqbZ+xbdEA1AKvPzd8g3fZvJh9PinXiCrGfh6MsPsREAY9wJIsCjunFIkaZhhKe3GP4X4nTrQuHdVC638rTFge4ibuOmn3jv8+Xr+ecH+zdb4+aO7GcZUc48jXQEwZgKAcWn2jJnSpfzryuFClpK7p/Pf+luUxglOWJTBqCKNLQwzOs84WGMivPLDaSAtU7EvKdVfrT4fDN2cKksMWGy0Y8mWgAZU+h15qUASlSem1lR6yUjWc9LoM5W0PvfOKiwuhtkOFE0D5WxS5jfGP41wtlPZ79LgpvTI0DgOSFNMDkTRRIrRIN9UyLMIM/3R8+n3FsRz8chgOA+0OsK3gUReOLrfxj0YPYclfzJwPBxLe83TxRzgL74HQzq75+4iczCCr9nviCDB58N7Nai7KaBebWOIeUcZ bIlyuJmr 7Vsltxt3C0nuBf+zIH+QCPerMVT8Q16D1W7JfpTSlLSpE6wW0Y6sIluHW0txjipUx7Kb/S5R23BuUzkLVmYP8lLaEb7l/hXbxBXHLvMnX6hQ4ir3M865WzTHEbJfH6n4xkuFZ+8EaS2b8cHiif+CYxu10trSlMuxXBHvXrwOWn2IYX/j6Ly4xboQC04NU3HA95N4J3/4p+X8D31R5WsCbh3Z+wQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Tue, Jan 30, 2024 at 10:22:11AM +0530, Anshuman Khandual wrote: > > > On 1/29/24 17:21, Alexandru Elisei wrote: > > Hi, > > > > On Mon, Jan 29, 2024 at 02:54:20PM +0530, Anshuman Khandual wrote: > >> > >> > >> On 1/25/24 22:12, Alexandru Elisei wrote: > >>> The CMA_ALLOC_SUCCESS, respectively CMA_ALLOC_FAIL, are increased by one > >>> after each cma_alloc() function call. This is done even though cma_alloc() > >>> can allocate an arbitrary number of CMA pages. When looking at > >>> /proc/vmstat, the number of successful (or failed) cma_alloc() calls > >>> doesn't tell much with regards to how many CMA pages were allocated via > >>> cma_alloc() versus via the page allocator (regular allocation request or > >>> PCP lists refill). > >>> > >>> This can also be rather confusing to a user who isn't familiar with the > >>> code, since the unit of measurement for nr_free_cma is the number of pages, > >>> but cma_alloc_success and cma_alloc_fail count the number of cma_alloc() > >>> function calls. > >>> > >>> Let's make this consistent, and arguably more useful, by having > >>> CMA_ALLOC_SUCCESS count the number of successfully allocated CMA pages, and > >>> CMA_ALLOC_FAIL count the number of pages the cma_alloc() failed to > >>> allocate. > >>> > >>> For users that wish to track the number of cma_alloc() calls, there are > >>> tracepoints for that already implemented. > >>> > >>> Signed-off-by: Alexandru Elisei > >>> --- > >>> mm/cma.c | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/mm/cma.c b/mm/cma.c > >>> index f49c95f8ee37..dbf7fe8cb1bd 100644 > >>> --- a/mm/cma.c > >>> +++ b/mm/cma.c > >>> @@ -517,10 +517,10 @@ struct page *cma_alloc(struct cma *cma, unsigned long count, > >>> pr_debug("%s(): returned %p\n", __func__, page); > >>> out: > >>> if (page) { > >>> - count_vm_event(CMA_ALLOC_SUCCESS); > >>> + count_vm_events(CMA_ALLOC_SUCCESS, count); > >>> cma_sysfs_account_success_pages(cma, count); > >>> } else { > >>> - count_vm_event(CMA_ALLOC_FAIL); > >>> + count_vm_events(CMA_ALLOC_FAIL, count); > >>> if (cma) > >>> cma_sysfs_account_fail_pages(cma, count); > >>> } > >> > >> Without getting into the merits of this patch - which is actually trying to do > >> semantics change to /proc/vmstat, wondering how is this even related to this > >> particular series ? If required this could be debated on it's on separately. > > > > Having the number of CMA pages allocated and the number of CMA pages freed > > allows someone to infer how many tagged pages are in use at a given time: > > That should not be done in CMA which is a generic multi purpose allocator. Ah, ok. Let me rephrase that: Having the number of CMA pages allocated, the number of failed CMA page allocations and the number of freed CMA pages allows someone to infer how many CMA pages are in use at a given time. That's valuable information for software designers and system administrators, as it allows them to tune the number of CMA pages available in a system. Or put another way: what would you consider to be more useful? Knowing the number of cma_alloc()/cma_release() calls, or knowing the number of pages that cma_alloc()/cma_release() allocated or freed? > > > (allocated CMA pages - CMA pages allocated by drivers* - CMA pages > > released) * 32. That is valuable information for software and hardware > > designers. > > > > Besides that, for every iteration of the series, this has proven invaluable > > for discovering bugs with freeing and/or reserving tag storage pages. > > I am afraid that might not be enough justification for getting something > merged mainline. > > > > > *that would require userspace reading cma_alloc_success and > > cma_release_success before any tagged allocations are performed. > > While assuming that no other non-memory-tagged CMA based allocation amd free > call happens in the meantime ? That would be on real thin ice. > > I suppose arm64 tagged memory specific allocation or free related counters > need to be created on the caller side, including arch_free_pages_prepare(). I'll think about this. At the very least, I can add tracepoints. Thanks, Alex