From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9407C47DDF for ; Tue, 30 Jan 2024 11:57:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FC976B0085; Tue, 30 Jan 2024 06:57:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AC136B0087; Tue, 30 Jan 2024 06:57:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49B496B0089; Tue, 30 Jan 2024 06:57:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 398446B0085 for ; Tue, 30 Jan 2024 06:57:38 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 02084160AE4 for ; Tue, 30 Jan 2024 11:57:37 +0000 (UTC) X-FDA: 81735827796.14.9DCA630 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf13.hostedemail.com (Postfix) with ESMTP id 586722000B for ; Tue, 30 Jan 2024 11:57:36 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf13.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706615856; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yYUYCfYj+atjeiVED4RcYbMUZHxrScHKHvhTWCrE9wQ=; b=RZtqRwRbLgO8isjI6WV63vfT4nbj4wMhL7Nb15duJMRzs/jVX6rG7ZQTq+jN4x0v+fXzlT 53+ELdj1OsAdZ7M3NUPrYXJ/2vr38NMkxz1SDSwkdjBaHlQnUCgQMSN0eFQMYKCRYUUARM nyUHpn2+yFC6zjA/lpALZts2cAZ6BPk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf13.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706615856; a=rsa-sha256; cv=none; b=eVE2+OgmAYhfcpXps6Emf6AOek4LohtAShDiENXyorpalIj5R1Eomu6hS/m6+/TMGOShsE Z18SDuT26rK/9947YhIlqTeYP+qWQcQ6TsxT5Z275kwkUgDRtjtW5VfgrWZnrO51yByfmu 4l0MYl5DIenCWe2llYIiyoaqpzyoHzU= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4EDF3DA7; Tue, 30 Jan 2024 03:58:19 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 194363F762; Tue, 30 Jan 2024 03:57:29 -0800 (PST) Date: Tue, 30 Jan 2024 11:57:23 +0000 From: Alexandru Elisei To: Anshuman Khandual Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v3 04/35] mm: page_alloc: Partially revert "mm: page_alloc: remove stale CMA guard code" Message-ID: References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-5-alexandru.elisei@arm.com> <966a1a84-76dc-40da-bde2-251d2a81ee31@arm.com> <3983416f-b613-42c7-bb42-d3ab268ea1be@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3983416f-b613-42c7-bb42-d3ab268ea1be@arm.com> X-Rspamd-Queue-Id: 586722000B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: mscetn8rr9ah5e9mede3i8pf99ifddz8 X-HE-Tag: 1706615856-195100 X-HE-Meta: U2FsdGVkX19JF1ArGCimLJFh1SHvqiwuN+CsQoF5Own3+/LVouXaWw1XlebO+ABk1wkz+qy6mFSiPLaE32V6GuVYN0W16KeSLxvwc0GM78kRj5lt4qqBk6XuFeXQAzcIDmMHwbJ+3hpO5ec/Ir+PQg6z6l01Tczse8WB/ojfJJLpoSXcTOg0aoF2+eszz/oRay5s0XqXaQ/uk7jDbFiCL/1xPE5PQrvLFWSkGSd3VjAfwS2f2MW6hMUcT1l3SkFctCVIRy98uDkQk5JktcTfn2qiTTcC7Uc4/b2P9PqREAWgbtPna89e87t84g+tPbTrdjZcIGAqws+3chE3ZGQoVkB7YzWdX/mfZVgUSyvD9V/QiaSKlSr6PwnXxTh8oNC873Y0hW8wMFR0EXbXIf1De6i57z1qJsP2uPOgimTTrVzAt0wcDvCvujRjEhrpdn+FnBmkFTrlpz8B8RM14iqFejiIFS3WUygN7JVpA83ls3Sc+wsA/PLsRD8rGXpzGpDOJYWHZTas1JJRKh5VrNXbpBKOVot80EL2O8c2cWzrc03w5/6SwFFpLiOd6ilfgwx1vWwITlg7RYVAEwm3Eso96TwmiGupRUNc/LMoCmRYKS0ZigFmT06aSOlRX+imLFSogfWJO5VsSzDiO8x7leaWT7JBI5HYqfqNtnVxr5STy1oie5W6x7eQ82ZuWVyBgBHCECHRnj/zlEXJen4j3bVuq1O79NwPOx333U7w/6PHgUElTjc6DH4JeWGePehJu6mFXRDUN6jHqxSkY/99CZ11xvNx/gTjVfDCGxpjhAXJ8pghpu1DPXXENVK8acu8ylfdc13o2b+KC8xTkoav5I9CnFvaRDpnfRvI6vJ8RorlM/jCcV9nezmBog9E/H06mdXifXvZaltqpESxAK1ZsPodELf0YsBdBqbIOwdcOdwd/IvAbf5uxpR7Lb1oIiC5yVu0XNh6S+J1R0ou4IhpvGX bEk581AT idgfe9tBiIGwgq7OVWtGmkQKhVJSQy4PN6tWZQXvHEzmouC17WuNeMNejjIasQzr2f4aA5idAInDNSf+jrr/5i7EbosaMkYpbw21pFXCpqSoNEbCaW9sdfIcEfUsRcAZ82/8wkUHRkaExnepE9ETRSIcQ5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Tue, Jan 30, 2024 at 10:04:02AM +0530, Anshuman Khandual wrote: > > > On 1/29/24 17:16, Alexandru Elisei wrote: > > Hi, > > > > On Mon, Jan 29, 2024 at 02:31:23PM +0530, Anshuman Khandual wrote: > >> > >> > >> On 1/25/24 22:12, Alexandru Elisei wrote: > >>> The patch f945116e4e19 ("mm: page_alloc: remove stale CMA guard code") > >>> removed the CMA filter when allocating from the MIGRATE_MOVABLE pcp list > >>> because CMA is always allowed when __GFP_MOVABLE is set. > >>> > >>> With the introduction of the arch_alloc_cma() function, the above is not > >>> true anymore, so bring back the filter. > >> > >> This makes sense as arch_alloc_cma() now might prevent ALLOC_CMA being > >> assigned to alloc_flags in gfp_to_alloc_flags_cma(). > > > > Can I add your Reviewed-by tag then? > > I think all these changes need to be reviewed in their entirety > even though some patches do look good on their own. For example > this patch depends on whether [PATCH 03/35] is acceptable or not. > > I would suggest separating out CMA patches which could be debated > and merged regardless of this series. Ah, I see, makes sense. Since basically all the core mm changes are there to enable dynamic tag storage for arm64, I'll hold on until the series stabilises before separating the core mm from the arm64 patches. Thanks, Alex