From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23910C46CD2 for ; Tue, 30 Jan 2024 11:56:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F3256B0085; Tue, 30 Jan 2024 06:56:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A34F6B0087; Tue, 30 Jan 2024 06:56:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86B126B0089; Tue, 30 Jan 2024 06:56:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7822F6B0085 for ; Tue, 30 Jan 2024 06:56:46 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3E457A04B9 for ; Tue, 30 Jan 2024 11:56:46 +0000 (UTC) X-FDA: 81735825612.14.8F8AEDA Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 8DA00100026 for ; Tue, 30 Jan 2024 11:56:44 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706615804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EB1oN8dOUIbK4ejujs2HiYhGVZFxIgJJ9yM0W8xs9Fc=; b=hkfTG3Gcytg9nVrsCm+pJEPguNbx2ONE/4Cb/wlsFIvQjr/Hf2LtTahl/TVgARPLRJ7low VbUfAbZevDY6NSgYZPTKZtcHOPaYYapr8i1rUg97+Oc9kGj2fLUfSDTsrWf0tKlPbNZRRz bbqbYAMebRRl0oRXhPU70cob/BKhKbs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706615804; a=rsa-sha256; cv=none; b=K6iXz7/NtGUEh8y0bWk3/dIVnsUUM/4+neFCbkOLqHvEUwL8+92JOsFM8Q28WifVzN/ZRY RGC/TGPlVG2oSAAFyy8Rt+37kdzcCYU616+yp7a0Co3s1WgR8jsZ7zR5IaVQVhY1jfDOit pIPjHTxmToJt8uRADo4/hPPZLYS1dqw= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 37B73DA7; Tue, 30 Jan 2024 03:57:27 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1B37A3F762; Tue, 30 Jan 2024 03:56:37 -0800 (PST) Date: Tue, 30 Jan 2024 11:56:31 +0000 From: Alexandru Elisei To: Anshuman Khandual Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v3 01/35] mm: page_alloc: Add gfp_flags parameter to arch_alloc_page() Message-ID: References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-2-alexandru.elisei@arm.com> <3fbfb5fc-83a4-49da-ba75-9b671ffe0569@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3fbfb5fc-83a4-49da-ba75-9b671ffe0569@arm.com> X-Rspamd-Queue-Id: 8DA00100026 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: cdgkhfqtcckaio9rgf4go84n8u4eu7rh X-HE-Tag: 1706615804-556468 X-HE-Meta: U2FsdGVkX1/ZtmWk4HHNqYS/mHmsVC4U5UAWM7i1QhrCylnuJU8HHD4VHI1PUwZyVstndoRWxNACwPqRep+vN1L2tihIjpQN/MetOCWooEKq0lGVfsegKewapMXYNPDy5OTTro7/sxp3OMPaoEgzjf1KvUJMewNL4GswbQXnMz5qrZNnXkLkdaeo7nX7XLnQWgBhAJPJURMey85W3ZyyHMElYsqSVP4ZSI2JUzZQJQDGMD3A0/AEn9rlW12Q3mOY53Z0kI0E6N3L1fjLGSjOb3Vem/37m6r/eEGMB3aSd64RbyGWiCm6iawEWxxDNcaW0Du2G6QIZx5TXMeIN+ADMnmHcNdikQI65zE8Weh2O3uTYIckZ7zL4xJJy9Kzgf5FKDPDUCcJ7Xt5Vk7OfNCe+h987JjW+AqeUSfh4SGVEBKv0WKB2JgeeFHQh6nS5uUeWYWUkZpI6EhmV3S0Wez7mY0nsADRxZ59LjNQ/SIRJ0aEi3VBlHkdfSqnfdFcd0jEM4gqL9cUXwoTvlge6TqkrHlGTGlXQTagKuoj414gHYm2+l7RZtmB5Coz1wkekC41ZuIxyfPHD+UOyw7TltlT/QshEg6xxU0YIwbwfuppBJ2bSgPzbD4OSOgNWYLRo2RXyQNUUQXqVNFovo5z4qUjPEhHLVPHFLp4TFe3zIx20dnF3XDQojmGnVHGGNT8wQJeJAJm4Gqj3L/IDDqtsqt2hlh2rnYBBLAvnlbBZoRg48/DJXK9wi6qowhLkp/DvG7h7wZPi8+cjq3qFxvN/qySr69fLyaGThlDFV6Mn/cSS3R/u+EBOpTPV2ebr+CKepxenZ7frwADq407L3YKjvlYAmwdEteJ6RmpJQnpMrduSlHcMCQ8YJOUd2Op6tUEKo5imBujcsMQsoGfw1q5CjxTdh9ETF4/4s8q2ENShTl6ekyXf584m9DSwR8U/2mWMZMfRI8voSBB8/bgwgvqXTP MM3DmY+i dyK5OTQ/72GckwkOLwLD3vp2GKSMe9YBPFK8kS1MeHtOMhchLvrfo0lq/+e/HwI3V+FqFaaGrGf4+9XSgN6wUZI7bNkaFI6JLRDkMBGw6ABaW/IAR7at0xz0ejIkHIYVQ2FHX2Cd5oRMfVN1KX2BfUCdG/zo/FlTYT6QzIiVq1PLCh0AMsfxmHC+0zc3o8+8b+ZBzEfDM0tO0fZ/tv6Prnr/eUFYGb7mM2hx1xg1kl4OOWroB7iU1RW8xMXyWkflC6Wd1YvqFDVxayqHA2cvZLigV7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Tue, Jan 30, 2024 at 09:56:10AM +0530, Anshuman Khandual wrote: > > > On 1/29/24 17:11, Alexandru Elisei wrote: > > Hi, > > > > On Mon, Jan 29, 2024 at 11:18:59AM +0530, Anshuman Khandual wrote: > >> On 1/25/24 22:12, Alexandru Elisei wrote: > >>> Extend the usefulness of arch_alloc_page() by adding the gfp_flags > >>> parameter. > >> Although the change here is harmless in itself, it will definitely benefit > >> from some additional context explaining the rationale, taking into account > >> why-how arch_alloc_page() got added particularly for s390 platform and how > >> it's going to be used in the present proposal. > > arm64 will use it to reserve tag storage if the caller requested a tagged > > page. Right now that means that __GFP_ZEROTAGS is set in the gfp mask, but > > I'll rename it to __GFP_TAGGED in patch #18 ("arm64: mte: Rename > > __GFP_ZEROTAGS to __GFP_TAGGED") [1]. > > > > [1] https://lore.kernel.org/lkml/20240125164256.4147-19-alexandru.elisei@arm.com/ > > Makes sense, but please do update the commit message explaining how > new gfp mask argument will be used to detect tagged page allocation > requests, further requiring tag storage allocation. Will do, thanks! Alex