From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8B99C46CD2 for ; Tue, 30 Jan 2024 11:36:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DA756B0087; Tue, 30 Jan 2024 06:36:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 68A876B0093; Tue, 30 Jan 2024 06:36:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52C0A6B0095; Tue, 30 Jan 2024 06:36:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3EDB86B0087 for ; Tue, 30 Jan 2024 06:36:06 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D78E61C0FE8 for ; Tue, 30 Jan 2024 11:36:05 +0000 (UTC) X-FDA: 81735773490.27.C9C7424 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf16.hostedemail.com (Postfix) with ESMTP id 30A0C180004 for ; Tue, 30 Jan 2024 11:36:04 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706614564; a=rsa-sha256; cv=none; b=a3TmatHUFxmdekSp6QdoksbcLwidG2LLqIlekEBTxfyMiCb52U6eNxwkD/6NDItWHe3cKc jC76YEdPQOTw2EF3IRQ3ZWmgtst1MtTRCZo2i9xLZ5cFlO6/WiHrfFQdNQnmiJHhxdl8es E2U1juFuGEsCFysfRthgTJzK+YPgspA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706614564; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z6M1zLAbmnoQyRe+J9ViAMC9YzK8/2m7BGTSl1qFou0=; b=pAnjBR0FyVnR8nEP6vFPVWV5sHm2SheDOgRJezo61GH+XhggBiGgU17SocWSxCZjNNuIU4 lrMydF950ngnwnZLmyeKVnlXSOd4t+2WcVR89tjBOYTJ57WbYCNEQAbEAzZYSydGJaZSjv Bv+SIr10WZEthrtqdExg4oAsmEDH0Hs= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 09868DA7; Tue, 30 Jan 2024 03:36:47 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D4B3C3F5A1; Tue, 30 Jan 2024 03:35:57 -0800 (PST) Date: Tue, 30 Jan 2024 11:35:47 +0000 From: Alexandru Elisei To: Anshuman Khandual Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v3 08/35] mm: cma: Introduce cma_alloc_range() Message-ID: References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-9-alexandru.elisei@arm.com> <61a3dbb7-25b6-4f49-aa70-9a8aaeb53365@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <61a3dbb7-25b6-4f49-aa70-9a8aaeb53365@arm.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 30A0C180004 X-Stat-Signature: dtoyez8746qrwzahyitfm7yqqtknyrrh X-HE-Tag: 1706614563-791626 X-HE-Meta: U2FsdGVkX18UUS+pynCJlWAz52hysun3rWZ3HjHbc8+qI9i2IKjGfArItIdAFjRPSxNoIasS89oOYbr9qFcy8JUUGEiXkKdbncvF4pElTQbxqSf3uTspETseoYFr7JIJJA4QW0EeFxMVI6IWD4DEwz3D+sFsypeSK1W+CWopVXsKONkNXaLnIff9RCbBEoM3zTlw13+svxVf92uQHkfJfDNbLsuqp0o1PBPpHicM/v+bZwJh/u9VQbOScE0+uv6tohXlsRx6Gj12FAj2FSvrs0JIHnNV9zacrQOJk8q2cVNkFN75RU4UCdZx36EvIXZaMhTHUbmyTh/+dyUBD18nyL6rrIiMNnX39gjh2YD6lSJF5ggJaIG3xrF00Iw6Wa86JGJ8QbVHUkb7jlSvpcrUCQo7+Ey411izCt3YwaK9DEWpCduxnSppyw03NhEZU1HgoMibnCIZFtxkRsbCQMJoID1TmMTZ1q8YeQlAuZ8M03elZnDG7DENr51QV6FEHuxrH1j/KYFd8v5G9o1VXfFGX9E0OV2eCFhY5NeCb2AkEAI2HM69H9SZzg8yngCWjUeCi1pC+83LdbfEE5L0vrLiZMrCtXbqTkzKWW66YOffoa16CpJ87HSVWhpWFlVRko/sdAGhXmArHlYnq5uC+yEmilyxr36o1KWCiOeYWF8llT71yHZxl6Ceq0S9hkYy6NU+tByLdQ/q97+eVDLFhfUUKmOvr6HwuoNK9zuwV8q+nO0xfJNrgjQuWJJCmK3sEGrlSejmvomXlwB5i3rvskWmqlx70j5nbS/O0TxuZzqW3cxyamwpPkRSF9U5+aqGtO1G6dvYbtxrlwpxCyNGlXAaP9GXPN2AfUvBAxGHHiBwgbCt3MBhsjaZKH1iy73HlqM9DAdVohomdI/9QBsXUd2uawZzSZWcQLo/shKc29aJc7A7eG3Tiubz+iUQB40GiH+4nqXVU36yb+w8QOlUgmL GVMC7TD4 jUdTAzRRioUQiTvqqzz/hekYirmn8JoB6QAg44QVKe7CQBdbVPw+9StzJtUm1IifHkWL/w8wZGeW0lH8Hf7e7BpMfR0S5SyiW3Eeev5nIJfNHjLtIP4ro8lxmAHjORJNKsjtZMBuUNjK9yh5CweSSdfqpEXlKtRCh3nFIh8gerb93MeB8Jv2O5i4KGCHz8LsZApnGuufu9Io2Y39dVVM3cbZ28euCh43qB0nNoWV/5tRLK5eCEUu50r6uMvE8d22zZR5aXP+4JDefcIg/ITzB/nIufenbzoNyv/B7T3ri+KgFlQo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Tue, Jan 30, 2024 at 10:50:00AM +0530, Anshuman Khandual wrote: > > > On 1/25/24 22:12, Alexandru Elisei wrote: > > Today, cma_alloc() is used to allocate a contiguous memory region. The > > function allows the caller to specify the number of pages to allocate, but > > not the starting address. cma_alloc() will walk over the entire CMA region > > trying to allocate the first available range of the specified size. > > > > Introduce cma_alloc_range(), which makes CMA more versatile by allowing the > > caller to specify a particular range in the CMA region, defined by the > > start pfn and the size. > > > > arm64 will make use of this function when tag storage management will be > > implemented: cma_alloc_range() will be used to reserve the tag storage > > associated with a tagged page. > > Basically, you would like to pass on a preferred start address and the > allocation could just fail if a contig range is not available from such > a starting address ? > > Then why not just change cma_alloc() to take a new argument 'start_pfn'. > Why create a new but almost similar allocator ? I tried doing that, and I gave up because: - It made cma_alloc() even more complex and hard to follow. - What value should 'start_pfn' be to tell cma_alloc() that it should be ignored? Or, to put it another way, what pfn number is invalid on **all** platforms that Linux supports? I can give it another go if we can come up with an invalid value for 'start_pfn'. > > But then I am wondering why this could not be done in the arm64 platform > code itself operating on a CMA area reserved just for tag storage. Unless > this new allocator has other usage beyond MTE, this could be implemented > in the platform itself. I had the same idea in the previous iteration, David Hildenbrand suggested this approach [1]. [1] https://lore.kernel.org/linux-fsdevel/2aafd53f-af1f-45f3-a08c-d11962254315@redhat.com/ Thanks, Alex > > > > > Signed-off-by: Alexandru Elisei > > --- > > > > Changes since rfc v2: > > > > * New patch. > > > > include/linux/cma.h | 2 + > > include/trace/events/cma.h | 59 ++++++++++++++++++++++++++ > > mm/cma.c | 86 ++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 147 insertions(+) > > > > diff --git a/include/linux/cma.h b/include/linux/cma.h > > index 63873b93deaa..e32559da6942 100644 > > --- a/include/linux/cma.h > > +++ b/include/linux/cma.h > > @@ -50,6 +50,8 @@ extern int cma_init_reserved_mem(phys_addr_t base, phys_addr_t size, > > struct cma **res_cma); > > extern struct page *cma_alloc(struct cma *cma, unsigned long count, unsigned int align, > > bool no_warn); > > +extern int cma_alloc_range(struct cma *cma, unsigned long start, unsigned long count, > > + unsigned tries, gfp_t gfp); > > extern bool cma_pages_valid(struct cma *cma, const struct page *pages, unsigned long count); > > extern bool cma_release(struct cma *cma, const struct page *pages, unsigned long count); > > > > diff --git a/include/trace/events/cma.h b/include/trace/events/cma.h > > index 25103e67737c..a89af313a572 100644 > > --- a/include/trace/events/cma.h > > +++ b/include/trace/events/cma.h > > @@ -36,6 +36,65 @@ TRACE_EVENT(cma_release, > > __entry->count) > > ); > > > > +TRACE_EVENT(cma_alloc_range_start, > > + > > + TP_PROTO(const char *name, unsigned long start, unsigned long count, > > + unsigned tries), > > + > > + TP_ARGS(name, start, count, tries), > > + > > + TP_STRUCT__entry( > > + __string(name, name) > > + __field(unsigned long, start) > > + __field(unsigned long, count) > > + __field(unsigned, tries) > > + ), > > + > > + TP_fast_assign( > > + __assign_str(name, name); > > + __entry->start = start; > > + __entry->count = count; > > + __entry->tries = tries; > > + ), > > + > > + TP_printk("name=%s start=%lx count=%lu tries=%u", > > + __get_str(name), > > + __entry->start, > > + __entry->count, > > + __entry->tries) > > +); > > + > > +TRACE_EVENT(cma_alloc_range_finish, > > + > > + TP_PROTO(const char *name, unsigned long start, unsigned long count, > > + unsigned attempts, int err), > > + > > + TP_ARGS(name, start, count, attempts, err), > > + > > + TP_STRUCT__entry( > > + __string(name, name) > > + __field(unsigned long, start) > > + __field(unsigned long, count) > > + __field(unsigned, attempts) > > + __field(int, err) > > + ), > > + > > + TP_fast_assign( > > + __assign_str(name, name); > > + __entry->start = start; > > + __entry->count = count; > > + __entry->attempts = attempts; > > + __entry->err = err; > > + ), > > + > > + TP_printk("name=%s start=%lx count=%lu attempts=%u err=%d", > > + __get_str(name), > > + __entry->start, > > + __entry->count, > > + __entry->attempts, > > + __entry->err) > > +); > > + > > TRACE_EVENT(cma_alloc_start, > > > > TP_PROTO(const char *name, unsigned long count, unsigned int align), > > diff --git a/mm/cma.c b/mm/cma.c > > index 543bb6b3be8e..4a0f68b9443b 100644 > > --- a/mm/cma.c > > +++ b/mm/cma.c > > @@ -416,6 +416,92 @@ static void cma_debug_show_areas(struct cma *cma) > > static inline void cma_debug_show_areas(struct cma *cma) { } > > #endif > > > > +/** > > + * cma_alloc_range() - allocate pages in a specific range > > + * @cma: Contiguous memory region for which the allocation is performed. > > + * @start: Starting pfn of the allocation. > > + * @count: Requested number of pages > > + * @tries: Number of tries if the range is busy > > + * @no_warn: Avoid printing message about failed allocation > > + * > > + * This function allocates part of contiguous memory from a specific contiguous > > + * memory area, from the specified starting address. The 'start' pfn and the the > > + * 'count' number of pages must be aligned to the CMA bitmap order per bit. > > + */ > > +int cma_alloc_range(struct cma *cma, unsigned long start, unsigned long count, > > + unsigned tries, gfp_t gfp) > > +{ > > + unsigned long bitmap_maxno, bitmap_no, bitmap_start, bitmap_count; > > + unsigned long i = 0; > > + struct page *page; > > + int err = -EINVAL; > > + > > + if (!cma || !cma->count || !cma->bitmap) > > + goto out_stats; > > + > > + trace_cma_alloc_range_start(cma->name, start, count, tries); > > + > > + if (!count || start < cma->base_pfn || > > + start + count > cma->base_pfn + cma->count) > > + goto out_stats; > > + > > + if (!IS_ALIGNED(start | count, 1 << cma->order_per_bit)) > > + goto out_stats; > > + > > + bitmap_start = (start - cma->base_pfn) >> cma->order_per_bit; > > + bitmap_maxno = cma_bitmap_maxno(cma); > > + bitmap_count = cma_bitmap_pages_to_bits(cma, count); > > + > > + spin_lock_irq(&cma->lock); > > + bitmap_no = bitmap_find_next_zero_area(cma->bitmap, bitmap_maxno, > > + bitmap_start, bitmap_count, 0); > > + if (bitmap_no != bitmap_start) { > > + spin_unlock_irq(&cma->lock); > > + err = -EEXIST; > > + goto out_stats; > > + } > > + bitmap_set(cma->bitmap, bitmap_start, bitmap_count); > > + spin_unlock_irq(&cma->lock); > > + > > + for (i = 0; i < tries; i++) { > > + mutex_lock(&cma_mutex); > > + err = alloc_contig_range(start, start + count, MIGRATE_CMA, gfp); > > + mutex_unlock(&cma_mutex); > > + > > + if (err != -EBUSY) > > + break; > > + } > > + > > + if (err) { > > + cma_clear_bitmap(cma, start, count); > > + } else { > > + page = pfn_to_page(start); > > + > > + /* > > + * CMA can allocate multiple page blocks, which results in > > + * different blocks being marked with different tags. Reset the > > + * tags to ignore those page blocks. > > + */ > > + for (i = 0; i < count; i++) > > + page_kasan_tag_reset(nth_page(page, i)); > > + } > > + > > +out_stats: > > + trace_cma_alloc_range_finish(cma->name, start, count, i, err); > > + > > + if (err) { > > + count_vm_events(CMA_ALLOC_FAIL, count); > > + if (cma) > > + cma_sysfs_account_fail_pages(cma, count); > > + } else { > > + count_vm_events(CMA_ALLOC_SUCCESS, count); > > + cma_sysfs_account_success_pages(cma, count); > > + } > > + > > + return err; > > +} > > + > > + > > /** > > * cma_alloc() - allocate pages from contiguous area > > * @cma: Contiguous memory region for which the allocation is performed. >