From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4A4DC48285 for ; Tue, 30 Jan 2024 13:52:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40D386B0075; Tue, 30 Jan 2024 08:52:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BC2C6B007E; Tue, 30 Jan 2024 08:52:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 285CF6B0083; Tue, 30 Jan 2024 08:52:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 153856B0075 for ; Tue, 30 Jan 2024 08:52:21 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DCD3A14048E for ; Tue, 30 Jan 2024 13:52:20 +0000 (UTC) X-FDA: 81736116840.30.681B51E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 2B94210001E for ; Tue, 30 Jan 2024 13:52:17 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AG7TSczF; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706622739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VcsdYxQa1M0QQIUwllrKVKNWcmHyrB1J+JwCbDlCV40=; b=4RwYFcOef+1ngZXO/PtbtL4IS1KqHsbrvYn4qV5P7KDXLPBHA+N2polpCheVHRfBPTkJaz 5y0UHaJq9SZz0ohm3HD8OwfYaRrc7jNSWfix+o5p65nJLbcWJRUdC6UdKa0IBGLKCf2lWd KoSOWH/YrBmY8wfsEVsZLZ/nsy2ZEYU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AG7TSczF; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706622739; a=rsa-sha256; cv=none; b=OnELzvzTIpYg4jFjYGqm5X/Sc82OAQykOhgu0LcA3Nn/5aKqJ5+dICHTWQx3UwA0/5fb3H LVv6JljX4JbPFy2B4oZy8nfh4NwZMVuh1bEE65AK8/wt8WYooOuD2F562L53aaP1Thuu8Y UTBYbPSBWewfnLIUcA8A9c0Hd0wQ74s= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VcsdYxQa1M0QQIUwllrKVKNWcmHyrB1J+JwCbDlCV40=; b=AG7TSczFM7Flw+NtBumfg5BUka ZUatoQRvBWWAyH45sEq0HKWlZ6niH3NFbBbFd7VGV2BdNDU2RW5wXX3zBZ+hdsBcGIxxDmblE9ghZ ketpIOdA0YYuBqbjAp+9/LNYWn2kudrv9Hfks5HC77KY/tZys2wySTSqpMUi8/6qRHR6lSJCAdW7X vbIb+EqSe5Jo0jDK/GEHy6S74MOk3YoFKe0MnHi7gI3cAK8AYZ9JooemFQ9whngM0G0Zq7CvHs5oM /CaeuVCWywwoTjaol3QSBe4d92e1YJDw7qAbiu+xBdJ73FCWrRo7vWbAbJpgNCDZo5wgkdTCt1NkI cRafvltA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUoWx-00000009yDX-3SU4; Tue, 30 Jan 2024 13:52:03 +0000 Date: Tue, 30 Jan 2024 13:52:03 +0000 From: Matthew Wilcox To: "zhaoyang.huang" Cc: Andrew Morton , Jens Axboe , Yu Zhao , Damien Le Moal , Niklas Cassel , "Martin K . Petersen" , Hannes Reinecke , Linus Walleij , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com Subject: Re: [PATCHv5 1/1] block: introduce content activity based ioprio Message-ID: References: <20240130084207.3760518-1-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240130084207.3760518-1-zhaoyang.huang@unisoc.com> X-Rspamd-Queue-Id: 2B94210001E X-Rspam-User: X-Stat-Signature: 5b3p6jcisq98wcn7fxoms8rohwruu5ki X-Rspamd-Server: rspam01 X-HE-Tag: 1706622737-176520 X-HE-Meta: U2FsdGVkX18zXYMjh5ZsIMNLouD+pLv8RD1lzzVt2MRORbW4blyyiXQaY54rYPEvV5uBYtU7iO+PS/JSSwLro3BUdNxImcgDnM7g+dufX+jWlju8AzgHq5jKZ86Eo0340be1mCFRb4JT9T1vaddaF1QsWKD1FKszcHKroIr3+yOyvzI5eA/87BSDCNsPPX1bJHwujnYsQnBAzDWqG3n0hirQk5on36GIFrRuSSv5qMLwsw/8zGl3yiyy9crQrtzrrXOvI8MszJ9i6GXTOmJnrbfdV3hE7pkncCb37IWHkijYkzR3U4SkgBFSJmkVjW14t01dWdWVm15HRNtdlnnEAlJ55V26pn2kbd2A0MmGyEaTf6mz8Apitl/4k/qeReUVah5yWjyJuWAWuuCbEXUWE3r5OxqUwZbvVq9F4o0/YoaaNWD9uIe7iaVC8iXaDM3BNf9Pdt4/c4yKg6zcoIgjh8A2IG2w5UJ72vITClL5943jEiqfLjNhmf346rGvDzQryu+s4VOhLoUfYnSF0o8RGYDoxhD4Ws1kgGmyg/FFWK+VRq69MiS83uBCX/xRB3iF7Muou1ZpLi0IQO8MZqYkHQdOsiBd8SgX2DG1GHZl7w6mXaJ1krgsLcwTpo5oRo7jNPh4TE1Qu3MAFGtyrLMVqBX+zvoDZt5F9cVMxsZwyr2KsH4ZTeYo8o5XaZt3vcfzMAaz48meokPGDwlIxOFYKjCKp+Vdcj0GzkuZOcR/aLbvhDVqVj0D33/XSuVD5qo6asRXDUZsZ0xNvMxUqNDF0vUq0N0gwvwORniwDI5BukHryTnz6MV0ifrmcZ1HgJhuT43FvlzAqBA6Z2+2DXkt+qckDFn/k+lxPVg+aGy2BZvTpVyOg+gRRF7wUKXdURbt+bp1vixi555g9K8dB3kYhYfUVOES/we6mRej19fh+MZQsHKgFhVMNLhJW5hwrtB7N06PcxcHyq+CNeS2k5x UdZvgQIn usc2X8SO6FML1gEGI7yRQQjYokRqOjIt8yXjvhe/Lh1n8z/sAAvqILK69AkaWTo1+LW25SmDRCNI+gVEAK9/xqbidXO3sihYl5KNQ5r0+/HYqhdDxVzRe+qsk5f/Q1SEmBhdF9D5eN/up9zQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 30, 2024 at 04:42:07PM +0800, zhaoyang.huang wrote: > +static __maybe_unused > +bool act_bio_add_folio(struct bio *bio, struct folio *folio, size_t len, > + size_t off) No, stop this. What the filesystem needs to do is not s/bio_add_folio/act_bio_add_folio/. There needs to be an API to set the bio prio; something like: bio_set_active_prio(bio, folio); and then you can do whatever gunk is needed in bio_set_active_prio() to end up calling bio_set_prio().