From: Matthew Wilcox <willy@infradead.org>
To: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>, Yu Zhao <yuzhao@google.com>,
Damien Le Moal <dlemoal@kernel.org>,
Niklas Cassel <niklas.cassel@wdc.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>,
Linus Walleij <linus.walleij@linaro.org>,
linux-mm@kvack.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhaoyang Huang <huangzhaoyang@gmail.com>,
steve.kang@unisoc.com
Subject: Re: [PATCHv5 1/1] block: introduce content activity based ioprio
Date: Tue, 30 Jan 2024 13:52:03 +0000 [thread overview]
Message-ID: <Zbj_A3e1T1wRsKiM@casper.infradead.org> (raw)
In-Reply-To: <20240130084207.3760518-1-zhaoyang.huang@unisoc.com>
On Tue, Jan 30, 2024 at 04:42:07PM +0800, zhaoyang.huang wrote:
> +static __maybe_unused
> +bool act_bio_add_folio(struct bio *bio, struct folio *folio, size_t len,
> + size_t off)
No, stop this. What the filesystem needs to do is not
s/bio_add_folio/act_bio_add_folio/. There needs to be an API to set the
bio prio; something like:
bio_set_active_prio(bio, folio);
and then you can do whatever gunk is needed in bio_set_active_prio()
to end up calling bio_set_prio().
prev parent reply other threads:[~2024-01-30 13:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 8:42 zhaoyang.huang
2024-01-30 9:17 ` Damien Le Moal
2024-01-30 12:43 ` Zhaoyang Huang
2024-01-30 13:17 ` Damien Le Moal
2024-01-30 13:28 ` Zhaoyang Huang
2024-01-30 13:53 ` Damien Le Moal
2024-01-30 13:52 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zbj_A3e1T1wRsKiM@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=huangzhaoyang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin.petersen@oracle.com \
--cc=niklas.cassel@wdc.com \
--cc=steve.kang@unisoc.com \
--cc=yuzhao@google.com \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox