From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF99FC46CD2 for ; Tue, 30 Jan 2024 08:16:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B3AF6B0096; Tue, 30 Jan 2024 03:16:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 164276B009D; Tue, 30 Jan 2024 03:16:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02B6C6B00A2; Tue, 30 Jan 2024 03:16:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E76D16B0096 for ; Tue, 30 Jan 2024 03:16:31 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7A860A1AE0 for ; Tue, 30 Jan 2024 08:16:31 +0000 (UTC) X-FDA: 81735270582.21.5F811CA Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf01.hostedemail.com (Postfix) with ESMTP id C9C3F4001C for ; Tue, 30 Jan 2024 08:16:29 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TxrFhfeI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of 3XLC4ZQoKCNMNDHGNz6B325DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--yosryahmed.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3XLC4ZQoKCNMNDHGNz6B325DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--yosryahmed.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706602589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4RCvAVC7tbgz/hFRMYluBTQ9bVEmXnGW4IADGAZt7Hk=; b=vVws3kfDAoTd6r6JVKjIidHHKPvjnayDknZSO7wjSYnviTaw4aDYIBH17v/f5RDxOGf8N/ xHHnrESfXmcA8HRzNKL7S3b6Ku1+kr6n1haHdag4y2qHTfNxkDRujedZSlrpgsl4JN5iPp mtDhjROnqCMNp/cR1Pl295Y+0a+v/bs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TxrFhfeI; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of 3XLC4ZQoKCNMNDHGNz6B325DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--yosryahmed.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3XLC4ZQoKCNMNDHGNz6B325DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--yosryahmed.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706602589; a=rsa-sha256; cv=none; b=Q90v3O3ODNNRoLCluiwcifMeKxIHQN6B9s4nPLfJPw+WzqetwbTOLNtclbfPR95FCvC8v3 o7IW8suxOEXyLyWBxOxLiMiND3lBDH3X8FLUfi+JOKM1lyN/VHxZ5nksQumbdZQ3AfkhcU nZ4JisfmUU/Y0cAgkGE0Vx9NZDGXgQM= Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-603ce32f142so41930437b3.1 for ; Tue, 30 Jan 2024 00:16:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706602589; x=1707207389; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=4RCvAVC7tbgz/hFRMYluBTQ9bVEmXnGW4IADGAZt7Hk=; b=TxrFhfeIwCxL5lB/H2wKPpvTclhDcEwd9cGnc1wgMHENOpE7d2NMmaJ4d5j16fzPAQ z3Bfq4RTgHzTkQbeX2lUtHn6Az4Db6o52gXe2VXUrLkibBK8X7YXAHvf0IjbwbZQcZtu jtb9Vez7ev0RZxPZ4iZXpUFBSvQ3TvtocHRyngibqnMYq7FWekyDQR5xmB3W6Er1kKa6 2YcyEtZh4VfXi/e9h701CD+tBnkJvgmuFPH0aRJWUxTyWwmk0S6UhTjVFESkvoaKcr4c N39WzbedvMm2hGVZi6C0BOIL3o56Bgq19NPL82bJEwHD9FsPSvvJJ6Ei5np/U7P6/HSz vLAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706602589; x=1707207389; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4RCvAVC7tbgz/hFRMYluBTQ9bVEmXnGW4IADGAZt7Hk=; b=NCHatwt0bWKcXa++6MIwxrpkGd0lwTlaMBgcKS5JuUwkEDc2OU6+Q5Eoo8g/5zUUhI kTF2xfKC3ev6tbmSudh8mW1AIAGbi51CX8YFbstTpyIXIe+4oBZEWO6qxl7iFp+gMDQL 7hGljLPHgSyEeSII7Q9mnUA1advnuoAd6auML56XpnrrMQAExKuKGIhLIvq1PNhOxlb7 SRAVcOqBYYEmZ71xNtQnF+4Hi10n5n2bftFS8pGYxcxwfncVL4P9kTbFqe44pVi9EumS qGksCNdiGcyaHdLQpsEsnkG1YRGVCVDpd2S2dU9FOLXDT6+7IwTtbzF0htYKuy67nlPK LFEw== X-Gm-Message-State: AOJu0YwrI989dWJgkKMQjqXUkWKrOJaSgIVWnTFigB7+jTmS4zvnmUnO 8o19fwyJCjD3h/tInCC3o2KQ3ib5JVP+XpeUW7oxZFvk/TrtPxrcP2X9Tk/DXA4AjKJ/bJEqbUK 0ZodBku7N83morwJXsQ== X-Google-Smtp-Source: AGHT+IGsw4ahRTH+FppmK72b9mJT3O6kGJo/9A82RiTOwc5FThLF65wAN8WNRlKZrrnPjH1+X0DUWXdYHAADyvDy X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a81:5743:0:b0:5ff:88f9:96f1 with SMTP id l64-20020a815743000000b005ff88f996f1mr2361516ywb.9.1706602588977; Tue, 30 Jan 2024 00:16:28 -0800 (PST) Date: Tue, 30 Jan 2024 08:16:27 +0000 In-Reply-To: <20240130014208.565554-1-hannes@cmpxchg.org> Mime-Version: 1.0 References: <20240130014208.565554-1-hannes@cmpxchg.org> Message-ID: Subject: Re: [PATCH 00/20] mm: zswap: cleanups From: Yosry Ahmed To: Johannes Weiner Cc: Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: C9C3F4001C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: hfr8q7m4ujgkxrugh4o9r8ak3p4cb3w8 X-HE-Tag: 1706602589-229449 X-HE-Meta: U2FsdGVkX19pToO/g+YpZQ9/1fIdD+jY/rxfGgIoHT0jxI/GuSh9olRK4qPtRwkI6st/TwfEMcETHjQT7R3hp4QVx0479DFvoLzP5SpCy2nM6M3i2IRt+cWYHEIVAtZKuBOX5f6eO9A55acT/VXR9CjRAcBxoVqYOyi5NokKN4sao1JHpXHaCUu66cM1wnBUokidSmKvTkI2l5nNlynaoGl8iwijlluGRiU2iIpG8+x+g1Ou/t/BbwhPRjBPwWph+SJ87S5XMoxcCfENdlNWtsJgSa5UF+ydBGKk0vA6hx06iK6Y555TTYrGgpV6ZfNW3Gm5BCJZLVeKNcqZKtUdHVaSLiTeQ+lfC/HQSwoh6rg0sLVlxB1atTVYC1Lv8Csb2djc9h0mLh1s2k3xq9XH0bDTDoX8UcBVy0WvMhfIX9vi/b0h0HpRls9PnFooqCYPyo7lLhbmFxbt1umTqKwxMMPY4bsyH+4PLODWxIHbCDCyTbhRmdZMaFzXWoJ/7Gjo5qkLCV6S8oYp0o2wggnfljdypf6XguBMMIDlKpjHdBOTy5jzLDIEYB8450r8hUFWPDnLp121Vx5kRYkr0O0f+GMeLNEUWtn/SFbR8wZOwMT49sVHfsSKYeZh6QkIv3LCpth2eRi+4p+JapKpCII+zEB9cCaz4uyUpam1WWs/8e82GhocFjlgZ7lcQVfcYg4nDOMpgdUUYbz3Qeu/UZlZPfmroeSIUJEZqu3hxca04nZQ43Lxi3lL7tgnGuetbsC79eutSCIF1VhgQXvTPdMxrWf4IERvk5iuTwlrVVmFHcHXfadmuhOxglwX2T0OHrePK7X9RAgRkBljC8WHDOELG2cwDRU8PbcIiQKOV2On5pgsFzoSG1HyzG2E+baRTiP/7akodPqptn9qlw4k42zSLInWD5gSNVV7P3wkwjqPjpPVZuFBAQMCxYW2m5GeT/yso1ErqIhw5VBYWEOB4CF SZbT1CFS UDYbs+RFhghHENqANT5YgUcPUWP3RucEVw/EuBGexZ0tTGtbsvh3bUQgbr/Og5aEmz7uMjm58ThfXpYMjkSg43531hZlfPRopQBLe9v857opSSHeK2l/5iiP2fgEYQGMV+5rem12eUCPrqSU0w4iLqAMhZF/0RipUE+ycS8RJSAyltszKUrQj99PTEW1im3Tknd5tkjAj38hQzLRg2bgtPQR/hu/RBWjredlkL3ZnXWH+S6MtpqpQ9OjYdmdcs8IFohXozfSs2w/3ZRowRkkuI2iEd2v/1N51y1BfsfWWphVl60Y+niAupvZZODNZhBdNcWsYCxtYt2B+OhJm1PV/YPG0JmWLuhz+gzMBQbQNIRJxr4AaGILHLiOR5aVX6InH6OeAOyZ0wC2m2cxRpJvbaOTbL0s68QpPUqahpXxbofKEjBbO/ccykdo2RQSo4FYQEQrTIDvqpwk2o2WYE/vAqxZp1Ftgs41C3VAkssvQxLcGitlI9Lw7F+xAJtvggIE98Q/scQhlhkt8TJQ/tFzf7kBGFqC+9l2Zlr/+lST21N05eLkIvo1X2GxJo0AWhF11qQLHyTRlOLGN5ZrqGHu7MKDmxmhrA3TtIQsv3VTfsxBXNWHRuHGu3nDtSIxbwVEofv7w X-Bogosity: Ham, tests=bogofilter, spamicity=0.005779, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey Johannes, On Mon, Jan 29, 2024 at 08:36:36PM -0500, Johannes Weiner wrote: > Cleanups and maintenance items that accumulated while reviewing zswap > patches. Based on akpm/mm-unstable + the UAF fix I sent just now. Patches 1 to 9 LGTM, thanks for the great cleanups! I am less excited about patches 10 to 20 though. Don't get me wrong, I am all of logically ordering the code. However, it feels like in this case, we will introduce unnecessary layers in the git history in a lot of places where I find myself checking the history regularly. Personally, I tend to jump around the file using vim search or using a cscope extension to find references/definitions, so I don't feel a need for such reordering. I am not objecting to it, but I just find it less appealing that the rest of the series. > > mm/zswap.c | 1961 +++++++++++++++++++++++++++++----------------------------- > 1 file changed, 971 insertions(+), 990 deletions(-) >