From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78026C46CD2 for ; Tue, 30 Jan 2024 08:12:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1CB56B00A0; Tue, 30 Jan 2024 03:12:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ECCED6B00A1; Tue, 30 Jan 2024 03:12:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBC2E6B00A2; Tue, 30 Jan 2024 03:12:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CA4476B00A0 for ; Tue, 30 Jan 2024 03:12:40 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A5C32A0A5B for ; Tue, 30 Jan 2024 08:12:40 +0000 (UTC) X-FDA: 81735260880.30.05DB771 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf12.hostedemail.com (Postfix) with ESMTP id 03FA640006 for ; Tue, 30 Jan 2024 08:12:38 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=SIlx5i0J; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of 3dq-4ZQoKCOslbfelNUZRQTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--yosryahmed.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3dq-4ZQoKCOslbfelNUZRQTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--yosryahmed.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706602359; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AIFgjiuxwRuK6BHQq+omF6J4YBG6WwTGzt+ObEmxSXA=; b=zXrHjvyU0+mrd2kUjKMAf6pOSjvN6tygUxHLouBExuUhgjYOi70DsL8Xg1/TcaBMGMyHFl J8wyQyZbAAxtOJ31meEzAA+UUD0/XeOX+njZBrK8+0Sth/7xaaNn1TuUIR6Rt9tZ7tjeNI WlK3LsFCtViZVih8xxglz8jYug9Pka4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=SIlx5i0J; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of 3dq-4ZQoKCOslbfelNUZRQTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--yosryahmed.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3dq-4ZQoKCOslbfelNUZRQTbbTYR.PbZYVahk-ZZXiNPX.beT@flex--yosryahmed.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706602359; a=rsa-sha256; cv=none; b=U3W5kRpLKQTQxZj26KLE8mdcxICdeWDPJ9KGP8fdJ6R81lQBCo8eUF25tLSX+hJ9gYEZcF XUSn8cLepckBdnPbquIX9rl3LK9JHqPD9lauuYx9F+9Cqy7lg7yiZ7FiypO0msZ/bi158r 0Dnc+hMnwuH2e4LHSvl2WDXFx9rgpD8= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dc657e9bdc4so5099743276.0 for ; Tue, 30 Jan 2024 00:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706602358; x=1707207158; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=AIFgjiuxwRuK6BHQq+omF6J4YBG6WwTGzt+ObEmxSXA=; b=SIlx5i0JBRYtnBeEpuHgeo7uLdpQcgzb0As4s50ucaLQg2OVdwNmtFpmLeObbdu9jq FsJvkraFRjoFZ1pPMpw2ZNa0Ia3UCAADNg0qXc8N43JgOza9KGERcoTQEEKoIIFvvFk5 /VCnqhWWSiv6GSSKQpn4OJvXeELImx6kIGiQG2Sm+w+Mp+ynXF08EW/3f/IcRUmWhbxc 9EMagGf4TuIVvt1lrUCGwCsvKsau9hNqrEGi/Te6Y90EEl6I+vFwZSDeTytYBtUqGEbk s6DtHUiP+IoVzoTAqqIWMT20xT1oe5mtxZ7g/bpfxJJ1XaWITbwy1YqGo91lm8WRJOtJ rtZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706602358; x=1707207158; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AIFgjiuxwRuK6BHQq+omF6J4YBG6WwTGzt+ObEmxSXA=; b=GJUDVllJHClRLQvDbUDpVM44hT9ShEi9BWaG7uSVGic5P4moBWd8xT7k6QAV5sH9AB G1btxbSTXdcUQqCT7fhr6DL8kHyV13vn0C4/3QOndfaOdzZ4xWowC8eEuOTa0uUNwRtF hucmA9f6aczjLEg4TY+kdgOPXJe1HxDprAbRy1R17EBUTFYv+0Q6k1vSmkGM0cFF5jT/ N3pQ7Q3zVnDl8CBvM9NLdsCSu3EraXno6MQYGcXmgJmneSgVbFjCvW8YuP7NtBHgz6cc MsBSqaLNo3fH8eUrXHKNapfSLq3SuLr3DnFNdDss1aA1Gw6HYJ4/jsqVKyJ6n//hAScs 9fbg== X-Gm-Message-State: AOJu0YylZKguzV4fwtJo4OW4BWHiSPhn7bFs/UTcWGh/9FequittRPS7 poD6GO+GWJeQRihL+DEUHnqQpKFiPJIdBVwhMa3tAiIrXynL8lDBJsrU4CYAV1lfVeggLC48TDW 2HCQNrFkt/Jsm13j0Qw== X-Google-Smtp-Source: AGHT+IHvew4TiPu39aPMVPJ/xg1WbVfx9ZUC7tvmWTT6gWc2ZU8GFDvPJF34JVHQdfYQ1kuzlvjOeqk/piqEK/CT X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:6902:2501:b0:dc2:57c9:b462 with SMTP id dt1-20020a056902250100b00dc257c9b462mr494232ybb.9.1706602358253; Tue, 30 Jan 2024 00:12:38 -0800 (PST) Date: Tue, 30 Jan 2024 08:12:36 +0000 In-Reply-To: <20240130014208.565554-10-hannes@cmpxchg.org> Mime-Version: 1.0 References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-10-hannes@cmpxchg.org> Message-ID: Subject: Re: [PATCH 09/20] mm: zswap: simplify zswap_invalidate() From: Yosry Ahmed To: Johannes Weiner Cc: Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Stat-Signature: m8x64n7esr85a6m33r4n7s14wgijka91 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 03FA640006 X-HE-Tag: 1706602358-857137 X-HE-Meta: U2FsdGVkX194+P+bDR2/W7mwGUdfbchpzKeGVMI7k1OO+V5u+XM6TkiIOeiS6sW3A6LARrN2t/xC8ih7q2GQPDUgMEZYNC0wobmHZlbnxwXJRsFFRMUmlg4UnJF5xTEEtDkxW/VNaScKQs7PsP2ESPNmzGGhuU6ppaMClHA+v4Ol1y3HcX7+i0cVDdzPHJGoadPxZQPZjljDM2jBBlXAJV4eyVC1r+GIiejIe5MiacH/RSKFWnRXN8wlPyR4Y4R8eMWUeJySq/vg9vC9qyC9qfbG9KeLO79E1VCQmHfSxGZPCQThn3eJO1dQ/dDqzfFRgjtnADqelbk0QsA07xZevDJbG3qe192Y6BHgQjS7p89BxhI0fggWEiNJ31ZtAL2Pn0J8I20B80JZ4NVrNQ9MNEeOj2OZmrzDRSsPruxoa0V8xcVZ1DUZNOFxfw1Efwy8eNjCm/dIZdBrFirNh6wF7TK6H10zjKu5tO96tComs2oR7AZpQzyQVBZkP/+uDUTKCsLHuEOzcmOS6wvCbAwJdP23BV+SOF11DlisULIVNKVHDUjHAsxs+tuaW+3EQl3wUQRo6+cmh00Q0+z31NLzv4+w1jjF5iiea/cMcJ1DmEdzI5goLxBBw8MedZyJOLiPZdYcfYxwj5nmZ2VmKw6u/BAd8A9UkBsP53GvFhVzzuUtxAUqtqWh1b95QoqAQ3FfuS+E+tEfMI98ZzNIrVzKdqm6cm5Sxgu8pPZ7dZWE947w+KLSiPECN4FcpCzHS270p2y43K0QmZ2t/ZG+IyYKrnNgjTFQNB8ChyvuGY+nsbQaw8z/U3Mx0CnckEV9GpgRvqyeOjDtaBMMFDzzgJ4XK8NcE7pOP65moqh9p6LhA1L1oEJ1ImsIEwRE8QjIFJfKnUOnJEoYVXOxhJVZJ6JLLwLHvC+/BzJTezmjuFNwvhywDGQPdhBNJFjpEeErXcxRRgkHIQ5OYq5wozAj1Rm 4cU4tjtv iN+Ar0BIOq2vbs7hw+yPw2BnlEYrrSin9PkRt6wUPTwt39cdQzePTMBpBibhs+R37t3M2jtSx40u3ef1ZyCPxmSjhJiXn2Fd6ZaOw8+pDOQw3WCJfrBx7LMb7scGzPwFfEzc2QbU75cc4+kaElfMdnUyY7a3PORLBV1gXTDVcHzoLID/00iv5tidDnWrKljTq7sPFtYPsqDm5+rwBps+yxOZzxGU1+ZW1b5f1Rv0ln+xJcUyd5n9ZFJEoWNNz1auh4JhHPnVTisTqFGrdiAHRysir3E9ifUbp/MtMDvVh0DdoJKYnnDjhZPMIJvyd52C9DzlelT+/5+we5+vvY9CH68FWC+KElfRMfJkC01VCFyDs6VGYkZELW5JZO7x5ceiltoLU3sJ95TjrExh/JwK65iK0c/MV1uws+QaJDOINQru6W7qEHCf1qZL5dA42MQoGIYjT/44ekJ9MRfpTEZSsmXd/9mfRjlYJO2qzxaRaz+defElbntzxR4tltAtbs68q5bd5qpKNmblH8FoW6qfO3xAVYxZri3rR8u+7ecP1Z0/qHRzyElO18i+/fK+j8JSLlrCknBe30JyKURlcouz94WP3+/1OGEGtlbmdOq924/+Va00RfZVZiGEgVPKWmWZBstVpv7nUJrN5FQ4VZWqSZMHfRRzh/HQlqN9zJDaPQUiyMlp5UYZ5PZkMfCCyi6+czRbTklHkQIaRP1HfEH7iHMIKBtujtO6AUFP1rSZNioBzgFDSmMbhwDE+uQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.013724, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 08:36:45PM -0500, Johannes Weiner wrote: > The branching is awkward and duplicates code. The comment about > writeback is also misleading: yes, the entry might have been written > back. Or it might have never been stored in zswap to begin with due to > a rejection - zswap_invalidate() is called on all exiting swap entries. > > Signed-off-by: Johannes Weiner Acked-by: Yosry Ahmed