From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED9D4C46CD2 for ; Tue, 30 Jan 2024 08:10:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68FAB6B0095; Tue, 30 Jan 2024 03:10:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63F076B0096; Tue, 30 Jan 2024 03:10:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52F3E6B0098; Tue, 30 Jan 2024 03:10:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4324E6B0095 for ; Tue, 30 Jan 2024 03:10:13 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D8D13C0B3A for ; Tue, 30 Jan 2024 08:10:12 +0000 (UTC) X-FDA: 81735254664.30.B0F43D2 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf27.hostedemail.com (Postfix) with ESMTP id 2718240018 for ; Tue, 30 Jan 2024 08:10:10 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gF0LIkGO; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of 34q64ZQoKCFcNDHGNz6B325DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--yosryahmed.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=34q64ZQoKCFcNDHGNz6B325DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--yosryahmed.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706602211; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wC5dkC6Jq7B6DAe1rPPi3X80tYoDo3ynjpR7BnHrH24=; b=f+QvekP4XJDLuT1CKsT/rBAqP0v6qAAuE0C9lEsU9jTwJc2yHWIduiJ7crDmgYtrPYDP/i WL86n0nv77uIwq6Xg1I0OVPsFcOycCZYWSF6ohLMDX6cYkPgxfeNhN2kdlIjG1uE/fxLRW 6IypgB6x53gnKgqXBdwevET7gooznYw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gF0LIkGO; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of 34q64ZQoKCFcNDHGNz6B325DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--yosryahmed.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=34q64ZQoKCFcNDHGNz6B325DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--yosryahmed.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706602211; a=rsa-sha256; cv=none; b=VCWcWt46du6p6GT+Je0QT+htDj8etrKonqIielbGeR6nfVfdJjHwvhU1qNRlrvLTt9PDLk Yu6ESIopnhK4d5WJ2mdy8eozUJvHvx9u0LYGDG9ls1hEVeav43F5A48KU+B4wVN7NYZkOJ ubG90kvQVaSo+bArXeZAIt0dAvzSFCU= Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-5eba564eb3fso75729177b3.1 for ; Tue, 30 Jan 2024 00:10:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706602210; x=1707207010; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=wC5dkC6Jq7B6DAe1rPPi3X80tYoDo3ynjpR7BnHrH24=; b=gF0LIkGOBvux78DvccgHDbmLxZdWBpyAjZESYH6ghYXc56Z307jXv6vJK+4or3LSsG Vskub70KM2DrI3K+axM8JnoeRhYKWS3Fpm47S9xZjI0li5LckA0/B2TRtMQbZPm01RdX QcRZEOhkPtIDLfxYlf0M5tcP2n6v3KieC1H8I5HNrpI4fJsrZk9xcc0M2YER8aYnoP9l oJsRC8NLH+XHIkhx4jcdvp3g7+aP+bhzkcdgzDISCh5InS4WCGUVMwcy7OCBZPxfBYyf QH88AuZx6SJqllBi/cFz1VwaIVPE3DEZWobD0uoFiIfNazhN9g1QFyFd2RHo0jxYt9Cv lyTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706602210; x=1707207010; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wC5dkC6Jq7B6DAe1rPPi3X80tYoDo3ynjpR7BnHrH24=; b=oIR3AIiiHGSKpYhC3T+bUAgolqQoWgHndudjGNddfErQxYJ4smy0Cl6LAUHfDUNS/R Y4eknCRa4RP6lrqJGcOo6q5ku+netRPWpqJ9UTweREBg9qtt36G1NOgdWDht1XLHgYE2 LXBZjWUrrpU6pMh95MHuOGSn50aPRli1QLT5tqNUNr4h4e6YvrKjRVXK2uR7dlo3NE96 MGGTXj1egTy/UAy1i44vksQlSEJ+rABuxxjbuT948un59j+ROCRxmNgaJmFpA1g3wSPV 65WmafrbYtTAewPCGZW1sdli9i024OR/QTF9N2pK+2JboBVBhavN/LSDinzgrZekvnig Aong== X-Gm-Message-State: AOJu0YzKYN6wUug5oc/R7mdRRnbDUIpnykpe29D8YFFE0MBp/uEwHaOn ua2unujh2SW20/dYPrpk/oF+F9ApCRmQbcAyHeZpMqrKdCa/RGiNU+s/bH1qYUjpLsznM2KWhwY YBswmnbMWpaBTXwdNZg== X-Google-Smtp-Source: AGHT+IEGENChTUCRnKZVFWxFOS4pHUFu6+Rg66aYoZaZvwtob0PAsFmEE7KfWXugj4uae0G0k4NzpIyId6wV2yjo X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a81:4c03:0:b0:5fb:7e5b:b87f with SMTP id z3-20020a814c03000000b005fb7e5bb87fmr2437055ywa.1.1706602210387; Tue, 30 Jan 2024 00:10:10 -0800 (PST) Date: Tue, 30 Jan 2024 08:10:08 +0000 In-Reply-To: <20240130014208.565554-5-hannes@cmpxchg.org> Mime-Version: 1.0 References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-5-hannes@cmpxchg.org> Message-ID: Subject: Re: [PATCH 04/20] mm: zswap: warn when referencing a dead entry From: Yosry Ahmed To: Johannes Weiner Cc: Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 2718240018 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 763webxhdrmgmurdnq6pwkk5xhpwhe6q X-HE-Tag: 1706602210-412141 X-HE-Meta: U2FsdGVkX19nN8H+3KC7fFLp/T4p9+ROkiYRveH8oRclaqtL6e/Y0TkUQH1Iow3k6DWMj6Af0kjCSWHbK/ZKUg0XrIKxKn0lrzmlI20WY2j9Pa5rbvIEVlsMRkvwKRC+8AjhKhCYpReWUoVxsOFVLqbn/I6Ni9HgN3j8SbkyL2maPxcc+gBIVO+IAT0AK+QhsIY7UclP0FT45ojFitO0gEJl7E7uATziqQBod3K2080M1B4u6HPQK6W0Z/1iCi06PiHY6nwC2jYfRCBT09YX/oVF+37lf1Sv2YAYDLJkd8effFMrHP76k8K8KVNFAWyzpoDvCbCsCteoPbHHaMdpQ62lRTU3gtwznDrZcSbPJccG5sWYPXGvWWxhwom6VIyi13BVf7d7luQwBwShGBlflcmJeQ9y7UWfGLia9uH1bAF6dGsNxbdSVVN4rlg7UlFh4DwxhQpzUhNg2mNgnuiY1iGiRtyVb5mdeFTQyysm7hz4T61Z6WvmWPO2DAp3gsuZJAhasR+LnN1YpDChnj8JgYq4kIcE4GqiH0HR2almQcRqFV33dZWEUmabryjCCPRNcg5HV5atoQVvrxYe1zOSzNtErkuu14weOvxw9GHWWF/pIO27AmI4bNWv9KZM0VTFNSmlPP0YG2o0YosTEqwGNKE0N7fBAlTfK6kcMGsVouwcq9DxVS4/qrLluygQo1Kqj4SG5cCsUanYM+96tj7/9XVTnj4KjwW1LrA8esOj/Ii8t+ib61iftTskfZ2hYFktrwGn/w7WcDwukYOzjQ/a6ls0yn4QmIZ8krtpLvRTfeB7z8Do9nOO3U++Yp3iTToId/El0MxlEFRTJKM53lbSqALBsP+twLfL52fDioqv5+NKpu8zUa7PMehP7xY8+2s1TogPYAUoDc2p8jB8sgFIZsgIsWAn0RTsT4HxbV56ZKRXA1VHJZAbdDKYtH6j85gVES2MwkYVEWcZ3NW38Am XG+2ulCm F46+2ux9zXQwh7Lm9DHl+hKs7yVxuo+Max1yfF5oyA29IbyytgiNRIP5rO1FkrxuNaS97UorP7mnM2mlDpCMCvvM0zhn17B14hjv7RXkb3fH/SoMtkN3TKOqYzjYtcJHv739G/iH7HAlUcz9t1JnM2nzkzXwID1GqDlnc6UKY8TI1WokHhRadff0RSzXFw7Dhaga5KuoEzsJ4SM1lwtgDm2LS581Nri/8eXIPMSla//PiA4Dpopc7mBsB6j09FIafUXYBC4t7XwVx8bHIfcJuC7M07Emzt3o+Jx/4RasYcka8LPJ/i3+jIbGp8q1dINEJXSnAOKrqHYlGMzW5gFu1pYY+pyPmkJgGF5tyvA+lEMTVDdBgT70mHaopQL/kHRynXEA+idGCzfod/GTePIM9bM7sHY7zpC8hVPqrxnvnhXZw2zXx74uQKEjtHiFHsJquwbmvVuwqaTKYGEYiABpQKa1Mf8MsxtfxHBuHHfFBARYEPbUo3LmB8oX1zsw1akTAuoRGPa3CFPshZhtzxOnEBfH553sGLI2/BWh30XY92UUwqgbevZttroenDXryr7NbXd/ir6E7iuyIRx5iEdFRP0xPASy/3no10EqM5eEpMcXp/vL84PxgXd1V7lHhLUEnbdBALc141g4P5Nc1IGSgOocJcfoSfc1xJDkVoFCtBSljuX4P2p/3WxBL8+UvNku/TvDlOC9i6V5vuZQpbG6uBIo9OQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.078967, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 08:36:40PM -0500, Johannes Weiner wrote: > Put a standard sanity check on zswap_entry_get() for UAF scenario. > > Signed-off-by: Johannes Weiner Acked-by: Yosry Ahmed