From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F00A9C46CD2 for ; Tue, 30 Jan 2024 09:11:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CC266B00AC; Tue, 30 Jan 2024 04:11:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 753AA6B00AD; Tue, 30 Jan 2024 04:11:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61B476B00AE; Tue, 30 Jan 2024 04:11:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4DD336B00AC for ; Tue, 30 Jan 2024 04:11:53 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1A6BF80460 for ; Tue, 30 Jan 2024 09:11:53 +0000 (UTC) X-FDA: 81735410106.09.1A7E112 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf13.hostedemail.com (Postfix) with ESMTP id 10DBF20008 for ; Tue, 30 Jan 2024 09:11:50 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JoTkEI92; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706605911; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JUrIJzTOZqDa/ika+GUnOukRuQO6tORte8yW2n5gJb0=; b=xm5zNSrvq5HfqneFONWVjM6B+6YGWYMNyY8ODUjT3bncivE/+bENsA/e/Jr0ize8RRVTI+ yQHXUTJp5vB43cxhh8Mt6OWw+sQLUdGwbr6/KMkO642f39gzyiQKXSqC5X8byx/MfgYpRR dxlbcyTF+BfIHImuwZs566YXCCkoUMI= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JoTkEI92; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706605911; a=rsa-sha256; cv=none; b=8pCWtFIz6kzYQsbzWSzW/P4EgtqTnTz78UBzhRYxgp4i82fxx4ENUgufRZcQkqrzSTJsMu CVd+Gw//r6I9+dmY+Ke7zTd0MZy/ZCga1qptoFePQfkv1FTxC0NcZhsDYgcq3ijgzBYECe Xhn4f0dfjBUGzXPb552SdOGocP0f3Oc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8318ACE1804; Tue, 30 Jan 2024 09:11:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30D23C433C7; Tue, 30 Jan 2024 09:11:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706605906; bh=iOP2KXEOOGWBsVf+9872GoWmuWoOPq2IE9ros2SOLHE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JoTkEI92AC+PUmil+8rH12bstaBvvlUN4UWkxg/3o8tOErY6zDfZDWL2COwZ6DnAb o9rt87V+o+nvcsG2z2kqygnJzk96n6dGYIpeQorbyZNi8b4+fLUrfw7P4Hyjb1lzpt eaPRfTUWFsJ7eyj9W3Pkrxm6MeqXpDuMoOZ8D29HYGBFZqnKqe/69k4/J8l+PNq90C SivtCgSMpi5THdeJBNBrQM6m8FD1+Mlm8poYdIDCmwEsInUJccUQcFkSb5yBBA3uBu epDT3+FI1nMpSVBYFH5eB5ME17K2HLFsPKycJkcbI8JtLLsB5FN2dxtCXwGaXJxvdr BRyblMe11WcKg== Date: Tue, 30 Jan 2024 11:11:23 +0200 From: Mike Rapoport To: Yajun Deng Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mmap: use SZ_{8M, 128M} helper macro Message-ID: References: <20240126085905.2835513-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240126085905.2835513-1-yajun.deng@linux.dev> X-Rspamd-Queue-Id: 10DBF20008 X-Rspam-User: X-Stat-Signature: 85iyafn9pfryrsbmz8p4beaenobx69iq X-Rspamd-Server: rspam01 X-HE-Tag: 1706605910-401964 X-HE-Meta: U2FsdGVkX19Yl8vZpfiomugciEKb2lP33UAgyVO1qWfI6/oUhHmVqQXTjiJ7QkUh5RHRpmVq0e3Uy+51fCsjr5975bj8pmG9X31W43oEBJ80QWLfW0HU9WJe0GlwsQd66ovPNuEsCs/a0w5WMtodXKAVOnj14i7xYsZFMBVBtche97VAscY+lr2GwozGYuf9ZP7uOasAwaz68rfsnZo/vQA0cMfKrJKuPPN2UWAsoRV9CFQoYd+GtKhBirWiyPFoWSq03nWw7vb76WA1dIPet+spt/QZ3l0mKjoHZAATqjnO0PLeUgNbEG6rTAfF0mXaqAcp7NcYO/NL0VDb//nf1YdN8Ymn2Odl4nnLKgOKbMKWDmWHSs2KBM7ZvuzFSkeNFVUEUogQWPhvzv7N8an7P5f/tNsJ+DQsdfVYmoyRTtsf/57SzFscvDLsj4o9YE+POrPjiK5KEs1vJPDVYX5eenEup4I8x4IPBlP6id8le/xGth5Gtv3XC1EN9JK9ONQvN1mi1MY+P7VvT0EZ9Z8+7NF+uh4r/qY7UE+659yp42wEJYVFXlB0ukUDwvfh9v7DQS7XoSSVwGWaEds4jGN6VhgIYEBvcgR595uBRWNDblqcK/8AbG+5OLIZqEEkgQe+/O54XgF4gPNNehRtHhJd0+HpFgrND5p1VWSd4fmy/4ZuM6KzCeee6P298YD89aY1GmmOIk28J2Bbc24eOpdWjpgtcKyEfLjR5SzgGCDh/nn7SJhIHUddylUHU0FWsUgsyw7jLKdlOOxrQ5IqjVCfZ87RVfueGdHVBp7q/eUaWuTmap5z6JDWhnVLeyxhvU/6xWsISOq1WWuT/BRz6AcEcGp3rrwn34ELhClrSVF2M5EVvfLAMt5cAFZ3iq4XZlq9az+zOwhKQuenrMIdlY8PmRdIH9aSyQkZ3CpWrT7ook5j0NDMKPZrap3hlCgK8Xktc5Mj2qaG3yZGySKG5mg g3wxWk3L O+ikYRHZAmHhICB9aCyTwU5W3jEt/V6wezwZQAxUHwfp/dVHfHa12donc/CUOQy7ZoQFAa9I7POyvZCEx+tYEvUN7iIH2QCvhPElabySsTEAG9cizz0LguibgyOvN9xscWVuLQaAX5wJW/Jyw8hx1UG/z5ZRC5jO956lXfzLR3fQ2sx4p7pTJ3oqBlQ9E+EPEqvtfZuN4LOxQEDwefnohBuaC/pAKCSV6Met/g3mew+qOaYw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 04:59:05PM +0800, Yajun Deng wrote: > Use SZ_{8M, 128M} macro intead of the number in init_user_reserve and > reserve_mem_notifier. > > Signed-off-by: Yajun Deng > --- > mm/mmap.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 476de5daf598..f90924b2a6d2 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -3845,7 +3845,7 @@ static int init_user_reserve(void) > > free_kbytes = K(global_zone_page_state(NR_FREE_PAGES)); > > - sysctl_user_reserve_kbytes = min(free_kbytes / 32, 1UL << 17); > + sysctl_user_reserve_kbytes = min(free_kbytes / 32, SZ_128M); (1UL << 17) != SZ_128M > return 0; > } > subsys_initcall(init_user_reserve); > @@ -3866,7 +3866,7 @@ static int init_admin_reserve(void) > > free_kbytes = K(global_zone_page_state(NR_FREE_PAGES)); > > - sysctl_admin_reserve_kbytes = min(free_kbytes / 32, 1UL << 13); > + sysctl_admin_reserve_kbytes = min(free_kbytes / 32, SZ_8M); > return 0; > } > subsys_initcall(init_admin_reserve); > @@ -3898,12 +3898,12 @@ static int reserve_mem_notifier(struct notifier_block *nb, > case MEM_ONLINE: > /* Default max is 128MB. Leave alone if modified by operator. */ > tmp = sysctl_user_reserve_kbytes; > - if (0 < tmp && tmp < (1UL << 17)) > + if (tmp > 0 && tmp < SZ_128M) > init_user_reserve(); > > /* Default max is 8MB. Leave alone if modified by operator. */ > tmp = sysctl_admin_reserve_kbytes; > - if (0 < tmp && tmp < (1UL << 13)) > + if (tmp > 0 && tmp < SZ_8M) (1UL << 13) != SZ_8M > init_admin_reserve(); > > break; > -- > 2.25.1 > > -- Sincerely yours, Mike.