From: Mike Rapoport <rppt@kernel.org>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/mmap: use SZ_{8M, 128M} helper macro
Date: Tue, 30 Jan 2024 11:11:23 +0200 [thread overview]
Message-ID: <Zbi9OyG9kcldGyJ1@kernel.org> (raw)
In-Reply-To: <20240126085905.2835513-1-yajun.deng@linux.dev>
On Fri, Jan 26, 2024 at 04:59:05PM +0800, Yajun Deng wrote:
> Use SZ_{8M, 128M} macro intead of the number in init_user_reserve and
> reserve_mem_notifier.
>
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> ---
> mm/mmap.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 476de5daf598..f90924b2a6d2 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -3845,7 +3845,7 @@ static int init_user_reserve(void)
>
> free_kbytes = K(global_zone_page_state(NR_FREE_PAGES));
>
> - sysctl_user_reserve_kbytes = min(free_kbytes / 32, 1UL << 17);
> + sysctl_user_reserve_kbytes = min(free_kbytes / 32, SZ_128M);
(1UL << 17) != SZ_128M
> return 0;
> }
> subsys_initcall(init_user_reserve);
> @@ -3866,7 +3866,7 @@ static int init_admin_reserve(void)
>
> free_kbytes = K(global_zone_page_state(NR_FREE_PAGES));
>
> - sysctl_admin_reserve_kbytes = min(free_kbytes / 32, 1UL << 13);
> + sysctl_admin_reserve_kbytes = min(free_kbytes / 32, SZ_8M);
> return 0;
> }
> subsys_initcall(init_admin_reserve);
> @@ -3898,12 +3898,12 @@ static int reserve_mem_notifier(struct notifier_block *nb,
> case MEM_ONLINE:
> /* Default max is 128MB. Leave alone if modified by operator. */
> tmp = sysctl_user_reserve_kbytes;
> - if (0 < tmp && tmp < (1UL << 17))
> + if (tmp > 0 && tmp < SZ_128M)
> init_user_reserve();
>
> /* Default max is 8MB. Leave alone if modified by operator. */
> tmp = sysctl_admin_reserve_kbytes;
> - if (0 < tmp && tmp < (1UL << 13))
> + if (tmp > 0 && tmp < SZ_8M)
(1UL << 13) != SZ_8M
> init_admin_reserve();
>
> break;
> --
> 2.25.1
>
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2024-01-30 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 8:59 Yajun Deng
2024-01-30 9:11 ` Mike Rapoport [this message]
2024-01-30 9:25 ` Yajun Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zbi9OyG9kcldGyJ1@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox