From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41333C47DA9 for ; Tue, 30 Jan 2024 00:58:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D9B96B0092; Mon, 29 Jan 2024 19:58:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 989FA6B0093; Mon, 29 Jan 2024 19:58:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 878C46B0095; Mon, 29 Jan 2024 19:58:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 777416B0092 for ; Mon, 29 Jan 2024 19:58:09 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EE20C4040D for ; Tue, 30 Jan 2024 00:58:08 +0000 (UTC) X-FDA: 81734165856.25.974FCF2 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf05.hostedemail.com (Postfix) with ESMTP id 4126F100021 for ; Tue, 30 Jan 2024 00:58:07 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="r1n/GIGs"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of 3nkm4ZQoKCEc7x107jqvnmpxxpun.lxvurw36-vvt4jlt.x0p@flex--yosryahmed.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3nkm4ZQoKCEc7x107jqvnmpxxpun.lxvurw36-vvt4jlt.x0p@flex--yosryahmed.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706576287; a=rsa-sha256; cv=none; b=cP+6riQqeLzqP8CNnZGS1NhIUApvqNAwhcNj/KZA85hf7R4u+1EO4jBdaXGyTFBW7pwcnx aOA+SkT+c26S3iquJcRGOAtlcYPVvgRgrvoTGtUBj6MZYZ4BdG56wkoWOi64EdWZQyZq1B lgjXM6ejDDqoICbG0ohqvOsTrr9Fe+8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="r1n/GIGs"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of 3nkm4ZQoKCEc7x107jqvnmpxxpun.lxvurw36-vvt4jlt.x0p@flex--yosryahmed.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3nkm4ZQoKCEc7x107jqvnmpxxpun.lxvurw36-vvt4jlt.x0p@flex--yosryahmed.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706576287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vehqthCnPjetgrYtj1oh6HOMUQNvBhhq4E/y9/quWI8=; b=m5M+TKFMc1Ptrt5X0346aLTDKqfDoRE9+Xfie+E27xkaqlvtaFWfolMi4MSqvW1SZfPx+r mh5yL0N07i0Umao0oemfdG1EkkeXgN43nAOHAG/rZsFyi+ojKeN2iBLvTccoap89gWI4I3 eJqNi59mYMcXTRtJAPRdGdH6NQPGEls= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-5ff817c96a5so61480717b3.3 for ; Mon, 29 Jan 2024 16:58:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706576286; x=1707181086; darn=kvack.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=vehqthCnPjetgrYtj1oh6HOMUQNvBhhq4E/y9/quWI8=; b=r1n/GIGsWAI5Nyj5zWmqAbSFzXZ63I4T3X+ndmyFRWgfLQzZpcS6QI4sM2bS6n0Z8T siIPZxaA9Xzr3006NDotRhept1aVyAj2FtYsxAyM2DcmyXBehcLPrtanidRd0JWN7f92 vfj9jwlJZ1kIs3VFCLbFh7VIe/bARzgV72lbnpkDImRxfuPKFZOlYCn3CBj55dIfmJbp /p6X3vs7gMsX/d1NEcg70pyONRIu2KFUYK/b67UN4i9dYgA2MdtYsDi0P0eBPVZ7XLD2 8eqjk0a2t3sbrx8bYfDnRPp4ozlex2XllGgWEqpiQo3nhivx5on56zXndfHOKtx/VUoV DBEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706576286; x=1707181086; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vehqthCnPjetgrYtj1oh6HOMUQNvBhhq4E/y9/quWI8=; b=hqzJLYK6ONiW1JKgzJns4yRIOoEg9ZzXU6F1KJlXCwQHtHWp6/Dn6vhFEwr3TPqT4R zCAsj4EKazsxCR9ZQHPCx+5bW9HiF2aAr9TkNeaTU9KZRh3PZyxRRktKpKtku20v1VuK iRPvWzBlc/G4/fN905f7RK7JnVNKZQuHkVfW8/Y+8LvmB61kYEgGT9PpHhreJfD5RDJs HI+c5gNFzU65l6ON8LQrA460QZM4z0ChjSVNacSAnReqRDZbrlOycqw+/pnoRUnKKNnQ RZI37O4Y2izzDQj0fjStLT0sZcgpjPtNyJzSrjL67pwoEzdM22gACDdCTYyyoHONoDxe oPXg== X-Gm-Message-State: AOJu0Ywb+UjViHwtyhftSbaRfvyzB3rowcs+UJVB/fj4Cjha95lOf7/Z efHsAx9IX8v5zhmiVu1CStdxCp5IZNeN8Daa7eXziNbylUNLTGzi8PSnYRszrGaq7To1dnAyTpu xJ6EAgzzI3VdHe8Q/Bg== X-Google-Smtp-Source: AGHT+IGdAli7RtKs+PFrYkjZWruzcPcsuBDP1FgmOuBAndXpnE1k73fgPJtOJy0F2aOVgpwyHlBYZlAUCxWUrWET X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:690c:38a:b0:5de:9c9f:3ee4 with SMTP id bh10-20020a05690c038a00b005de9c9f3ee4mr2266697ywb.6.1706576286454; Mon, 29 Jan 2024 16:58:06 -0800 (PST) Date: Tue, 30 Jan 2024 00:58:04 +0000 In-Reply-To: Mime-Version: 1.0 References: <20240126-zswap-writeback-race-v2-0-b10479847099@bytedance.com> <20240126-zswap-writeback-race-v2-1-b10479847099@bytedance.com> Message-ID: Subject: Re: [PATCH v2 1/3] mm/zswap: don't return LRU_SKIP if we have dropped lru lock From: Yosry Ahmed To: Nhat Pham Cc: Chengming Zhou , Johannes Weiner , Andrew Morton , Chris Li , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4126F100021 X-Stat-Signature: pp583e4sp1xgqig7j5u4ikcpu1eudp8f X-HE-Tag: 1706576287-491287 X-HE-Meta: U2FsdGVkX19W6taTNFnUpQkctJ1XRqEdIAxioMkHZl4K3DCkUaW2G3c2FGouLAMwcVmrRnDS2XyxPoPvZQzWZGwc8eIRe/IO9SMKV7lntcHKP6RymOiS6oIyhyrnWlJzqy8gA6zL9YRYI3B1hdyJyUlmLwmhJvfMYkHiH/ZkfoCLWfh4iR3ek9AfWEcoDcKVZtWdLni8U+4147maF7EWChEEL8XGhtnvh/p7eK4+KuawwAmc3YbRI3xJFshc+YxV0wEudtnTcqpN0itAT2JXC1i/cSHGP4tk13uwmS0WXSQ4lZ2wck6raZvsU6YqVcdPjrzJv6BbF6sVFNJ8Sxf6gb/bCyVXGJpmYhUi0tI5yDtxmHRcnu3nEYJavnHdmwkHRNq69/MyGfTCkOHXxIcVttfKnlAhfJKV8//zZBQqnmWZjiP+2U6EurLLEKcgn9FK5/p+D7xyLe2fpPP0jv/2iHkZDBZHOWfMpbCvWbmAM3MfoNcc4g8FmYOHQS5PIXpFsGszB0L+cxI8tG5ey8Tp8ihAU57/x3k1UN2fn4lEYEWLvuNcqiiBh2QRYy0jAQuujYnnrw3MS1uXNbafFvbZlkJ/MVh+XnI5xX4yg6PboboRYJHQgDTdzxuEsgpUcljYesGBl0FBGvbOyJi5TLmXx41MPhx0E8XHwfN6FWXffQLIcBi/EDiLVL8evrRssSk0anSBqJ+v2MsWkWqp8ngUkNdqNXe3GcTbpAgpxTA/59HtNLXpMV8yuVIGDdMi0p/4Q66Dy886yvToBcu++wWX08Cc6QsKCrWChaaIRtrdE+jwORhaJlPkzWW+8UJ1kNtk9rM/BUriZB92X3Zys6PFTCuEHJ2sM6na6JjmoUihRnWunc5WocKy03+XMkv9Rj4Sf6zQbQQaVNqhkg5L4i1YNnoTwG6mXNSbJAwVyUqRxxnKXTIZkWN/Ue1t+O+yn42gGMGWxT2VkBv2TGAdUL3 NRa920+W nNiJhyPKPwlSOVakOGESKCtnozBigYVpiMvksaxv3iaNGFNsDbi8iNin9UYNEvKirQ6XINNYVySf2BwrUJB/aK2zxpDe7iiB4Q/ojZz8yYHktgKJ8dJAJbtZQMNpAQ2XecInHgXa6jC+H64Bt9udiD8OYuogn6T0GEP3+nblggp+qwMgwme1Sz0NwZvKN3DZMpHq0K+biutJBiHExyJSztRj9ZMyVb1iFVXFa0ynBR5uFbfrfawxw5ChsC9bQ4hFoBZm+05VClunURGv+TAbmoUyrZepAduMUhoiAKvFpFORxqiPWRYoSIgJuXRaTA3VDytFIrZdwpZ3ZnQo10EZ7EqdXegG0u/CYNvqGG29CR4LzAl7Aq5w9LaJRPBiIT/uX9RBOrgKTriQgKnq9/iejX3/M4KszvHPArL1QQtWAoBeL6N9RUCocpsw4viAaKd/5WtfVlM3zeAm/fGikEd09j1LYiCU6szkYQDa4XRrxGZthmutppzWD9WjcOsANgr+oWoPSOY1yUMpXS9FiifsHpAb08aHi94AmKrjRd0dq92EdkiWL1EhTFlJDA1G1I+YGFM3jEnU5irblRasKGEwzrlAxh0U86k4ZlZ8P3y33FEfj25G4g8ErFQsJz1hIvZih4ujeVYcPaJHMPf+85Sda42y0m/MIlyb+fA/GGbAyoltTVbI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.067261, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 04:12:54PM -0800, Nhat Pham wrote: > On Mon, Jan 29, 2024 at 4:09=E2=80=AFPM Yosry Ahmed wrote: > > > > On Sun, Jan 28, 2024 at 01:28:49PM +0000, Chengming Zhou wrote: > > > LRU_SKIP can only be returned if we don't ever dropped lru lock, or > > > we need to return LRU_RETRY to restart from the head of lru list. > > > > > > Otherwise, the iteration might continue from a cursor position that > > > was freed while the locks were dropped. > > > > Does this warrant a stable backport? >=20 > IUC, the zswap shrinker was merged in 6.8, and we're still in the RC's > for 6.8, right? If this patch goes into 6.8 then no need? > Otherwise, yeah it should go to 6.8 stable IMHO. For some reason I thought the shrinker went into v6.7, my bad. Then I guess it should only go into v6.8.