From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A87C1C47422 for ; Mon, 29 Jan 2024 11:59:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 018376B00B8; Mon, 29 Jan 2024 06:59:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F0A4D6B00B9; Mon, 29 Jan 2024 06:59:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD23E6B00BA; Mon, 29 Jan 2024 06:59:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CB13A6B00B8 for ; Mon, 29 Jan 2024 06:59:33 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8E183A0714 for ; Mon, 29 Jan 2024 11:59:33 +0000 (UTC) X-FDA: 81732203826.27.5EF9E9D Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf16.hostedemail.com (Postfix) with ESMTP id C0CA1180015 for ; Mon, 29 Jan 2024 11:59:30 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf16.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706529570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OXbl0kT0jwzw5ne4ouhaQHXtVUQDb7lB3DjYgt2TdJ4=; b=xOunXAtqKssLR4XoDh5MoHUO2nw42UJ0hW4XWx5C/i7B37PLjHxAVmUZ1jnT7tP9yCUfYg vtEhpEEZG7dxFGbgS3byrrPujW6RPf73va4sA8MaHIV6GetMUy7a1NtsC8JX057tGi4i99 94270I6j6KpFyIjBFvVW8rgpr72qeYQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf16.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706529570; a=rsa-sha256; cv=none; b=Zc3fuy3kQXTyByKlk2RW2wB7x+vtFMftQBVuiJEHdpWJjvMKz5jMzlg9vp9y9Z/l2RUKSi BZ5tbOZSz5Z2HbXhSPBW3+3G66X52GjL4tsCOx6UC5Thpyg9SSCeKRT+8WFY4QMSXBoqtQ 0gueyy4QOtIdBDuFE2ror1oCIbJGvqo= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AF0DB1FB; Mon, 29 Jan 2024 04:00:13 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7F6793F5A1; Mon, 29 Jan 2024 03:59:24 -0800 (PST) Date: Mon, 29 Jan 2024 11:59:21 +0000 From: Alexandru Elisei To: Peter Collingbourne Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v3 11/35] mm: Allow an arch to hook into folio allocation when VMA is known Message-ID: References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-12-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Stat-Signature: m9sobak6xjucc15cnzynwuy8556g73pe X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C0CA1180015 X-HE-Tag: 1706529570-462584 X-HE-Meta: U2FsdGVkX19/5mmmeNpG90DNeeUfpwTG6fweRxScwE6u05DXZPqvLSDWIIt6RLAo8NIdxTrROYKbNlwm3C2QKbpWxw3x4QsFpd5/+z5nug9hNYI5kAZAzChvrtRFT5jrR3X0tHl6ZK4JPrJ6lNLmkqAy4pc0mmAiGcjcsv4DS+qOWhlc3djmUMbeTK4AIXy26wg1FGZVM2EHnnM2kr4QuvO8SQJeg5UZvj0+JBRWP1CW+oxoSnNYjEyc8n6HbMmG/5h8oVD6w6GEUqXkqVRyMtpoRtIJTI1+HK0jtbMOOUzqONNmdSuzO4GrmNqyVD/GSAge9qVaTpzJ1dulgXAJtwN1wus8qYgfR8JuXZ+Ffx2sEJdmFEZRoQqMrzuBCmhhZtMDGElrOXt7oi4SN/nXXHe0tyPhwe7FISJrB3itfNlSvFM4t3ccOo58rLbhXhXWnZP7aKhIcBr94J821xvkX+voLEimT7JG98K+SrQqZtHXOZ5/7Cou5H4tE45yfLiDwJyrYWyrhgXYzxs5bhGSom3nMhibBTXTBRX8nMVr5SY+AshjH/38k7wr5rP1LEpdpeCx7XbFQFs0ixRgey6+jSOstergqoSyAr7ItxJJlMlnWSlSJsvHqVU7aaLoiycU1/J+4KTwnxysaraynznOnd5K1rkEtvwuZsuUzaMtd01r42H65YRZXPQRUYsIL66s67SKPDA6IDpC7DUXeTTb44wUXHQna92y4tY2GEzmqKqHpTb1DgQeJtql6jA3B1Ek7b4sLF7YGskyNYbPFIEy6xfeQO7l8x7Y8DkRgxQTX7yvFyMEmBMtvDql9SxeIWv/TbbaN/GZfLNm8nC3VRzd8uBkCHheQ43DPAC4fVQg3ZApuANLsrK1h4osNywc9FfhyWCeVPXWLjqKy9MtFfdrFm03RsCY++Kr+e0CRDr8pv8bkSGk2r3ngXHZBLrt6GR2nLP6glXFyVLlVAIEBW8 c0EgLzrc ALAZr7WJ3H115Rabukp57UFUIML1IWj7+2zOK10jus5yj9KX/tG9U3zQlTyaH+yExkgCWb0kET88XyX42+6s4FDak2/RAUyB3tovEeN4TitCTPtP/XCzECM3SBxT9k3pECeucRwKX6MSTkZO+EVj8kCFGlF+wxLMfp36mkRgX1MdYNwD9jVHsdb3OuQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Peter, On Fri, Jan 26, 2024 at 12:00:36PM -0800, Peter Collingbourne wrote: > On Thu, Jan 25, 2024 at 8:43 AM Alexandru Elisei > wrote: > > > > arm64 uses VM_HIGH_ARCH_0 and VM_HIGH_ARCH_1 for enabling MTE for a VMA. > > When VM_HIGH_ARCH_0, which arm64 renames to VM_MTE, is set for a VMA, and > > the gfp flag __GFP_ZERO is present, the __GFP_ZEROTAGS gfp flag also gets > > set in vma_alloc_zeroed_movable_folio(). > > > > Expand this to be more generic by adding an arch hook that modifes the gfp > > flags for an allocation when the VMA is known. > > > > Note that __GFP_ZEROTAGS is ignored by the page allocator unless __GFP_ZERO > > is also set; from that point of view, the current behaviour is unchanged, > > even though the arm64 flag is set in more places. When arm64 will have > > support to reuse the tag storage for data allocation, the uses of the > > __GFP_ZEROTAGS flag will be expanded to instruct the page allocator to try > > to reserve the corresponding tag storage for the pages being allocated. > > > > The flags returned by arch_calc_vma_gfp() are or'ed with the flags set by > > the caller; this has been done to keep an architecture from modifying the > > flags already set by the core memory management code; this is similar to > > how do_mmap() -> calc_vm_flag_bits() -> arch_calc_vm_flag_bits() has been > > implemented. This can be revisited in the future if there's a need to do > > so. > > > > Signed-off-by: Alexandru Elisei > > This patch also needs to update the non-CONFIG_NUMA definition of > vma_alloc_folio in include/linux/gfp.h to call arch_calc_vma_gfp. See: > https://r.android.com/2849146 Of course, you're already reported this to me, I cherry-pick the version of the patch that doesn't have the fix for this series. Will fix. Thanks, Alex > > Peter