From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2617C47422 for ; Mon, 29 Jan 2024 11:46:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6068C6B00AF; Mon, 29 Jan 2024 06:46:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B6A76B00B1; Mon, 29 Jan 2024 06:46:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47E786B00B2; Mon, 29 Jan 2024 06:46:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3786C6B00AF for ; Mon, 29 Jan 2024 06:46:56 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5F4DF1A026A for ; Mon, 29 Jan 2024 11:46:54 +0000 (UTC) X-FDA: 81732171948.30.A42F0B2 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf26.hostedemail.com (Postfix) with ESMTP id BF21D140011 for ; Mon, 29 Jan 2024 11:46:52 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706528812; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wTGarlSdzWesgTloPbuLJ91dqjIlPmdsNOBHhBDRWUw=; b=h/oorXokmiaVF2iqMj1a/qB+sWWe/pO7JpSHxVEupoUveWPwb8D/ZALJhezrTB6yTH1Fku VVtYmrkVyMA9S7WX2NOSykpJaJE1MXs0FSwRbfe3c2LknM6ncR6ROFTEcWZtw3KGk9O+Hj H6rVHtQGbXhY4B53t/TS0WlV6h5uXQk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706528812; a=rsa-sha256; cv=none; b=h+FjsrusGdRLW+Cia0GCesXvP5+Qt3sWykmOBUrZ2+tueeBzCU/Zwd5ozK45nP/9jgUxhU SAzHsq1sjM+qUTacm8B+75UsMfyXqIF6AbCBLR4BevFuzBv9g138R/Udk7oCj1DMoU82Vb +nXrIgABINb6kgl/8uRqB5KQvnnTkek= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 824181FB; Mon, 29 Jan 2024 03:47:35 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3F77E3F5A1; Mon, 29 Jan 2024 03:46:46 -0800 (PST) Date: Mon, 29 Jan 2024 11:46:43 +0000 From: Alexandru Elisei To: Anshuman Khandual Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v3 05/35] mm: cma: Don't append newline when generating CMA area name Message-ID: References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-6-alexandru.elisei@arm.com> <8b5dfed3-f881-4f0a-be81-d7fcf3be0deb@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8b5dfed3-f881-4f0a-be81-d7fcf3be0deb@arm.com> X-Stat-Signature: w4byo7juaee5e1g79smn1se5aosj9fjn X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BF21D140011 X-Rspam-User: X-HE-Tag: 1706528812-614062 X-HE-Meta: U2FsdGVkX193SEmh8su5UYe7Omne7zl9cNwQHREpvuvwnel8FA13+bo96fzf1smlxCYjmEDAfhNeEUwVKwIWvnU9mSICatCQ0gsVV3dO1+NJFdUYbIwd0sT0C7OLQf3/LS0LOngqSFtzCsXM/PGxMjL6oW0nfpKA8iyBiSv3tyVQVDU3yHYZyVMohDQJa9MK8DH7fDhbr10UE3dMp6AoNhsm4hgYJLWLmpUA7DAlv01SH36PKTvQshtUGet097sm6K4ueI8gJcIbzh8nUJNZRpIBPsr2yeNGyQ7cR3ZkZ7GmM4t3Z4lWUzfGx/4qCdAm4knvxY9Z2skSV+oWfl3P5WuZNYroIKs6Ie+UL2NvTzVybNl7dZAro3SOsAP/AaBzXsJvgtMKjVGJ+rDC95/FS8mcMKCB+gL22lRQ/9bNdSnFun8MdN+6r9ZvKPxVlHPm7PfaLpSZf4ghVYMaIkIZgywanDAAKPPhSwgEoPUaj5Sn7iW7af1Rzi88hB1BDRZVSGw/tMUWBf1VnFlStrbEydOoO3YhPZ5bhntFMO97QIxlAD8myOQg78ZIHqOlGReEkTx8JsbyDb0B/rsHMsXP8k4mbiowK9EBko7aqYe7drp5xmuEVjAMXzHpkZwCciXd4RwghWYVlItXaDups/OnEpot+N1mbxGbvZk+1ivyesDN6L9WpAQWuhrQAPadQyJFDXeVt2HPMHaQTeeZVsC6+iuqewWKsHqbbuwiDEXEdFDG90DC0yOvXE1F03aYrnMIxY6wIq6pxlm13G0fu9MCApTLLbN8htHwHd4rSrnszVYgPcaZpAS0fK3BS+P5t3603dCOsjix+ADTok46a2Erb0lg26D1OcCX6J+jA/9d0nfxFDTCA3FsgEGIp3YynHSflhOa/NjgyGO1Xg290gOHGBYpW1cYNNrYgtemglM3l0tEg3rJTEXrhwuknIaXd9sah8GN7CZTptHOA8xw9zv y37Xi7EC rjRz3vimYyflGH1nGAN/3q5oKYo4dAFfcACEfNjk/s2bTrzMcV1zjh4mkHdIK07wOYMKqN8gi89xHmnl6fwMJOzOWxr0HQPu9pqdppDqkeKb4m+H6lBrVbnTUgB79JM5LzTroEwCWydHhj440LIU/U1hQz+/XlgcWkYXZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Mon, Jan 29, 2024 at 02:43:08PM +0530, Anshuman Khandual wrote: > > On 1/25/24 22:12, Alexandru Elisei wrote: > > cma->name is displayed in several CMA messages. When the name is generated > > by the CMA code, don't append a newline to avoid breaking the text across > > two lines. > > An example of such mis-formatted CMA output from dmesg could be added > here in the commit message to demonstrate the problem better. > > > > > Signed-off-by: Alexandru Elisei > > --- > > Regardless, LGTM. > > Reviewed-by: Anshuman Khandual Thanks! > > > > > Changes since rfc v2: > > > > * New patch. This is a fix, and can be merged independently of the other > > patches. > > Right, need not be part of this series. Hence please send it separately to > the MM list. Will do! Alex > > > > > mm/cma.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/cma.c b/mm/cma.c > > index 7c09c47e530b..f49c95f8ee37 100644 > > --- a/mm/cma.c > > +++ b/mm/cma.c > > @@ -204,7 +204,7 @@ int __init cma_init_reserved_mem(phys_addr_t base, phys_addr_t size, > > if (name) > > snprintf(cma->name, CMA_MAX_NAME, name); > > else > > - snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count); > > + snprintf(cma->name, CMA_MAX_NAME, "cma%d", cma_area_count); > > > > cma->base_pfn = PFN_DOWN(base); > > cma->count = size >> PAGE_SHIFT;