From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA99DC47DA9 for ; Mon, 29 Jan 2024 11:46:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 829506B00AD; Mon, 29 Jan 2024 06:46:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B2946B00AF; Mon, 29 Jan 2024 06:46:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 652E06B00B0; Mon, 29 Jan 2024 06:46:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 517F16B00AD for ; Mon, 29 Jan 2024 06:46:23 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 25D53409CD for ; Mon, 29 Jan 2024 11:46:23 +0000 (UTC) X-FDA: 81732170646.28.7B78C1A Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 6841F20004 for ; Mon, 29 Jan 2024 11:46:21 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706528781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m2OabXmPOlqlPUPQs/pX+k6hZQBYeDspGTikn3nkVC8=; b=QCodk+Zvhx1XDvcmFGJavdO/LQdNa80k59ryb5EcaD66MIOtk2J9v2En1gkyEkm+iSJNAr 8lzai6NdyzJHL3OPWJmi67s3f97cg9pAyQolEdDBTFuZACgOaFl7VQxNNSPlHqAJRCxLOy pS1tt8Zg2/WzIIv72uvhTtecueb2ko4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706528781; a=rsa-sha256; cv=none; b=MBQ6V7/yuzw9MEJmDBbMjkyv1K+JjFdCWB0PmZe7s0fDNuPLOvSoPq8+CI9/rQIe6P8dtx oa+PsWC49iym/was9XgTMrzYXa46ctjxsveWVF5GFf/V+1exfTlgAmwgD90oa2NsCcvAoI s0ofsxCMCdtLbUrx4zAM8I0RENSAhxQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2E09CDA7; Mon, 29 Jan 2024 03:47:04 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0040D3F5A1; Mon, 29 Jan 2024 03:46:14 -0800 (PST) Date: Mon, 29 Jan 2024 11:46:12 +0000 From: Alexandru Elisei To: Anshuman Khandual Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v3 04/35] mm: page_alloc: Partially revert "mm: page_alloc: remove stale CMA guard code" Message-ID: References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-5-alexandru.elisei@arm.com> <966a1a84-76dc-40da-bde2-251d2a81ee31@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <966a1a84-76dc-40da-bde2-251d2a81ee31@arm.com> X-Rspamd-Queue-Id: 6841F20004 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: km3o7hzucp16kqgcwt5qj3rm1ie1a591 X-HE-Tag: 1706528781-17769 X-HE-Meta: U2FsdGVkX1+evy0h+Csw+gdnxd3tKanLtDx/4vyeNSFXnh0qbxtaUqHp/hZBlV9PUxf4Drz2Y+Qf5ppE42gvXV0U04JI68aGTSh8/CzHXLZPznbyqqpQbICN9wKaGZmdIYuVhNJX9U6rSJFupn98rnQbpCHff7wEMFYUBkxs1v66fafmSv4D/5aSXTrpkRzBmFHjCdIaUh1JaysB3pFgq3rKAA54CgmKMZJrWJWIZCTK0CpvMHuILQpkiBGBL6KxsNFHdCKsUgEwaOg/wKss8MikImMk6N7VXj6bVyQkopMJMkvfp2P7T2LAq0cGKh1ipaxHLw/zrAKRysk9KAmN6Gy45aCutvk0NEVASGb7Z5NzvFR8TQEtO1yaxZoFmvkQMd7zmOJxZqa+IRKR1oJPfbNsh2+rGPyKH8vjJyjEv9rBXPEMIYWDmp6CPDiUiNQF2JSirpRvNscfWmQhnYiI6eUEIFSvDFrPSmTS8sgItbj81prX2zYrymQ8KCWmbFD5b33fHrhF8nFMPG91EMQ2xhJnuDjFlpVPoD8G/vOLCd1IVUZmPiP6ioqaC8LxYDTuz1QVpvSZDs1VlTAgCvHdL5E3EYhxI8kC9a6zADtRcgxnTp8SdHb8ZpVlJipulB0eMHxsQqeyZO2Mu+AM0e8TTKVQUwP5EknKwO/u2D9NIu9bz1cNBMiUq31ZSjDcLhf4i5skNgwVCB6Cc74mLtyB47twXIenc06S1lKa3HW1pqScRuO2dZszrt/rXWNa/Nex0sn2f8pmjibjgvK6fWCISsz2Mn2MDkImrW5xBA7a5Gsbl88Twk79phgBESzRBJOA6TYuDsn35ggltLinwhh5p1LIslpedvbgXEd/oJJ8oR+F2RbNd+ZccX1mRg7JUsx2Iwv/oaEP9UT1bUnHHNJPVgRVZZBvkoRcWMEEdeOtRYZ0yUOHhs7VEpwBO2/wc9otUfOEsehDzGFU1GvgeJS 7foGxNPV aMutwZC07bsLiqOn9F37KbSanpsMMrjaUp+2uyOTSW6g/uFCP4bEnLSCxR93r6Ma8ZGeB58HUq5unuxZWDMeY1YAJAjsocSuy6IxBM4I+lUF/Le/+V4wUtyj6fbISO79e6Y/fZMHCmJOQh9izKvGJ719wIlm5UaSRyhAYayL6fuS+7BAuas1d4XhdHwR0Gw3PR93w4mmUqITnWyDnxyUd8gM0iA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Mon, Jan 29, 2024 at 02:31:23PM +0530, Anshuman Khandual wrote: > > > On 1/25/24 22:12, Alexandru Elisei wrote: > > The patch f945116e4e19 ("mm: page_alloc: remove stale CMA guard code") > > removed the CMA filter when allocating from the MIGRATE_MOVABLE pcp list > > because CMA is always allowed when __GFP_MOVABLE is set. > > > > With the introduction of the arch_alloc_cma() function, the above is not > > true anymore, so bring back the filter. > > This makes sense as arch_alloc_cma() now might prevent ALLOC_CMA being > assigned to alloc_flags in gfp_to_alloc_flags_cma(). Can I add your Reviewed-by tag then? Thanks, Alex > > > > > This is a partially revert because the stale comment remains removed. > > > > Signed-off-by: Alexandru Elisei > > --- > > mm/page_alloc.c | 15 +++++++++++---- > > 1 file changed, 11 insertions(+), 4 deletions(-) > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index a96d47a6393e..0fa34bcfb1af 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -2897,10 +2897,17 @@ struct page *rmqueue(struct zone *preferred_zone, > > WARN_ON_ONCE((gfp_flags & __GFP_NOFAIL) && (order > 1)); > > > > if (likely(pcp_allowed_order(order))) { > > - page = rmqueue_pcplist(preferred_zone, zone, order, > > - migratetype, alloc_flags); > > - if (likely(page)) > > - goto out; > > + /* > > + * MIGRATE_MOVABLE pcplist could have the pages on CMA area and > > + * we need to skip it when CMA area isn't allowed. > > + */ > > + if (!IS_ENABLED(CONFIG_CMA) || alloc_flags & ALLOC_CMA || > > + migratetype != MIGRATE_MOVABLE) { > > + page = rmqueue_pcplist(preferred_zone, zone, order, > > + migratetype, alloc_flags); > > + if (likely(page)) > > + goto out; > > + } > > } > > > > page = rmqueue_buddy(preferred_zone, zone, order, alloc_flags,