From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C767C47DA9 for ; Mon, 29 Jan 2024 11:42:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0B986B0071; Mon, 29 Jan 2024 06:42:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ABB7C6B009B; Mon, 29 Jan 2024 06:42:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9AAA46B00A8; Mon, 29 Jan 2024 06:42:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8C9EB6B0071 for ; Mon, 29 Jan 2024 06:42:08 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 83654A1C6A for ; Mon, 29 Jan 2024 11:42:06 +0000 (UTC) X-FDA: 81732159852.12.A203861 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf22.hostedemail.com (Postfix) with ESMTP id CAC65C0015 for ; Mon, 29 Jan 2024 11:42:04 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf22.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706528525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nLJkxFrivrID/aGpCGA9+EbQ2PDD6cJ3zOffy3ODm3E=; b=Ws1BKza32wStSDus/4TcvJD+oz0VjAk0hqyQ5QkkF0Jl4D3IfpAXJlI/ZWWTi7mvI7w8sl zhInW4ZakxepXKRTOkj+/fYMtNLwvbt21d2I2dUyYzm4edIZBo2QH9N3eXnjS4ENsXQxhM JQr+E8njTW+7tbb4REZge5KZsZ0J674= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf22.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706528525; a=rsa-sha256; cv=none; b=cG2WymF9XDErm31BXW7ipOjCwyM66r+l9cQYs5HkmJnjoIv9CaWQBagLvNR86MoC9vD9Ta /hZkBESqF+tR9ON/nQy7iiHesfFHQKiT6/BBW8fgmYih8mn66/MH96YwEcYP4H1H+TfifU LNVeQ2AtFNj9j/2b7Bx4SEMS4wKOzrs= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AEEA71FB; Mon, 29 Jan 2024 03:42:47 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 86CCD3F5A1; Mon, 29 Jan 2024 03:41:58 -0800 (PST) Date: Mon, 29 Jan 2024 11:41:55 +0000 From: Alexandru Elisei To: Anshuman Khandual Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v3 01/35] mm: page_alloc: Add gfp_flags parameter to arch_alloc_page() Message-ID: References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-2-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: CAC65C0015 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: y557s6aqabosmp8qba5dfser6wkxaard X-HE-Tag: 1706528524-555785 X-HE-Meta: U2FsdGVkX1/UytiEgF2RkPlQQnF6gMHnCcxdiQ7ELY91SBMUTMo/h4JwkgyCGsXx6MAie3IJVnKf3nBsFtP6H8bIEvYaGcMh06OXto+WyOd/PHO0cuOXD4/AYpLVTyCXEw87p2sLt07XLcbLVZAKQjRwpwEGHqaGWL0jXMlGPd8tJCZbCH18T1x+OsDcRI/EqV+V76lGSWISk+JISfKwJskGyKVhBTcqBM22ttMwpdHRTohA/rBohFQIPG4w4o8FbA2t6BBvj59wReySfW3nzjz5IhY8Ix1EM5oG8SlE1VO9LbfIC61xKUMr5VmDw3KK4tAfaqaAdTEoFV5Xm9CZmHkKAzBAJJfL5eW3Et5UDjeV9z47a8dYpg9egf5HX5jPRfwXg94a3+dpnxE382CMRQkyc7dHamgimVILP63tsvsYOKnJy72tSxUEvFfQrQROqXdjGcWUZAN9Dhh6mBdpdYmG2u3qXA8d3c2Q6s9kG3epDtliCBqsb+2Q9NNVT8cSXxzib5PMczE8+xTff8EvCBAX6zQ+9Vo93svrpSjGfHigV/0l1ogP7xThgwoyOgl64if9Bs4NyhMQ1jST9lqm34rBuEDLPwB2i+8eaX9BXtQSUPkVi5fOTjpLhbuDCnP8TYdsKwCrFWrWad/J0v87SxlzmZsDgj1oNxHObhmbs2WI9Az2bFrjZG1i/IdTFwIrse2JAe0KExA1yK8pSoPVCHXqV2FNSo1/5YD8kZX1EfaZDmw9r94ue5LXkaBkuBwj/y1Kketw/qMHv6/tegxl3kbnpL5WU988IJ1NbJaIGN4H682LSrgDQHwsqnHpSp4XYk97dI/KZxh2bxxyfbPX5HDyUr2PzQ0WZVyEZuxOuhKJ6OyeNppBWmd28B+8dLYl/fawOtocMLycC18fT4XeUBbsbtw/SsGZTnMpkDnmO8geEKQARzMtMG80blT0RHfLIoeCx2ksTgoWX2+R6wv oxXchco3 jqj8rzvvkQeuo6WwMvme/Kw/GeTm0rlBxwvWh7Z/ZFIvUWW7P6QcuDQE/9Gecm2z++Ne6cVKT9k9kBM04YNDnWRLj9QsTASt2s22Q4jnyWKqHsyjxchzLFSCXWSM2ODV5VJBv/0fOJ6b5qFrPlvYoQgvPrV7ZkmbcCgbO8euza6voQaaPK4cRkUP4+ajba7L8n5X+QHa4mm/Sf9IvSKWd3QRs2y1dIcbEeXFRG1qyaYj9fw6Fj+xkIzeCw47PDKL3f3yxPQLS2pCw3KeQ0wCPNFCOUw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Mon, Jan 29, 2024 at 11:18:59AM +0530, Anshuman Khandual wrote: > > On 1/25/24 22:12, Alexandru Elisei wrote: > > Extend the usefulness of arch_alloc_page() by adding the gfp_flags > > parameter. > > Although the change here is harmless in itself, it will definitely benefit > from some additional context explaining the rationale, taking into account > why-how arch_alloc_page() got added particularly for s390 platform and how > it's going to be used in the present proposal. arm64 will use it to reserve tag storage if the caller requested a tagged page. Right now that means that __GFP_ZEROTAGS is set in the gfp mask, but I'll rename it to __GFP_TAGGED in patch #18 ("arm64: mte: Rename __GFP_ZEROTAGS to __GFP_TAGGED") [1]. [1] https://lore.kernel.org/lkml/20240125164256.4147-19-alexandru.elisei@arm.com/ Thanks, Alex > > > > > Signed-off-by: Alexandru Elisei > > --- > > > > Changes since rfc v2: > > > > * New patch. > > > > arch/s390/include/asm/page.h | 2 +- > > arch/s390/mm/page-states.c | 2 +- > > include/linux/gfp.h | 2 +- > > mm/page_alloc.c | 2 +- > > 4 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/arch/s390/include/asm/page.h b/arch/s390/include/asm/page.h > > index 73b9c3bf377f..859f0958c574 100644 > > --- a/arch/s390/include/asm/page.h > > +++ b/arch/s390/include/asm/page.h > > @@ -163,7 +163,7 @@ static inline int page_reset_referenced(unsigned long addr) > > > > struct page; > > void arch_free_page(struct page *page, int order); > > -void arch_alloc_page(struct page *page, int order); > > +void arch_alloc_page(struct page *page, int order, gfp_t gfp_flags); > > > > static inline int devmem_is_allowed(unsigned long pfn) > > { > > diff --git a/arch/s390/mm/page-states.c b/arch/s390/mm/page-states.c > > index 01f9b39e65f5..b986c8b158e3 100644 > > --- a/arch/s390/mm/page-states.c > > +++ b/arch/s390/mm/page-states.c > > @@ -21,7 +21,7 @@ void arch_free_page(struct page *page, int order) > > __set_page_unused(page_to_virt(page), 1UL << order); > > } > > > > -void arch_alloc_page(struct page *page, int order) > > +void arch_alloc_page(struct page *page, int order, gfp_t gfp_flags) > > { > > if (!cmma_flag) > > return; > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > > index de292a007138..9e8aa3d144db 100644 > > --- a/include/linux/gfp.h > > +++ b/include/linux/gfp.h > > @@ -172,7 +172,7 @@ static inline struct zonelist *node_zonelist(int nid, gfp_t flags) > > static inline void arch_free_page(struct page *page, int order) { } > > #endif > > #ifndef HAVE_ARCH_ALLOC_PAGE > > -static inline void arch_alloc_page(struct page *page, int order) { } > > +static inline void arch_alloc_page(struct page *page, int order, gfp_t gfp_flags) { } > > #endif > > > > struct page *__alloc_pages(gfp_t gfp, unsigned int order, int preferred_nid, > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index 150d4f23b010..2c140abe5ee6 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -1485,7 +1485,7 @@ inline void post_alloc_hook(struct page *page, unsigned int order, > > set_page_private(page, 0); > > set_page_refcounted(page); > > > > - arch_alloc_page(page, order); > > + arch_alloc_page(page, order, gfp_flags); > > debug_pagealloc_map_pages(page, 1 << order); > > > > /* > > Otherwise LGTM.