From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF764C47DDB for ; Mon, 29 Jan 2024 15:04:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EA2F6B00A4; Mon, 29 Jan 2024 10:04:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 49A0E6B00A5; Mon, 29 Jan 2024 10:04:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 361D06B00A6; Mon, 29 Jan 2024 10:04:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 238056B00A4 for ; Mon, 29 Jan 2024 10:04:35 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B9262A1F32 for ; Mon, 29 Jan 2024 15:04:34 +0000 (UTC) X-FDA: 81732670068.23.E2001BC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id ED6C31C002E for ; Mon, 29 Jan 2024 15:04:30 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=saGxSX6N; dkim=pass header.d=suse.com header.s=susede1 header.b=rggoIBsx; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706540671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qLDYdWmw6CK2qQtrHRQgWWQYsKvJNWhiGQv/PrF1tIo=; b=woCirZJT94YZBBfJnLVJhXJARiVc1+X32IhwOrPYYsG4dR+x3WC2NPQlQWJGtxe1c0+HdN 4vcE9zb1hdv6SVauD96qPbOAE+/jcARJwZXsIxa0kK10jsKgy3LxCRrHeYZJA0WoIf9NBh BVWQPZCR1vJEiycVoLdWTR0pw6tU3iA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706540671; a=rsa-sha256; cv=none; b=GUJpRnPraPZ9Q57vUTLCbNrAbucHwctOb8rQmWAQhwTxJPk6z/VhP472smskwRaYlnm09g GilaFIU6k5Hgx6lnFIL7M6wiCqsF3bjKFbQZVslx7fswaocXTre/PTIFIcu/dxJoAcDP/d GhsZrTL5Dw23t04UEPh5yJWCD4rZ90w= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=saGxSX6N; dkim=pass header.d=suse.com header.s=susede1 header.b=rggoIBsx; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DF0182229F; Mon, 29 Jan 2024 15:04:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1706540669; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qLDYdWmw6CK2qQtrHRQgWWQYsKvJNWhiGQv/PrF1tIo=; b=saGxSX6N5mcW8/z9thvLMK5caQHOHCBZJOPUGc0sZVhwRuZhazmNFySksz/OUxiFGC+aii gFBHXnKLFwF+cae2M10qPoLPX62/20ECeUB3vaIiMFqkHNdV1VMJFP6yOGHhNchvCTFz7t TYb8b1Spj0lqrux2CAqcSZxPvn5OK94= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1706540668; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qLDYdWmw6CK2qQtrHRQgWWQYsKvJNWhiGQv/PrF1tIo=; b=rggoIBsxma3yEW0oIshlsDtMevx74QEdciEc1yYE5AR2UwDobVchyv9b5u3O4s3D0rLLtV NXVXH28qVvWl1y2zAZJq5v4EeWU05vKrPBfELxDMwg0RKz1ediHLRmvctsqwICrdJWtPNZ CVo1J7VZboxv8X0TS+KUWSPWVFGinVo= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C0AC312FF7; Mon, 29 Jan 2024 15:04:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id NHzoK3y+t2UQPwAAD6G6ig (envelope-from ); Mon, 29 Jan 2024 15:04:28 +0000 Date: Mon, 29 Jan 2024 16:04:28 +0100 From: Michal Hocko To: Zach O'Keefe Cc: Charan Teja Kalla , akpm@linux-foundation.org, mgorman@techsingularity.net, david@redhat.com, vbabka@suse.cz, hannes@cmpxchg.org, quic_pkondeti@quicinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Axel Rasmussen , Yosry Ahmed , David Rientjes Subject: Re: [PATCH V3 3/3] mm: page_alloc: drain pcp lists before oom kill Message-ID: References: <5c7f25f9-f86b-8e15-8603-e212b9911cac@quicinc.com> <342a8854-eef5-f68a-15e5-275de70e3f01@quicinc.com> <5adb12eb-8403-5860-28eb-5f6ab12f3c04@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: ED6C31C002E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: c4myr1eprubdn3epzynxdnawhosd8trh X-HE-Tag: 1706540670-497442 X-HE-Meta: U2FsdGVkX19ViVioTH7p6RliPRxfBJj45xBlhkd3LsKuBvSrCRE9RF81eSFLrsHEDXDjzHKqLbYDMdA6gl8N5qc++X16NSLbmedVyRvqDvfIvssh1KR9AhMfrC7IoVgcihnGGopleZtUrgBmEZo9xZP9GjzZGzgvHi+ApUbgVLvyl8D3r4glBQdM8Y5SyCA9a7eR9klQ8i5vxp66kA37R5vARoKjUQrsiIGFQhaPV0ygz/PIsbI7ARZu45c8T0K2arNcVaNXMseFAc3NF6h4NtPgQ95zTCo/hrow7Y+8W+k/KKEAmI4tpBH0c9rkeSZg93IuKmcYPFQ2tnzz/btjcWpSgNw4/P7xjq/UKQU/DjVMiHVSSexWkXw4gft/7yUqw74clrLoSsDmfKxflcpAa5lPQ8b2YgIO9MqiN/DKWgYe3aQ2ZBGVIYU8zZ5AJoERgoW8hEUMD4/JqAvb+FjTfIDlXIYYEgG8AQXO0ev0dXAAqD5msNU++QrDDC5RoBJlTv0je5qGsFIP8GVnndgbKx5T9vzetEQ/HM6cpk82nBUMGRsJMeVvykPRq+GqLgDENjDjINDF6tjuoRgmfFgI3XOI+1Sdcv2xrOGv6yQBG1HA5CUu0gCl3CnIaStqrQ7nUgC5ew0FrcFwodpR25S4wbjQBstsmKLOHAaYZLoVXScwHifAH9wnCkr6OXfhZrN+C5Yj0RvsbrCUFPOKQ4mgyz8g0ICR9uzqwTFUjTwP3fzJ9sr+IqcTnzp2u08QIPTPpXe2ekNIPSgOCZeg7HoLReKKv6u+yMPBIWYH75Se6nojUthvYWkr0r5v2TyAHgXFf2kDxyl4CkNImfD4EyN3e8kW4eEXU1sXwuhat4nsSLntwaATsbuaDIzCvNhaS7+4qiVvei6foW7/2xq+5K0ikEgWP1P1ph4Hl+HJb3krDv3rHtlMcEfYzTUD3Gh+muQUgXZh4lkGyZir6QBZE+J z3LSGSar GjlMlZ0PjXhkRyOlNUGvoHmYFESMEuJPifUzIUf0bqx6EIxwLCDhGYC3jb3cVjiejASn2XbBeqmIwDzBKy0FjZdN/lRXewf76l5HZh2JvJAFtNyjG2UC+ZtkZgI0WdBtdBddqXnm+HWDUenZgyv1BfFUCzNsqoKFux2fTFPy4QPiJSPj4KgYTVISbFTTTZZE6PSaZ9JSyrq2xbBpJRgXjxltCbvjG/PHQEdh22pN+eJ24/IruwwosU6mBTLWQ8ox8BaEb32pRD8y2ZrZgmTvXr57kZKp9TkHYrNEPPg5gk3ZC8XiSt3Lc1cKYlDzWHWcKQAvkJLN/jvJjkATMvmBn5xj6yUKBKCmgAwfH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 26-01-24 14:51:26, Zach O'Keefe wrote: [...] > Node 0 DMA32 free:66592kB min:2580kB low:5220kB high:7860kB [...] > free_pcp:8040kB local_pcp:244kB free_cma:0kB > lowmem_reserve[]: 0 0 16029 16029 > Node 0 Normal free:513048kB min:513192kB low:1038700kB high:1564208kB [...] > mlocked:12344kB bounce:0kB free_pcp:790040kB local_pcp:7060kB [...] > mlocked:1588kB bounce:0kB free_pcp:253500kB local_pcp:12kB [...] > I'm not familiar with these changes, but a quick check of recent > activity points to v6.7 commit fa8c4f9a665b ("mm: fix draining remote > pageset") ; is this what you are referring to? No, but looking at above discrepancy between free_pcp and local_pcp would point that direction for sure. So this is worth checking. vmstat is a periodic activity and it cannot really deal with bursts of memory allocations but it is quite possible that the patch above will prevent the build up before it grows that large. I originally referred to different work though https://lore.kernel.org/all/20231016053002.756205-10-ying.huang@intel.com/T/#m9fdfabaee37db1320bbc678a69d1cdd8391640e0 merged as ca71fe1ad922 ("mm, pcp: avoid to drain PCP when process exit") and the associated patches. -- Michal Hocko SUSE Labs