From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82338C4828F for ; Sun, 4 Feb 2024 18:46:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64B0A6B0071; Sun, 4 Feb 2024 13:46:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FC136B0072; Sun, 4 Feb 2024 13:46:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E9AE6B0074; Sun, 4 Feb 2024 13:46:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3F99F6B0071 for ; Sun, 4 Feb 2024 13:46:37 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D519D1A0375 for ; Sun, 4 Feb 2024 18:46:36 +0000 (UTC) X-FDA: 81755002392.01.2DE58FB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id B621C40008 for ; Sun, 4 Feb 2024 18:46:34 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=MRuPTXHT; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707072395; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZrsQ1gAPq8HHoN6t4ZwPfn1Y/MogSDe4++j+eW6F0Ds=; b=xl76mJFzDGA99z33lTpGq81n22dA37fT2IojpqzR4YjSTVldX0CBmnKNcidP3oGX7LjDzF iBrxS9XpaA6fNe2zjR6j3beNfp8qy7qeQfVzuNKRa7pWayE3Ig0q0C+nYv1JMMP/hAVRCd vNbU1M3Ae4/mAfuXdIynTulPrKTIsU8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707072395; a=rsa-sha256; cv=none; b=fo/62+fmm1TduNuJIk8HDO/SBpKxT9zSMYU55svHCporaozrVdEowTLnV1Gz8/tK559Z4t RV4uFfHYwksjWPWi8PepHSlV11kweLHi5qafJXApu9z4xdor8Y2iyo91Os8QNIs5aRC9eT C2z560jWhv5HP7rcWqJYwsF4kxZgolY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=MRuPTXHT; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZrsQ1gAPq8HHoN6t4ZwPfn1Y/MogSDe4++j+eW6F0Ds=; b=MRuPTXHTij8SUOHq7zubl7+0kV LhuVxhkxJKFLVAvN4IHGYKpLlWxAXF+QtQ5Pth1/2Lmref4bZNU8RV0kiJjH9XsZy4T/vIevN8hf0 Fvh5IFSlbxtHD0b6PkM2jiWSQkecQm8t/mTE5Z0ZBGRAwy19uf2zKSdtfl8yfjSuCY54CysSD4VV0 linZIW/RtA/YflH8rXNp5+KLPtKAj1K+GbT81O4s8YrNJWAabSPcBtpWxUbo1XgLlIw6DgOsLWtor uKdUOlrRAmR6W2ngUaWrmcKxhl2WsIAC/FNZmah31H1zWYXaA38gUmeMRj2K43wY4Bh1xpoNFl+rq eOcYk9UA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWhVc-00000007JSF-1nKO; Sun, 04 Feb 2024 18:46:28 +0000 Date: Sun, 4 Feb 2024 18:46:28 +0000 From: Matthew Wilcox To: Zhongkun He Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/z3fold: remove unneeded spinlock Message-ID: References: <20240204125404.2112384-1-hezhongkun.hzk@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240204125404.2112384-1-hezhongkun.hzk@bytedance.com> X-Stat-Signature: nx1aayiqkjk9gxj4ut37imftnrm3bmsf X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B621C40008 X-Rspam-User: X-HE-Tag: 1707072394-51381 X-HE-Meta: U2FsdGVkX1/fG+nLpZgHABq8UuD48gpoXOtHcXuSTdYjVlooRwm+k20DS/0vJ17tz+3CnPXDqb2HYumSBxUQDq64QzXjPvWHJ55tjRW5gltUQvyLR87XALHifYYSSUhqHhQHl79Kd+e56cQ96vvVksgoW8HDsdtCnjZzvGx1qI+wMJ2QmcFLl1yXE8iZMA/eSDYaeyuHrWo1JOLpb1ENEfA/lEd5+Cb2v2dTVS7cADjhBEEobng6VRoikKa0hmltxsKQhK7SVEYKoN0Q/wYJHYisLLvByJb39x+YnxWJWo5A105G/WZrFw3vlIt3rNaqXO/JBHQeScrZq9QVXST+0IV8Afa6RE8LG87iwlET0wx60rIqi27tuqY32CiGf1ztQybYdb4ku7hG8HIpLO0lC9V/TZ3M030KTpAX3VP4CKh5qSLC5NxsVmAL9nKnQ7yIMMgAqbddmX2+eL6pZsCu/EYZXZ3L41Sc/YlB/jxfX4Y6jkvh6bAZOjoiiYDCH0tOeQEe0zJJdgEbpHucskVFMaox95olkRwCNMKvn7Yru9FR8pyDkIGF+6YyV7a1fT0VK4rH2BP+DEC8ynwqKgr8ZcISmluQ9cSrtVbaN9AYWYy2eL59Erb57P50pQ43juEsvMY8Ls/VKvBQU67ggrwcQKec6Lwh6PKdYhOFCUhKE68aND54khRCnmogR0Pwy48ezxuGNDEJ5hk8HUNGnG06axS1X8Ir165A0tsnzxUvvVFl7FQirxcNSqtYQx6+0VP/wlWnAKq8FvUCvCgnYHcYXRTPa5ZeQz4hOTjQCZ7KT1vBfELGREzS3ptgcvBQASb2V/n3lw1mGRcPpxE4Uu1x14ywdNpRMNy+UkUqoNa1Bx1lSIjxdjqLLu3S/TOxkODo2h+DGGZwDtkhUfHGzGZhcijIohcFJZ1pVCRuVpZuJEwiMiuq2JVlZhcojBbaZ3mqv9DWSrLgJyYlhe4v91t 23MbS+ss HjQk9eRaRKrqEbCxYY+M++P9CdBKqci5/bHRwuDIjnrAI5XuATz9/oXpwu+lM8LeO+FimvEAYUGJHAb4fMX7WjcfeS4v3LW1gKD1coxrS6qpu5dAlHjuZu2DLAwhrB8/h8b0VOZ0/1S/W3oM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Feb 04, 2024 at 08:54:04PM +0800, Zhongkun He wrote: > There is no need to use spinlock in this section, so > remove it. I don't know this code at all, but the idiom is (relatively) common. It waits until anybody _currently_ holding the lock has released it. That would, eg, make it safe to free the 'pool' memory. > - spin_lock(&pool->lock); > - spin_unlock(&pool->lock);