From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EDD1C47DDB for ; Fri, 26 Jan 2024 21:14:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B35506B0081; Fri, 26 Jan 2024 16:14:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE5DD6B0082; Fri, 26 Jan 2024 16:14:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9ACBC6B0083; Fri, 26 Jan 2024 16:14:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 87CD66B0081 for ; Fri, 26 Jan 2024 16:14:49 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 62B49A0433 for ; Fri, 26 Jan 2024 21:14:49 +0000 (UTC) X-FDA: 81722716698.15.562489E Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by imf23.hostedemail.com (Postfix) with ESMTP id 59321140003 for ; Fri, 26 Jan 2024 21:14:47 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hZfE4NAn; spf=pass (imf23.hostedemail.com: domain of alison.schofield@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=alison.schofield@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706303687; a=rsa-sha256; cv=none; b=DzG1uQ0K/Kf1UP06wWYPgWrp8iGnsv8uYLTZM02qpAZ9BhfS53DysYkGjBy/EsRoOhL/DB 76C8bnpDIOXrus6TpS7JmVbhVW7pnZzp0pyx1H4kFCGvBRs4tkF+bQvEibhW6WLcOEI0mB eCwU8sQUbhwq/r5YC9gtDKlBcgQeoVU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hZfE4NAn; spf=pass (imf23.hostedemail.com: domain of alison.schofield@intel.com designates 134.134.136.31 as permitted sender) smtp.mailfrom=alison.schofield@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706303687; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i7rCG+NctgCxpbsCXIb65Y7h+0O++SBTilAnEUcVWg4=; b=QcLhYZvvoAYGxLKbPioTNvpq5z1hvCLL2+6z0EEIsaR7Zc6YDMm8uVQubFX5Yo14S56LtJ Gqi/n/50NMi0yDI+lxKMc/LxXKiiyjRCX9ONXHUxavdOd4f9v9Cl7Co3a4Uik6IvxYc6Tn jUH/rq/zGHxBcxDu+3Fr/+oA99QdGC4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706303687; x=1737839687; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bqOAFirl4XtgWEUGnrqW5ioCbAdx3ANcQrwde5HfmII=; b=hZfE4NAnsyCZMAESZqYKnn2On4HSZpW7CD4Bf8qljJwDZQYTN6eHlFlK XdF2TKiwdPD+IIR4Lw/CeWQm46a3AU2oc9CpyICnjopDdMdNNc5v4jnzP nwX01gblFEgKRDaM3Ng5VHqMWTfVmUPIN8BtuZRt6lR/DHBXgvCr2zCaZ srLGBsy2B276Ad5bu7dwI0yOw6pFlbtBxKfkjF8KZqnfajPH2iVdV443f e/yoGoS8MTa2Fvnu+uSvevKI6A6ytdya86x5b9WRZoNWMN5Ez8K1MlCs5 RxQVp3NmNennwuQlE1kHAGvber/vP7nY3Vk/dbb80mYfkZp+sucuAGJPt w==; X-IronPort-AV: E=McAfee;i="6600,9927,10964"; a="466853102" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="466853102" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2024 13:14:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="21486061" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2) ([10.209.37.71]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2024 13:14:43 -0800 Date: Fri, 26 Jan 2024 13:14:42 -0800 From: Alison Schofield To: Vishal Verma Cc: Dan Williams , Dave Jiang , Andrew Morton , Oscar Salvador , linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, David Hildenbrand , Dave Hansen , Huang Ying , Greg Kroah-Hartman , Matthew Wilcox , linux-mm@kvack.org Subject: Re: [PATCH v7 2/5] dax/bus.c: replace several sprintf() with sysfs_emit() Message-ID: References: <20240124-vv-dax_abi-v7-0-20d16cb8d23d@intel.com> <20240124-vv-dax_abi-v7-2-20d16cb8d23d@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240124-vv-dax_abi-v7-2-20d16cb8d23d@intel.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 59321140003 X-Stat-Signature: pg5tkge43rc9fwoj6f6rk7rdmiga6non X-Rspam-User: X-HE-Tag: 1706303687-462981 X-HE-Meta: U2FsdGVkX191zcYfL5g7AtrfQruqHUBZSVpeWCtu2lLOCOaOBOjR8dQfc7kL+UqqSO3mnNjlbFl0gFopdun+R2+sDlX52TWQPWxXnIbEVuLwGDSezP6SgonXrTp9lQbkohuV7hBYspVRb5ZJmbocI6ll0GlVoztCgzTbKal6k/vqt8dgpe1Q8S2+i6h2DaNLG0tIlWguXoMEC/0ri6WqnvUY7S27Qjt4uZFBOy2RMVspzqlCqd2jgLz+7So3KyH/nU4I6vLVhg5OagaW7gdRIxMIig40/X06kXNr92gm8wtZ4DGMDtwfNQGi+oT2nwXhOtIv0LGNtNwNeA/OngPF5Na64fIWmB97c+YY/oEoZcE6IGxXkvNKfyVPMIjRhA7T/baDT8IVnL/f6c4WuaBunof2eA1Mu0B/aiCdQJzJdr5gXr/Aut/kWFGsSpqNadazJDHhD7MbAEItV5YKf+///Lld34zYofVyxCLyrCm5Jlxo3ZS04JsoZq9HaQDkIOgqV6dkKpNWj/nAfrRkjNXGm4wHQG1ofYbSXnRFxoctcW7CrOggOd9EeRsPQZ0XXDgMciVpjPb0L1oHMIQQvUknCb0vShrM+yRYJnmSZeDyDkqCmfQmiaa1Kj4pvyfIYjfLRve8gIhheR5RxZePeOVydQmkVNYzO6blF9+SxU8uGHeQt71YWLvKptLt2UTo7hu7y4s1ENztk8974T5G/eqrTt4A1XF/3peVSf5L+bmmh1CSjocRhBrqdh1i3mbN813RB7eg1WcL0Upn417q5MdN+szQjRP3qAl85zQEdiGaV/pK0zzRdbH5bzUHfKhKjFAoK31is5AsQQJk+MNZ5Myxhp8+V/6PDrxBPiN0Vd6laGCj7MeOTVYlFklODfykozFv830C1UllxxHN3Ykc2iqNYXF6A8TXCcG1UKZeuCSOETBnU7egIwdY2zKlF2GgQuPIeQfc//gr4PgK8AxFLHn TYglcB2s xth95KnLkLPUoc2hB7v8LDge7SpBPOX12lBzvnhhWy1WFWFhKoJ9aYcVvgbz7a3kXKK443rDTuzKKgDvCB93wVP1TPHd/+Nhf730KEaVYWXvb0c/DdM3bemeJf41NKQYJWIKX02Z/Pq0WKW86o0bpnL6eeAoF5RVp6qSy6NIAZtE853cXndmlLIRq9uHuCZbhfLE7bz2kdZlCjIXNkEj/WZYnzUJ4SmdBEFuUtoYw3kpW9gj/beS5P6lXRvsIWyzjtok6vk/rcHZyt+toTcrW8xmAqA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 24, 2024 at 12:03:47PM -0800, Vishal Verma wrote: > There were several places where drivers/dax/bus.c uses 'sprintf' to > print sysfs data. Since a sysfs_emit() helper is available specifically > for this purpose, replace all the sprintf() usage for sysfs with > sysfs_emit() in this file. > Reviewed-by: Alison Schofield > Cc: Dan Williams > Reported-by: Greg Kroah-Hartman > Signed-off-by: Vishal Verma > --- > drivers/dax/bus.c | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c > index cb148f74ceda..0fd948a4443e 100644 > --- a/drivers/dax/bus.c > +++ b/drivers/dax/bus.c > @@ -269,7 +269,7 @@ static ssize_t id_show(struct device *dev, > { > struct dax_region *dax_region = dev_get_drvdata(dev); > > - return sprintf(buf, "%d\n", dax_region->id); > + return sysfs_emit(buf, "%d\n", dax_region->id); > } > static DEVICE_ATTR_RO(id); > > @@ -278,8 +278,8 @@ static ssize_t region_size_show(struct device *dev, > { > struct dax_region *dax_region = dev_get_drvdata(dev); > > - return sprintf(buf, "%llu\n", (unsigned long long) > - resource_size(&dax_region->res)); > + return sysfs_emit(buf, "%llu\n", > + (unsigned long long)resource_size(&dax_region->res)); > } > static struct device_attribute dev_attr_region_size = __ATTR(size, 0444, > region_size_show, NULL); > @@ -289,7 +289,7 @@ static ssize_t region_align_show(struct device *dev, > { > struct dax_region *dax_region = dev_get_drvdata(dev); > > - return sprintf(buf, "%u\n", dax_region->align); > + return sysfs_emit(buf, "%u\n", dax_region->align); > } > static struct device_attribute dev_attr_region_align = > __ATTR(align, 0400, region_align_show, NULL); > @@ -322,7 +322,7 @@ static ssize_t available_size_show(struct device *dev, > size = dax_region_avail_size(dax_region); > up_read(&dax_region_rwsem); > > - return sprintf(buf, "%llu\n", size); > + return sysfs_emit(buf, "%llu\n", size); > } > static DEVICE_ATTR_RO(available_size); > > @@ -340,7 +340,7 @@ static ssize_t seed_show(struct device *dev, > if (rc) > return rc; > seed = dax_region->seed; > - rc = sprintf(buf, "%s\n", seed ? dev_name(seed) : ""); > + rc = sysfs_emit(buf, "%s\n", seed ? dev_name(seed) : ""); > up_read(&dax_region_rwsem); > > return rc; > @@ -361,7 +361,7 @@ static ssize_t create_show(struct device *dev, > if (rc) > return rc; > youngest = dax_region->youngest; > - rc = sprintf(buf, "%s\n", youngest ? dev_name(youngest) : ""); > + rc = sysfs_emit(buf, "%s\n", youngest ? dev_name(youngest) : ""); > up_read(&dax_region_rwsem); > > return rc; > @@ -763,7 +763,7 @@ static ssize_t start_show(struct device *dev, > dax_range = get_dax_range(dev); > if (!dax_range) > return -ENXIO; > - rc = sprintf(buf, "%#llx\n", dax_range->range.start); > + rc = sysfs_emit(buf, "%#llx\n", dax_range->range.start); > put_dax_range(); > > return rc; > @@ -779,7 +779,7 @@ static ssize_t end_show(struct device *dev, > dax_range = get_dax_range(dev); > if (!dax_range) > return -ENXIO; > - rc = sprintf(buf, "%#llx\n", dax_range->range.end); > + rc = sysfs_emit(buf, "%#llx\n", dax_range->range.end); > put_dax_range(); > > return rc; > @@ -795,7 +795,7 @@ static ssize_t pgoff_show(struct device *dev, > dax_range = get_dax_range(dev); > if (!dax_range) > return -ENXIO; > - rc = sprintf(buf, "%#lx\n", dax_range->pgoff); > + rc = sysfs_emit(buf, "%#lx\n", dax_range->pgoff); > put_dax_range(); > > return rc; > @@ -969,7 +969,7 @@ static ssize_t size_show(struct device *dev, > size = dev_dax_size(dev_dax); > up_write(&dax_dev_rwsem); > > - return sprintf(buf, "%llu\n", size); > + return sysfs_emit(buf, "%llu\n", size); > } > > static bool alloc_is_aligned(struct dev_dax *dev_dax, resource_size_t size) > @@ -1233,7 +1233,7 @@ static ssize_t align_show(struct device *dev, > { > struct dev_dax *dev_dax = to_dev_dax(dev); > > - return sprintf(buf, "%d\n", dev_dax->align); > + return sysfs_emit(buf, "%d\n", dev_dax->align); > } > > static ssize_t dev_dax_validate_align(struct dev_dax *dev_dax) > @@ -1311,7 +1311,7 @@ static ssize_t target_node_show(struct device *dev, > { > struct dev_dax *dev_dax = to_dev_dax(dev); > > - return sprintf(buf, "%d\n", dev_dax_target_node(dev_dax)); > + return sysfs_emit(buf, "%d\n", dev_dax_target_node(dev_dax)); > } > static DEVICE_ATTR_RO(target_node); > > @@ -1327,7 +1327,7 @@ static ssize_t resource_show(struct device *dev, > else > start = dev_dax->ranges[0].range.start; > > - return sprintf(buf, "%#llx\n", start); > + return sysfs_emit(buf, "%#llx\n", start); > } > static DEVICE_ATTR(resource, 0400, resource_show, NULL); > > @@ -1338,14 +1338,14 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *attr, > * We only ever expect to handle device-dax instances, i.e. the > * @type argument to MODULE_ALIAS_DAX_DEVICE() is always zero > */ > - return sprintf(buf, DAX_DEVICE_MODALIAS_FMT "\n", 0); > + return sysfs_emit(buf, DAX_DEVICE_MODALIAS_FMT "\n", 0); > } > static DEVICE_ATTR_RO(modalias); > > static ssize_t numa_node_show(struct device *dev, > struct device_attribute *attr, char *buf) > { > - return sprintf(buf, "%d\n", dev_to_node(dev)); > + return sysfs_emit(buf, "%d\n", dev_to_node(dev)); > } > static DEVICE_ATTR_RO(numa_node); > > > -- > 2.43.0 > >