From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AFB5C47DDB for ; Fri, 26 Jan 2024 17:01:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A89B6B0083; Fri, 26 Jan 2024 12:01:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 932236B0087; Fri, 26 Jan 2024 12:01:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D2CF6B0092; Fri, 26 Jan 2024 12:01:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 64A7A6B0083 for ; Fri, 26 Jan 2024 12:01:58 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3746080DC2 for ; Fri, 26 Jan 2024 17:01:58 +0000 (UTC) X-FDA: 81722079516.25.94AEF56 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf07.hostedemail.com (Postfix) with ESMTP id 8B27740011 for ; Fri, 26 Jan 2024 17:01:55 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf07.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706288516; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RvcQHcaYurlIDlUD6bMD/l1Ik1nlGBK1Z0ZQAvxuPOM=; b=XT9gZ8qwwCFly5pLbqPs+Tk8Le0qO1fpWWXkwhF8KgLUFZ49I/W/c8bmXg9AKEUIwN7Xzh qO+1szOzIMbvHRayF8otE9aIthbmj9xHuy/aGvTtCt/iwq/PbFbrepUEbuphMi8UHQti+7 b9ufHroDMu5UcNT7YGRVJFHfsl7mr5I= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf07.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706288516; a=rsa-sha256; cv=none; b=GPxEk8XZzB0cf4hKPrvGzSlrkAsitIMj0HwAjSUiEmoQ6oSkPIn2fEXpDwrsSqQgDqchHP JEfj7v989yLD8AlSOI0th32KKMjBFKZ+P9k9j/IK0F7gs+UBjnNNW/fhp6013e+mBI1OEr XDINTvUBi7WN2caqy927qCjd85nHaMo= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 56F8B1FB; Fri, 26 Jan 2024 09:02:38 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0D4953F762; Fri, 26 Jan 2024 09:01:45 -0800 (PST) Date: Fri, 26 Jan 2024 17:01:42 +0000 From: Alexandru Elisei To: Krzysztof Kozlowski Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v3 19/35] arm64: mte: Discover tag storage memory Message-ID: References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-20-alexandru.elisei@arm.com> <5b8ce251-0790-4e2c-b5b1-0d2aeacbdd92@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b8ce251-0790-4e2c-b5b1-0d2aeacbdd92@kernel.org> X-Rspam-User: X-Stat-Signature: bt5tnm3q8gu39bjzexcqunpe87ucmjok X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8B27740011 X-HE-Tag: 1706288515-811922 X-HE-Meta: U2FsdGVkX19iDiAEVTJSL5YljVU3jVY6yWa7VwIJN509szsnZHfg6pOwrcjpgfEk4idb6psdIQ2f1aX8pX+xylccNQRfT+nR7aeo5Ps/F6OvWHznEtBHT91mKxuMoTNDVgB4YTzFn6s2f5qDuV8Az201C4ymkLkQnMsMGCPgSPGa2v75/5FKqA612vUDIWc9splxp1HLYmFbr46BV0ropSIAzjCWJHnBpdM7b2Za9kGiDYaOcA+8My7fKWeuiL1vpXSbV2CuSQbfkKtLJujcIOOtez9SnyMTWRMEIn9b+CXvV/1eY59AAwp8Cgwc+bbx+q699v4AITZgJGrDgmd/VaSIJHhuSIMkCj/7K9/R/7NUMvliUiOS4YSQqLF5cvWWEX5NDgDXgOYg9DyY4Sai4IVQ0W8p2zJHb7mWapFZXMZuCM7SRygpGUdG8sL+H8n9UzTKhMgmbcFI5VBydTrA+VbOMs8jyFMZdsVK8LE9O/87aTvQIPtx8U6m75cRU/WnK9T4jgtu+8X82EFOM6302u7fdtv7enyVTwJF2sZ+C+n0XV2Rcpr8uOPM6O9CEKFOUciPCzxwcXqdMw4WAVWK5LsWSxP7IfUzZdTA34eW6l3sPRLmNCv0uYRSTlFHumzPZ6c78SWgb/V/VOQB9k/cChUo6bPz3tN98SoLPHr/+sTW2cB66IHKcuUaORJmHr9ghUL/z8PUfLc0rb04JL+6rSJdeU19CbYVbYHfj1FaizZhmIE/UAEiAjBSeMwyb0JTYw4B0du7/+9cvrAFYc10t3uaqkGfluqZMcyGSchHsxY1b437T53mWw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Krzysztof, On Fri, Jan 26, 2024 at 09:50:58AM +0100, Krzysztof Kozlowski wrote: > On 25/01/2024 17:42, Alexandru Elisei wrote: > > Allow the kernel to get the base address, size, block size and associated > > memory node for tag storage from the device tree blob. > > > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > Tools like b4 or scripts_getmaintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, use mainline), work on fork of kernel (don't, use > mainline) or you ignore some maintainers (really don't). Just use b4 and > all the problems go away. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time, thus I will skip this patch entirely till you follow > the process allowing the patch to be tested. > > Please kindly resend and include all necessary To/Cc entries. My mistake, the previous iteration of the series didn't include a devicetree binding and I forgot to update the To/Cc list. Thank you for the heads-up, hopefully you can have a look after I resend the series. > > > > A tag storage region represents the smallest contiguous memory region that > > holds all the tags for the associated contiguous memory region which can be > > tagged. For example, for a 32GB contiguous tagged memory the corresponding > > tag storage region is exactly 1GB of contiguous memory, not two adjacent > > 512M of tag storage memory, nor one 2GB tag storage region. > > > > Tag storage is described as reserved memory; future patches will teach the > > kernel how to make use of it for data (non-tagged) allocations. > > > > Signed-off-by: Alexandru Elisei > > --- > > > > Changes since rfc v2: > > > > * Reworked from rfc v2 patch #11 ("arm64: mte: Reserve tag storage memory"). > > * Added device tree schema (Rob Herring) > > * Tag storage memory is now described in the "reserved-memory" node (Rob > > Herring). > > > > .../reserved-memory/arm,mte-tag-storage.yaml | 78 +++++++++ > > Please run scripts/checkpatch.pl and fix reported warnings. Some > warnings can be ignored, but the code here looks like it needs a fix. > Feel free to get in touch if the warning is not clear. Thank you for pointing it out, I'll move the binding to a separate patch. Alex