From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDC1EC47422 for ; Fri, 26 Jan 2024 16:48:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55B8C6B0088; Fri, 26 Jan 2024 11:48:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E4B26B0089; Fri, 26 Jan 2024 11:48:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 385BA6B0095; Fri, 26 Jan 2024 11:48:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 25ABB6B0088 for ; Fri, 26 Jan 2024 11:48:01 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E63FF4039D for ; Fri, 26 Jan 2024 16:48:00 +0000 (UTC) X-FDA: 81722044320.20.E2D5C85 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 4466912002E for ; Fri, 26 Jan 2024 16:47:59 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AradtZLz; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706287679; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9jCfrEz+uX7VbktVuh7g8Wwg/zmEUFcGpXjFQj1/e30=; b=0Q/OxF3jrZlS4/mA7g2ct8/+2fRgSmqq3BekYzZyXGEODmMkxquRluODYQ2GQyoGrquxaI Z1d221bZdhe3Yo0xN05nQg6dnJIwCkG+JwusRve1trYYlf6jewgcW+6dIQ3JQzb2dsHlcX JYIKpXyT0gh9F3gcfs3BG2E6n9WLkXE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AradtZLz; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706287679; a=rsa-sha256; cv=none; b=amwJ2fJCj4x24otKS/KQfO5lWxs256w+Qp5TwNW8z6E8jPqYddumT4ArBUKNu05Mp25bM/ EHIL3hp5BcPuSABuKGvOXJoN1he6cNajCwAsJuXi3hDtF3p401/X5B+8hac1HsaDC59Wqh DGlEOugIyqP0yVl1Qz879oYoetc74ls= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9jCfrEz+uX7VbktVuh7g8Wwg/zmEUFcGpXjFQj1/e30=; b=AradtZLzE5EFRBBMIuipukN5Ks V0aQ8rlsOcOgtvrXCNKlzIkTT6WfOqrNDJDZBn6ZJCOBDkHjAF6b4MizDoE311TRqVCj18XwFpuMz nL9I5O3bcfFqXVD1KfKmkl1YIy+jsm7GwqhUk4AliJ98Gv5/hddGShiVEF0GOUzqP/Ly1yoQjg3NC SDNXwO85hxcW6rxqdMGJJLKKVVDlFhRyaeNR75V56zJ1rwzbVVZ2lNZIEJEy/xrotsp8dumOlWgQf ooi2O0WWQNDeVJUxqBBCueV6HpYToNxfbdGJR4f+2ey7gAy7eDkU3fngLlbjchsE1w/AQH4tlQqcx rzcpR0qw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTPMw-0000000EDl8-328J; Fri, 26 Jan 2024 16:47:54 +0000 Date: Fri, 26 Jan 2024 16:47:54 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: put the xfs xfile abstraction on a diet v2 Message-ID: References: <20240126132903.2700077-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240126132903.2700077-1-hch@lst.de> X-Rspamd-Queue-Id: 4466912002E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: fgdrxyc6cm61g4unnszrkx71u839bk5j X-HE-Tag: 1706287679-32042 X-HE-Meta: U2FsdGVkX1/3jNgUNCjjxCL0GRFnQXBr0oqtn1TITKO6Rx3ISlFc+uwPCT67o/sx7KLVz5BHcY2jLYkkH+QVUm912ozvUIsQ1d+cJqHZDcaR0h9qAN0Ca0PA6tsnjp2PoBtaTXCFjRiJTheoJ7ntCgP8B8NHCOaEk/ZWgPgy5GZC3C2sIEKcZC24QkNITlCinsw4cFlav/0ZR0oQVxxx1k+MIIQRiODgltU/zKuyWlXKChLRbEQxJqAcl+IiLEs38Djo1Wt1EFUCVH82qwCKKGXH6rWoa6N6yL9JLAgHqd0k0Ro8tTZXX5rK5Aa3gbIZ89KipDLlIuSAIDxznSno9QF25dGn9d/fbUmSHKWyHBHdl4XNAXKX4sgVsHRVgdwLwz8whjtwWW4hfyoS28K6iR2e8JmCE2SbKnzaU0r996c0UedwJJom/lsGhdNzZdgyg5RQznuzJDRrcrF0W8tdk13TI/dp4fgqMbV2IjYl+MZMPvoyzVz38VAwaqrMsR4b21roGNNerZiRRE6oZ8qW5E88oVnpHSSlr1cr5ULXaHptFsFOLJEkFOJKyO4Q6t/7eb/0UaS6waUi2RcaDTQ3rtlW6T1Dly3xNjhpzvSCmNvfGmQjlTMrEvSbaHI9fXiMDoHnWSbdPa2ZwwQXRFXdVc4NV7rScpzEmBs+4QcxkApXOjlVIPBqJjeoiMmPpa6F/cMs5+x1ct0PyxiJ+F94iAIiYMwlzTVuPjYo3E98KZOcOtUEBGvs+ymMDXhRs22p89bKi4JPH1n2f7kH0npCuae2AWpt8z0zGvVm+4Lo+vV5OOceecGFZgrjhIWEW1WTFOQJ/acd7Lvx6UiY/Z03+ujqhVg1olflxFpKc8jGa2XbBJdbeRQqwcFXEVrc+Gua2MEoGH2qcwAn3PpCZjZFdhZPU5JD0LkdOV7IlH6nq8sCyDFT+U9z7elwVKeLWF5/r/6S/eR2f9gpUbNEyS/ BpB89J6c TESvCEb0k3toqSr3M+M4PNj9NmZffx3LMnNcPE0xnNLw+KKqv77sHGo0mHiHZEyMHN5bjMz0Pqijzu5NUDlolvVT0XcQYZ2+iCd1yTknIMbLHewsLFybJAxdOZriD+CCOe/wThtLjziXMDH4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000034, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 02:28:42PM +0100, Christoph Hellwig wrote: > this series refactors and simplifies the code in the xfs xfile > abstraction, which is a thing layer on a kernel-use shmem file. OK, I've finished reviewing the series. I'm not offering R-b for the xfiles portions as I feel I don't understand the code well enough to do a high quality review. In general it looks good, and I only had minor quibbles; the overall direction is good.