From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA3DEC47DDB for ; Fri, 26 Jan 2024 16:27:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1335F6B009B; Fri, 26 Jan 2024 11:27:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E3CC6B009F; Fri, 26 Jan 2024 11:27:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEDF36B00A0; Fri, 26 Jan 2024 11:27:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E00F26B009B for ; Fri, 26 Jan 2024 11:27:05 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8B7D04050C for ; Fri, 26 Jan 2024 16:27:05 +0000 (UTC) X-FDA: 81721991610.13.71715C0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id E68CAC000A for ; Fri, 26 Jan 2024 16:27:03 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kIKpYALV; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706286424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MoCxtq1T03XgSJvkoQI5WYvO92xmQhfwt4sXWWBLhpM=; b=0sftodefQz8m2/xlvJ9te7XiHBjsduD5FT3xv/hXO3Lzuwt0fmNESi1rdczpggybyMABln PftTEbOrg5u77ykDNP3yx7Wk7zTPaFvJRtiMljDZRW9FioThYXlT/LC6e+YYrvor7yNJQM kYxs0rvS+BByvDdMiHw7w/dJO8/av4g= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kIKpYALV; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706286424; a=rsa-sha256; cv=none; b=YXYJoFo/vOJ1qpTUAxEGYvdyOWjTLR1tCGZ747lfP3MGDGtt8KF43LBfCVYekhARr0WdZ3 SG1yEVOGjMVy+gSftOeFBWCQxmdjRiHOZvFBd0D1IT21OWKoaD0+GQybWUj1pFUFmhfWI1 7lUunNDAGpLdf2vvFeNSMOvVDHfoOMQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MoCxtq1T03XgSJvkoQI5WYvO92xmQhfwt4sXWWBLhpM=; b=kIKpYALV4F6TgwUNp/S1bA03Nb z2rNfp7MZHbHzuj24gSjMQmFhX/vucWQY8WYcAjt0BveutzluHzrbUlaTHPkFrZKp8cqxo0iaSVPc PmhMrjAT3/udbIQdphKAOWblOEsmVMCESC5YdXv9IVlbAg3ngdOPt7zDYjxpY8dQaj0ZgRPpiYm3S Rh97KikPE62sh+pyNiFcRVDbNqvnOTSsAIRk9dxLIBbabT2SYlhF5yVQ6niFS64xp8zAzhM+TSn6s opgwRMofm2iK839FP99AAATAurbSnuzKOuLdqS5BA/SreoX+uXI62NlEL+NRXoLA4rLaAgpelhcuU HByJ2Kww==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTP2h-0000000EA9b-1rYg; Fri, 26 Jan 2024 16:26:59 +0000 Date: Fri, 26 Jan 2024 16:26:59 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 13/21] xfs: don't allow highmem pages in xfile mappings Message-ID: References: <20240126132903.2700077-1-hch@lst.de> <20240126132903.2700077-14-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240126132903.2700077-14-hch@lst.de> X-Rspam-User: X-Stat-Signature: 7ps8m6o38rpaj31q3n8uhw41bnmjcukr X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E68CAC000A X-HE-Tag: 1706286423-164817 X-HE-Meta: U2FsdGVkX18o36hv4msQnCZ7g6ZVWxKY6RBMtEvmP23+HJjuqcZ/80hbsYkie+gDf3p02MBeTUS2u+my/IHY/jj1hprHTmXq7j03eNT+BuvXujJNywnAmDbEOhz/IJzEUa2MBSYp5q18jmqBrCUJ9N0/9SycSwSP4lpOBk1CDck/N8bEG0WZO7rsxBGrmq+VSPfyGEpkYJw/HgstD/0vuWvF0Og4KM4IlgeaNSqp9Whz0ux6Gw2LLLbLEky2JlJfYvagvj+YNCo3wfm06syBS4lCE8MaZEIfc19pT2kTQDIah3EggWX8SftINdKLTSvdsU5kltQKq7OqKD07+kazfxvhmg6DKkmWMGHJkIcFRv31YFn+dwHOP7E1SY9FId0V8+N0O8b+GS8z3tL7x7yH14FlIfbXnQXXzKctPOnZiwWdCAcJ6lumUcPvUz4HXYdTCf6s0WaeSsfYtRoFVOPLDZaRHvXLJTrVKITc1NNn65VUXwUJuWGJ/+LVsVu43NVpgvhWpwcIDCZRhDu/oePwmk5SIOzHAg51rMs7mtXcBxMkMe8XTaYPpnMko72ejsO5eUoBVd6w/y26XhzHDr71kcRum1ZqFITbF8AZ9+Ftp34i33tbIjrXhMP7M/w2nx6a4RGA1AepqBUmMYAQ32f+z1qTxH0TMqhOY4SgiymxEeIlsGDlCE5Wz/DKNH/fx5hhW+3A7xhcDPBzWV24LHggmnrn5uXAK5el8AotAP3B0R9Tr10tIsxXe8kEGBVa1q5IJ/pFBVpIIEmjYhFFVI6iOFb5jU9WziyLzip84nFU3Cj3HpWPi/IIogSaFoI9MdjRBUcQzNg6JqF3oQPkgtu0QoLdN7Y16Umu21mAsT2rSUkcNz0/rk8pckVbDTKXcCIY+OZ6hDpNImPPKOlJFG911sVrcX94uXnXzXujjU6UPrVoEjcFBnkrKxWF4xBNuul8ttjiZ78mbXpR/iiGM1w AS0iO85l hxUfBGSnJLd9cpycCZgPbhCxX0F7zkezlTM4WV+iKJpt45ozz5Z+ZyIeBFRSIMxl4aTNOI4Gb4C5d9nr6f43ctPmIOk0Mq7X8SjyWBXiQE3t3zUNgC8Uh8PjlY7bLoKKddKjeH4/ytRjX9areIt89f+s/GrEd6hnNxesU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 02:28:55PM +0100, Christoph Hellwig wrote: > XFS is generally used on 64-bit, non-highmem platforms and xfile > mappings are accessed all the time. Reduce our pain by not allowing > any highmem mappings in the xfile page cache and remove all the kmap > calls for it. Ummm ... > +++ b/fs/xfs/scrub/xfile.c > @@ -77,6 +77,12 @@ xfile_create( > inode = file_inode(xf->file); > lockdep_set_class(&inode->i_rwsem, &xfile_i_mutex_key); > > + /* > + * We don't want to bother with kmapping data during repair, so don't > + * allow highmem pages to back this mapping. > + */ > + mapping_set_gfp_mask(inode->i_mapping, GFP_HIGHUSER); HIGHUSER includes __GFP_HIGHMEM. Do you want GFP_USER? Compared to GFP_KERNEL, it includes the "cpuset memory allocation policy" which ... I have no idea what it means, honestly.