From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2B32C47DDB for ; Fri, 26 Jan 2024 16:29:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 554446B0085; Fri, 26 Jan 2024 11:29:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 504236B0088; Fri, 26 Jan 2024 11:29:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F41A6B009B; Fri, 26 Jan 2024 11:29:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2FC106B0085 for ; Fri, 26 Jan 2024 11:29:49 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D22C340590 for ; Fri, 26 Jan 2024 16:29:48 +0000 (UTC) X-FDA: 81721998456.20.A2DA88C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 469B01C0008 for ; Fri, 26 Jan 2024 16:29:47 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FicqndMj; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706286587; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wy+XkLuRo2PBD+rdI0vTOnLpO313KFe+vZMzhQ+4sws=; b=L+VJ8G4Asm7XTXdxzn2+ioGawZoLQ7G2CZKoBbrivOV+6ZXCp+yhIKWV/2S54U5EcHHShN sEQfm6GD9p/pnEKCYqF1BnlZ4Cgip3of3mbF9OoS/MpILY35ZdzZaetFslbYgM5M/94M+R q7FyrOW4czjlIrJ6Kkkgqqq/YvRWdY8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FicqndMj; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706286587; a=rsa-sha256; cv=none; b=3rUrpyeeqrCIt4N8LtzGWZ7DfZ3LxUI/Xgpj9Aqb1guU9+5uKqKY4YbGgXoONHEnL2YGs/ 2UhyJ2ZgvbajSngxhzpNGWek0S74ekN7jQnVQ2Kbg9CQAvtJdlsFtsgHXK12YrVRqgrntH 61aZdg9tjeKDNRmb/udtvZOuafj6edU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wy+XkLuRo2PBD+rdI0vTOnLpO313KFe+vZMzhQ+4sws=; b=FicqndMjK7dzS9MlZz8+h/SsnW 6HNo4t7w3Mfun7L15lEnPdPxkGSQCygt94YS8uSsjGlUpSkwUg7qqX5CzL8DxuIRrbaTyXqfeAyue rYNhIaMqo3ITU+GVYnIFBSorGb8hH2oLUvS0paG6xiVdQWGFVSm3eBNu2YwJrCmDyE6ytjUPpOTW/ xh8rVs3tjFgIZXxFrxpusA+idTZnU1SqSlvT2deBWpf9kSBVyP4WDFPvC+gsR3Q9LdchjnR3aJBJz idmvaVMPN+eyI2HQhc4JvuKIrZdWPCMHVzSs1KTl6T+sBeXC7iDA5OYlLqGtlNv2V/+GCYxj3UR/i mPa5wIAw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTP5L-0000000EAub-20YU; Fri, 26 Jan 2024 16:29:43 +0000 Date: Fri, 26 Jan 2024 16:29:43 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 14/21] xfs: use shmem_get_folio in xfile_obj_store Message-ID: References: <20240126132903.2700077-1-hch@lst.de> <20240126132903.2700077-15-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240126132903.2700077-15-hch@lst.de> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 469B01C0008 X-Stat-Signature: ma34h3a53a7zo6fped7r8pjq8bhi8iu6 X-HE-Tag: 1706286587-59722 X-HE-Meta: U2FsdGVkX1+61iZr4glV0/PxRrysa5qLyPW4Xf8R2hyZdTwxsPEK17dP212OdIbDMLBDROmz+GIrrPYysoFwUt8lWDyKZo/4V8yiW8j8JBqy2EKRkx1AYoLIHkA5ZqYsibyubIh3mFZsoldU/VjVR5wbgBOnGgg0dIxahgppqwDun+JTgssPaNVKK+Mc1VFwt7FL+QY66nEOat/egviLt2ksZMthIIdhKrYHRDUva504iDQyV/ShigjXOpg8c4xHxprmk/vVLAaupmSQo3T/qJpHxuEt27LSvA9bAyM7OHLvWu5nX07i1zyXF96mDl2p4w43ILvHqz7txaMn764m/F+j/JGlaolvQMITic6cDyQHH788osG/pK7DeCoOQcNTpwqK3N9EK9sgwN10wAyGNgGETYgg1rdXn3uUlFWpaEUOafh6fbtpE6k7pKEjOHtSbo6GEAz4tEdtCD6yzKdYjERwOHg6SE714wf4qVYAFxk8zHNgjkCMHmrkKS39yO2MQsyVWINKdubMemzNNQsUKicAidJpCRryf6jog+sX5YwZIJbWni5nASdzNIkkXGhA6/LiPf8Aj+EyrUNZcIkRua2UVbPYB4cv8ywiNdIGE+N7wgGYfGssrCewa21Ejqbc8T3rcT8sHgd/isHWet5m6SLi/DMCMfevvcyZ1X6Mnzn0HyYCCn++qWtReR7HSZUY2194afZvoXfUkH9NGP6aTNK8Wt8Y2PLUo4L0w17oS279AL/Q19nhnbGUx4o6FmmcbofcPsyjPBMIZIzuEEUpX4WZUM+QsBlGy1elykORgizB4dWsVDqubKxuXosf7+9xDPV+r1OILVL4mHSbqGZdSBOmO2P5VJOc+1FC2eDJQ9NgR87vQUBzVkF3p44q7pmccpHymUP3umVQIwMenbIpAAX6XAnEiiDvPv9BGA1cRoSFptwoPhVPNt3vuzAwsWdwppAi+LUnPptrsfPdZAV rGKxorgZ xdkk8cF/mjQt/e4zZ7bFsJkMoPRza5SB6jjJ6sWGgwxLsFZQp6fCmnbUnNgQOVi1ZKhPHB9N178Xi+kee1KDTgoY39VohC6YJJ1SmKwgl8cuLJ+RNTXvbHsG7NN8A5CkvblR+IXI/eGamb1jnpOlKlTDcedmN3kOgUSuoJegnZmFHl8XVZDSZjcywOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 02:28:56PM +0100, Christoph Hellwig wrote: > + if (folio_test_hwpoison(folio) || > + (folio_test_large(folio) && > + folio_test_has_hwpoisoned(folio))) { I need to put in a helper for this. I'm seeing this pattern crop up in a few places and I don't like it.