From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE615C47422 for ; Fri, 26 Jan 2024 16:22:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F10CB6B009B; Fri, 26 Jan 2024 11:21:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E9A1F6B009F; Fri, 26 Jan 2024 11:21:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3C266B00A0; Fri, 26 Jan 2024 11:21:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BF5EA6B009B for ; Fri, 26 Jan 2024 11:21:59 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 895824025B for ; Fri, 26 Jan 2024 16:21:59 +0000 (UTC) X-FDA: 81721978758.01.AA0D255 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 682FF1A001F for ; Fri, 26 Jan 2024 16:21:57 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=L8Zuw8D+; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706286117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6Eq5PV0JObRglyH9Vv+nr1C+9HbTQJe9ICOwY4GJBso=; b=SzMVwwy5QFTlwxIa7KDp/dpptCzSQX5baYQDFxmiZ7rwbHvBFf2u5k/x53J1HKMrbo5/er 14xl3UP/KbHK115w4Eo91SRwZpIx8eaXx24LdDejKD+dr5HtekmPxL+CaYTsQ1eBOiV43j K8JenxJJtxV32uH/Ul3UxwY/FfG+yFI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=L8Zuw8D+; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706286117; a=rsa-sha256; cv=none; b=zPCaOE+L3ILVG8nizrCHl8Msjdkge/HA1G66U0ZFKYSmrDbTZqF9lkOOqtEfxAWKmP7V9i hpBDphszNoH9/3vF3gVVIv/0+UZtvP1Q/DVO7ScwlDXMMxUQQBR3HjHaa0Hs531VLaI5CW ++px0HOlZd+jOW87pHwAK6Cqj9DT9uY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6Eq5PV0JObRglyH9Vv+nr1C+9HbTQJe9ICOwY4GJBso=; b=L8Zuw8D+uOFKLKPcyh484x55+K c9IpxJJcx99wyvGmy0INiMJlC8QUlzZpTxH3hZfkf/K9FqvwUt6O0avTqf31U8TttnkvGJNLOGH8d C8mgSP+HZRn5xhApuA+xeK0/RaIvj0G1BNDH6sKwpseXhIhpPXEwl4/z5KqYeaMoQ9zcVL7iItJkg 5yAxl5FklBJwxE6f49vLYAhCk8y5xg+/CsEc79yOoJqaJMqZ4y1YkyyKd89JhOQQWOtY71ta1QfvR TxXJV777sXZPQ15QYTLf2//FxhOmacptfJZc7QAyIMIPed8YKkWQ0PjmDtFpvp2hq41Z2dhhwXfzk QBHtrHsQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTOxk-0000000E9Uw-2H7S; Fri, 26 Jan 2024 16:21:52 +0000 Date: Fri, 26 Jan 2024 16:21:52 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 09/21] xfs: remove the xfile_pread/pwrite APIs Message-ID: References: <20240126132903.2700077-1-hch@lst.de> <20240126132903.2700077-10-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240126132903.2700077-10-hch@lst.de> X-Rspamd-Queue-Id: 682FF1A001F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: bwsig4dmyg9whctih1smro9ehoxahaqe X-HE-Tag: 1706286117-294944 X-HE-Meta: U2FsdGVkX19QjDHwGuIGLYe2KSdfTZ59jhvStObK4hXyUmIgfCvtthTWYX9+0e7n/smF4tnJ+BVAXZo5avVUaImQ1CC9W7asI9xbDNfr3Ww3KEOL0kEToepDWWAL/FQ7pCOTHct4VOldC3KeqdM3Fv2oJmZtouo5xBmMjKybnAeEjj3DNvEWCMUBPlY5HX7OqtKKd0CsGpkJGtUShGifLmgzVGQiZ8YdSkg6tEtVutxMEOeDkLJB7PDWNand4VR2qTTuoR3GI6NXVbSs4UWoZ2eVL0/Zee8QmddTa/5cCJaeUHPlfBULaNujKhstK9X3LjH7/kza81iUP+At14WuU1+AWx4g/MKE0D/T7sJ5D76U7tdzwl3Fdvt0xa+ZkwDHeboWBBwsm0Rq17RPCMHpAjpMG5rpuhhxAAjzIVutLdcm8Ek5tQfJA6LfUzHx+0aPVRuBZf6ROz4ER647V1ki7zdHv8f7y4PflIhZBGX08t4rhfqA+Xs/vAZJK+ihTKqsQXQ+lkxhcoMoE43Qy0gC14cFUhZMqE/peyR99V9PBMGV0ClClNAdrshCzXSzq6QUI9eRyLHG9vrgEfLc02k24y0PSKl2ZWKe63KSS/GXcJVAqirpTNK1Z47gUUPkuUnQeshN0A0AtMqRHwopWveNhohAQ8JfYGOzxd1xrRauXQKbydXYGKvV4H27J9hljVjcB1oiHmCQlFqj5+gSKAM0OABlkIIHe2UuiLtmxy/RzpI7BAZLJcwKx6OrhoDnVfQrsO/HGfR+Dtdc4oEpf+gADfk3OqO+kxUjr4VYSaSNiTRerOTyf+ze+RuhfW9GQ2JqwNlU+Yb9msWSBKIzSoPeJu2FhvW41qKRZ1OiSwMkArFo6Vc8pPiiF5TC5Kt56KxH+MBt1nhx0zxg96W1Ag6kN32DJ+kewVT2O7EVD5gJgBcxvGchnJI0IlXQ45X1c4NHsKifazWg3SJJzUCuVzo qX2B9Sh0 vbWF/Deg/enn9SyKE2PwMeUxGHrN9YT/gUMWLZCYhnU0/DNGvTR/jvSUeAQxJRF8LSOemfbaKuPmLo6szz2fjMlTE/nB1zAoDunE1JJSdxOxIu4H71sC7iS1K8l1NADXyID10c6Ec4h1m7buFemRZcOCGxC7ER/K5ZvY1keBkJmHiaIXmNg25s8CI6Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 02:28:51PM +0100, Christoph Hellwig wrote: > +++ b/Documentation/filesystems/xfs/xfs-online-fsck-design.rst > @@ -1915,19 +1915,13 @@ four of those five higher level data structures. > The fifth use case is discussed in the :ref:`realtime summary ` case > study. > > -The most general storage interface supported by the xfile enables the reading > -and writing of arbitrary quantities of data at arbitrary offsets in the xfile. > -This capability is provided by ``xfile_pread`` and ``xfile_pwrite`` functions, > -which behave similarly to their userspace counterparts. > XFS is very record-based, which suggests that the ability to load and store > complete records is important. > To support these cases, a pair of ``xfile_obj_load`` and ``xfile_obj_store`` > -functions are provided to read and persist objects into an xfile. > -They are internally the same as pread and pwrite, except that they treat any > -error as an out of memory error. > +functions are provided to read and persist objects into an xfile that unlike > +the pread and pwrite system calls treat any error as an out of memory error. It's a bit weird to refer to the pread and pwrite system calls now. I'd just say: +functions are provided to read and persist objects into an xfile that +treat any error as an out of memory error. I wonder if we shouldn't also change: -Programmatic access (e.g. pread and pwrite) uses this mechanism. +Object load and store use this mechanism.