From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55157C47422 for ; Fri, 26 Jan 2024 15:09:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3E0C6B0082; Fri, 26 Jan 2024 10:09:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DEE196B0085; Fri, 26 Jan 2024 10:09:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDC7A6B0087; Fri, 26 Jan 2024 10:09:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ADED46B0082 for ; Fri, 26 Jan 2024 10:09:23 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2BCC5120FCB for ; Fri, 26 Jan 2024 15:09:23 +0000 (UTC) X-FDA: 81721795806.09.A099639 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id 7E83714002A for ; Fri, 26 Jan 2024 15:09:20 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="VADE/Az4"; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706281761; a=rsa-sha256; cv=none; b=1YHpGge3GwMsZx9XU+EVVRo5GlTH7Srjtnt1BH3mh0BH4edM+buR2NsKaJbEpi1e6cogOM JiXQhsDfxoWGrZi2YPDXO3emdWQmCMzpmdbinMDDQ+cqt1f5GwjCwuw/DYduuTqBRCgHNu qRW+UMS+TSfaljy6pIGN2LmuTUsGolw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="VADE/Az4"; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706281761; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8L0jm29tcG02zXNZ+/jR0wDkovkQ7cRxzzvSVHRCJek=; b=CGSat2zz8MT+2VB+GTLRqARFsIU99BmrEU56o6E0ZB3nhxh06qam+fysI3WdhxTzl6s9lv tVlJIIga6OYa3k/8PCvQZPxvSaONlM9ZU2Lw8n3LzyEPZ1ZbhA8xtDfUZ6DQdgE7Yip3qO 4JantAmsgiKTur4hFVsjlX9MM0yZ3wI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8L0jm29tcG02zXNZ+/jR0wDkovkQ7cRxzzvSVHRCJek=; b=VADE/Az43i7Ov/BojlhYvE8tGd 18BdkqrJHnXPK032ZK8eFlKh/u3dtcRQbik+1nv0ib5y+caBlUCQRHql9BXk2CbQz+ufEr8SmGus8 Lme6vMyme64vf8l95utyk/z93EX4ey9DdY7MYvCToHsXdbsdB2HAvy3cbXFPVeiPojXDGARQTSjrZ 9T0+5eYp1YpCJBjuxHK0FtUe8COwFchzyusH8MCgNu4EovmFbE+gGpOdScb1AA7YdURYdMfV4Qilp Q4dWkF6A7PxajAx6/IxU+GZrhr9hJb68WWAKQOGhOHcj/Gw696jByxQrBov2QONlZzEz3DAv8CG4J ZolU5JyQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTNpR-0000000DyYG-0kFu; Fri, 26 Jan 2024 15:09:13 +0000 Date: Fri, 26 Jan 2024 15:09:13 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 04/21] shmem: move the shmem_mapping assert into shmem_get_folio_gfp Message-ID: References: <20240126132903.2700077-1-hch@lst.de> <20240126132903.2700077-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240126132903.2700077-5-hch@lst.de> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7E83714002A X-Stat-Signature: njarrakoncpfxjhk19inwrq3xg3umghc X-Rspam-User: X-HE-Tag: 1706281760-326626 X-HE-Meta: U2FsdGVkX1/keXGBKbhE1J8ORQrOMPuz7LjiJgDV2q2ExQCmS6Roa/Nw9yLsbugC44m3NoOmzd5CpOangRGZX588QkOAyNh855ieVboOERUMqauN7b1505zdk+TycYD5qopRgPTkzdDoW3WJNYOcDK+OdYIxfXXAk6QEbIyoyFzUXMqhoyl00TznA2GbuHnoeMXRUyleubs+7yP8kjN4gR3XGHGUal+KeN5GgJAe75EYGq1mpHaXSZrvfEyNV4gnfGz09MVR51Op1GYLF5qvfIBWKGoTYTSxmmsdVjLs4aZCS2hI+9U5Trw77YoRKpVlylNU7ZJm02kdyL0kysgNfGi5sJg2qvjtRFFLH+Ddjg+8lG2noiCUOibd1+IUaLOm02BSPg1GLgbEIScGN31Q2Glk5PTWL5shTIK6TMbnRZYjhUauoIoE14sp8COOr3/h6LzbT3T7adh/Ia13nAJaiva/etq2oCgHFxW0CBL6+E9nBghIOOvF12YLG9lK6iGpXZc/G62Ri1WHVDHwdfTpl3fUb8dPSvokhmRBVA2OH/HHcr+gOjouesIUVIUB6dOYdf6laQ+EjzyGR1MNHmkWjJjc+c80P4jJTOfCXh9fvHLFC3plVEwZ5gWnbcNVN2D7uS0G0EXSj2PXdaXok7h+UlUivJCbV3GFgIvxp2oUaHVjN2NyFkVdztwjwzf1UdhyfC1U7IX0t7B3v6zKcCMqLt7XmrVKkiVB6Hek/gTlNOcUJ5SAXjsv78PeeetO4E7T0o1lLCc1bFlLFhis8c/9XfI58vssJgQqsuXmgwUDrzo6zlUAg1J5QtVuWe30LrTxcXgBLF8EI0wUs65sbKMP6Q011DjtZ8jVf9jFKR1qUhGDpyVYVKsQVd6AuRdzMAvYPyrz92gj6sT79vGgSWhC4u2tPFZ015Y4Y4OJuVY7OQtPlPtVcZh+Ii0WSjaqvoTZS/dxCPLrC7yXgke5A7V sETU2z9T ghe8qG6lQjZxw1G+8Zcbolk5QUt7qgz+9vTGc1asSIWCROf3wtd5TknAWSZl5De+mbh6IiOD3xQB3rB+GtnKY1WponqV9AXKlHjI5sOUcw+aP5yCgu2hKRo3BfRSFeZJqLVlTKiWdkFsQaAMqeDI+PQd60TRfs+GKFEdNbVDBwLGtcqi3b9DAnE9YOKKu4ymDkMg4PtJa0WVZUZj3c5t8owO27FxrIZiRu4/d6jrzjFfhiltAIv4+2akNyzMN005dxc4NUGle5B2o5nR72RJcM5BITcKCjGTIa1marOh5Fc74CNw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 02:28:46PM +0100, Christoph Hellwig wrote: > Move the check that the inode really is a shmemfs one from > shmem_read_folio_gfp to shmem_get_folio_gfp given that shmem_get_folio > can also be called from outside of shmem.c. Also turn it into a > WARN_ON_ONCE and error return instead of BUG_ON to be less severe. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Darrick J. Wong Reviewed-by: Matthew Wilcox (Oracle)