From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27C4CC47422 for ; Fri, 26 Jan 2024 14:24:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AB576B0088; Fri, 26 Jan 2024 09:24:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9347D6B0089; Fri, 26 Jan 2024 09:24:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D5DB6B008A; Fri, 26 Jan 2024 09:24:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6B9326B0088 for ; Fri, 26 Jan 2024 09:24:27 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3FF841A08CE for ; Fri, 26 Jan 2024 14:24:27 +0000 (UTC) X-FDA: 81721682574.03.C2CA3F7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 927981C0017 for ; Fri, 26 Jan 2024 14:24:25 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="VVOh/LiY"; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706279065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f1w4U8mqf5nN23ca0l43hojotOzXL6u5NlkdrKkG3gw=; b=F5NWYK3I0tXBQVt8tov+cokhLz8yB04Xj1pvbgcXqkubkzpUN9KtttyyQORZpxeLF/bc/0 Nbn6lGD743mSTTermANURvGL3TOPymvbPT2vJ0WwcwwNLbcaMQZm3wVIYCg4PfZ1tfgDoD Wdz4qDMdMLinQkOqOpeb8dgPkDTZ12I= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="VVOh/LiY"; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706279065; a=rsa-sha256; cv=none; b=ZclhfvHa2ert6+IFrzjLTKUDUrkeaEkRuEqQRxZvo28fTlO1Tv38nwABr/JFied6ShJxoL RF2yBO9vv71T6+R3bxMOD9U/Zw3NvyF3RaPakzB7mU7c0Z3/DrWNJUG+epg4phNl3pgF7x py2i9HPEcLkdZsM/ATK7cjvwVSRJs4E= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=f1w4U8mqf5nN23ca0l43hojotOzXL6u5NlkdrKkG3gw=; b=VVOh/LiYV98n4HUSTPi8VsF4qQ y0vRCN8/8/69YP57BXK6QxuDC2d+zcK5H1cFIUikmoTP/GT5pyZ4Tl3KaJKSMSKUG4naRe58ndi1d VFdb5Er50Vv254B7SACCIaOKkxYVVqz9XqFO0ORQsACCl7xfa5SbMmt9MD44ew6XxxqRcKGHdqUBG 3swmjLp8DM+ut0Wbvo0CdiSdGxxY8RNKN6acQutLcpDFW8xQDtr0NkIJ/AZm4o6uycyangmnZu7Dw tWvk3uqEBnxm2wWCTN6hWUcWczTHGItHBXJKZFv6Hbsc2gEBnGnzMiMrfz2a4lhXUz3+z3P74efrC igRgdXMQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTN7s-0000000DqpP-3S99; Fri, 26 Jan 2024 14:24:12 +0000 Date: Fri, 26 Jan 2024 14:24:12 +0000 From: Matthew Wilcox To: "zhaoyang.huang" Cc: Andrew Morton , Jens Axboe , Yu Zhao , Damien Le Moal , Niklas Cassel , "Martin K . Petersen" , Hannes Reinecke , Linus Walleij , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com Subject: Re: [PATCHv4 1/1] block: introduce content activity based ioprio Message-ID: References: <20240126120800.3410349-1-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240126120800.3410349-1-zhaoyang.huang@unisoc.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 927981C0017 X-Stat-Signature: gora9e9wrwdpod1jg9xt6q8ytoriixyi X-Rspam-User: X-HE-Tag: 1706279065-835384 X-HE-Meta: U2FsdGVkX1/NF2NX28ikiyktY02fZosZCUtEWtXldNpFlqV4GVMMYX2h0emCdqJDRzWUKJy+r+9FhI8mno36RLzLlti+ht8+I7dLZzufOtWLq1Kved9GmQO+vxKtKpF5uPz2fe4gM+FZFryI+K/9MXGrDvdTqcPBNAsmJJI2PVn7OTtj6hx6dA2hw/Bez+xfwyv8N9eeEOxAbIwjRwmDwHZh1X0KTKhKzw36LMYdrClWwtxK1a467cZjszbsYwzG2Tptiga7MQ4B2fjjEMCAHrpODp6aCrOlXqjpTBq05P/NJSqDsTgPOOu0J4clqFPfwWClUCOmTfCMv7Y7L3Wr3F9CFg17sprvAEKVPEHt9DlY6sidegJ0hUWEKyEYf5PksDI5JgfeiEw0R0oBPIKElfKgwAkEtj7Yzh/Np43xxo3MaYPu0zuIjWPCNVu2nkmjDMJJdFoi7L0Q5xCW8coTMtVvbPxdRA0R8ra+bINac6ViLgP8X+z7NlwbsUulYsNAB5w8kzS1i/fIPCA4oNPqPg69avTM6xZXitRTE8BtQSql5QiOrsLTBcXSDLXnH1EMmNPEtxfMLiWACsrkuAX2aAabkFwG5Gt4/n8arr/On2GdhgWb6phjoYP18zKlQ2ica4eSpsjxUO45S9AQWfzm7dA247cltLsLdYzglZehLR1XQmdtfKPtI6ltSgZjDN/A1BpCbNnBlP2z/Cxyym2xBRq3Tc1RAw9nST1/Js3BNd6CnXUfLBBFagkhN2v3cloVRbVGm/jugEUGYPrzHaQ8KwmiGOeWoDZ91XRd+P+dLM1U/Hq2RzcP2hFxwpIaZ38t8vRAcCowBRRhHWea2FLqtZ1AdqK6/9mJ8Py9rpmq0HllsUI077rmy085Ilc+aIIVg2BvgjlQa43Z/G3zoA67ORW/xgeR9qr+D8pJF5madxwnUfxsOz+2CHlPz9LoieRnwEyMn0zYRSD5bPrgJS/ SZJ7xROK NkF8NhMYTlr4xXvgZgbDnhtoS9Y/2Xr6mB+Cj6p4PQYT5g+KKLuGXUauM5WeGPUWUr2wcCklsKbeCLap1FlRYEdL6E9qxOcVcHqw+d72bAI9bH+bNKyOzpxUGcV5+oslTIUby73VRfejCwMM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 08:08:00PM +0800, zhaoyang.huang wrote: > +#ifdef CONFIG_CONTENT_ACT_BASED_IOPRIO > +#define bio_add_page(bio, page, len, offset) \ > + ({ \ > + int class, level, hint, activity; \ > + int ret = 0; \ > + ret = bio_add_page(bio, page, len, offset); \ > + if (ret > 0) { \ > + class = IOPRIO_PRIO_CLASS(bio->bi_ioprio); \ > + level = IOPRIO_PRIO_LEVEL(bio->bi_ioprio); \ > + hint = IOPRIO_PRIO_HINT(bio->bi_ioprio); \ > + activity = IOPRIO_PRIO_ACTIVITY(bio->bi_ioprio); \ > + activity += (bio->bi_vcnt + 1 <= IOPRIO_NR_ACTIVITY && \ > + PageWorkingset(&folio->page)) ? 1 : 0; \ I know you didn't even compile this version. More importantly, conceptually it doesn't work. All kinds of pages get added to bios, and not all of them are file/anon pages. That PageWorkingset bit might well be reused for other purposes. Only the caller knows if this is file/anon memory. You can't do this here.