From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67E8FC47422 for ; Fri, 26 Jan 2024 08:55:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEA9A8D0009; Fri, 26 Jan 2024 03:55:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D72548D0002; Fri, 26 Jan 2024 03:55:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BED1C8D0009; Fri, 26 Jan 2024 03:55:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A95888D0002 for ; Fri, 26 Jan 2024 03:55:54 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7F12D1C1139 for ; Fri, 26 Jan 2024 08:55:54 +0000 (UTC) X-FDA: 81720854628.22.9D2A8E8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 38B711C000E for ; Fri, 26 Jan 2024 08:55:51 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=I50x5DUB; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706259353; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w+WMrLX5s3l3LT1bHKgCUnIIP0Rpbnm0jHmPYs4Fo3Q=; b=eOIaXa3zIsKfSZn1UVZ32gGEyL4FSZTH+rIp1+9sF16C2wSwfOIyyZCzqKwEqIuyMZjh4i YhaVQrRHSj/mUOHaz0egtgaEMt6JFyD0bHvgBaMcqse1yKlewAQywbeF9WlUuGGKzUpjGQ nridjWAE3KtWRBlqqm1trID2fj1kciU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=I50x5DUB; dmarc=none; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706259353; a=rsa-sha256; cv=none; b=brNTZz3WqdPbgwAeYQfACwz/D7q64h0WxlMPzy2zSqFNDGwzKFVt3m3f9zA6EBN/e4WRGG HoPQJqSq1UmW5RZ8eUYv8p1bc9NirYRuNeviXcWby4WshyE7cV0BxVnkVe53uAOTjZe2nB CDNS8YwspysppmlOoqGT/na9uG0lltU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=w+WMrLX5s3l3LT1bHKgCUnIIP0Rpbnm0jHmPYs4Fo3Q=; b=I50x5DUB0iXrrBxqdgS8P0PHwi s74eVAhOimTyTvGGWDNpVo2N9YkJBqwBDCz5RIAWU9pPr2hAs6DJHwQqu4jnTOIpYcyeen5qbI4WJ jbKOmxbKoaLGS4iXcdf1Y3/asNY3wfc3FLgOk8YBxQsdabvJMKo+6qnBG3NaM/yN2nE8wHKPD7FNR nuiOzGP0mYvr/Jn+Czdn7WyS9RqzX2IPY2B5ONEhHAT/vFBf6mdfqF96R1j+erGYbaWcUioDyA4eA v/RKELBLqemXTmbhLPK5Zt4Zgrhr56p2X5WWmtjv9iBH7z2aLk/ZPX4mm8mFXvpvk509gr5K4tXdN 9kfhfLTA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTHzs-0000000D5AA-0t0T; Fri, 26 Jan 2024 08:55:36 +0000 Date: Fri, 26 Jan 2024 08:55:36 +0000 From: Matthew Wilcox To: Zhaoyang Huang Cc: "zhaoyang.huang" , Alexander Viro , Christian Brauner , linux-fsdevel@vger.kernel.org, Andrew Morton , Jens Axboe , Yu Zhao , Damien Le Moal , Niklas Cassel , "Martin K . Petersen" , Hannes Reinecke , Linus Walleij , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, steve.kang@unisoc.com Subject: Re: [PATCHv3 1/1] block: introduce content activity based ioprio Message-ID: References: <20240125071901.3223188-1-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 38B711C000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ezc5t55isnachr4n34r5pw99smipzpg5 X-HE-Tag: 1706259351-857659 X-HE-Meta: U2FsdGVkX191r0HOc3CwkDVSsBJnAY/6+rj9rvI3WD8RcTZf77xTm8fGfD/guCXBYFeWnwNXVvBuhDJ/8BK+M0p865LymrSPujcnpdW04m6HnzqzPUuxQNd70/BZibZuHpVzl2AcfR9s6cn7nrsA/fihnh+wJ7qOQOyGGXb5d3jVIaYigaRLLUVszGA2BiMppYrRxqiK7fi36z75nJGCHh9t34hU84Ba05blO1TsN7oM1+MstQHgCNHe44ZsL1g+N2Maoht/hFoWasL3tWnnM6ou4Y85COEg9XtTFGTmWfBpQuZVIyirfx1hy5zu5qSv0DKstz64Ujtyicmw3L7j6BVHnl3iSYwi6n5SmOKSt0ldzwrsQ9cXcvGrFck+W6R5Li/Q1J9T4b3QRCSnZXoX5KBLRHf61sUltXQjBbjd1jI7oBnyK0+mD+Glqy4x3kPFf5Y0j5o8qeUuVNUVn9dh8G/Vs04wnoHIh1mMq/AZmm9Ep6C1cWff/myERq6J6/CMJ1fGZEdEkCKjaTQ7gDID2EpfpLEhSWcsFf46vGkgi7uVWbYuAG4BrfnKiQRUNc3S8b9ze+o868Id85OqaqFBsc9a2wy0bAzrTKDF6gInq1FJ8YSMkWxMoHOsbE/uWZBkm6D2Yu3GOxV5u3WofvxZG1Ex8FPouRECwlD6yaU49/yqXYvoggIbtxqzEo8FdSUhPdyu4+lqYwUBSXhImoi/lkGbglXWk4ZqJbx29LD+UwIAArbJPtCK0kGrFNV3mahyjbNcWnm5tJ88PiKZeYJFxUfxen3IaMS3R8upqoAK8ljuU9vmdX2TaiPVqyOa6mh5F7/nrciLhF97yLJy6Op0tQrJO2QrL4Zz1E2exdoVqGv9wgcANOzbyfmCzx9lPd73UsZvuZf570zActyWQ2ERD3qqJGDNz19N5D90sJoKc1gyOwkb069KvSoYId2wXt18tk9H0Fei+u8KmOhmFia /VqRxjj+ mZtKkbA0raT1jUWi77x3Kq2+/yTjVvuYIVcz28mAtJHBtHfCq0AjANtnAA0W9Jc8hLBW6e2NyBBIaQDsv34kIvbySxmgxX7Eo2b86drOgA1qRegB8MqTOMxidJIAa7HHWwzOdfbpVijBZjyE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 03:59:48PM +0800, Zhaoyang Huang wrote: > loop more mm and fs guys for more comments I agree with everything Damien said. But also ... > > +bool BIO_ADD_FOLIO(struct bio *bio, struct folio *folio, size_t len, > > + size_t off) You don't add any users of these functions. It's hard to assess whether this is the right API when there are no example users. > > + activity += (bio->bi_vcnt + 1 <= IOPRIO_NR_ACTIVITY && > > + PageWorkingset(&folio->page)) ? 1 : 0; folio_test_workingset(). > > + return bio_add_page(bio, &folio->page, len, off) > 0; bio_add_folio(). > > +int BIO_ADD_PAGE(struct bio *bio, struct page *page, > > + unsigned int len, unsigned int offset) > > +{ > > + int class, level, hint, activity; > > + > > + if (bio_add_page(bio, page, len, offset) > 0) { > > + class = IOPRIO_PRIO_CLASS(bio->bi_ioprio); > > + level = IOPRIO_PRIO_LEVEL(bio->bi_ioprio); > > + hint = IOPRIO_PRIO_HINT(bio->bi_ioprio); > > + activity = IOPRIO_PRIO_ACTIVITY(bio->bi_ioprio); > > + activity += (bio->bi_vcnt <= IOPRIO_NR_ACTIVITY && PageWorkingset(page)) ? 1 : 0; > > + bio->bi_ioprio = IOPRIO_PRIO_VALUE_ACTIVITY(class, level, hint, activity); > > + } why are BIO_ADD_PAGE and BIO_ADD_FOLIO so very different from each other? > > static __always_inline __u16 ioprio_value(int prioclass, int priolevel, > > - int priohint) > > + int priohint) why did you change this whitespace? > > { > > if (IOPRIO_BAD_VALUE(prioclass, IOPRIO_NR_CLASSES) || > > - IOPRIO_BAD_VALUE(priolevel, IOPRIO_NR_LEVELS) || > > - IOPRIO_BAD_VALUE(priohint, IOPRIO_NR_HINTS)) > > + IOPRIO_BAD_VALUE(priolevel, IOPRIO_NR_LEVELS) || > > + IOPRIO_BAD_VALUE(priohint, IOPRIO_NR_HINTS)) ditto > > return IOPRIO_CLASS_INVALID << IOPRIO_CLASS_SHIFT; > > > > return (prioclass << IOPRIO_CLASS_SHIFT) | > > (priohint << IOPRIO_HINT_SHIFT) | priolevel; > > } > > - more gratuitous whitespace change