From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E25A0C47258 for ; Thu, 25 Jan 2024 18:12:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66DEE6B008A; Thu, 25 Jan 2024 13:12:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 61E496B008C; Thu, 25 Jan 2024 13:12:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BE5A6B0092; Thu, 25 Jan 2024 13:12:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3D2896B008A for ; Thu, 25 Jan 2024 13:12:24 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0B7DFC0E5C for ; Thu, 25 Jan 2024 18:12:24 +0000 (UTC) X-FDA: 81718628208.20.A717A31 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf24.hostedemail.com (Postfix) with ESMTP id 22B3318000A for ; Thu, 25 Jan 2024 18:12:21 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=nA15u+2n; dmarc=none; spf=pass (imf24.hostedemail.com: domain of debug@rivosinc.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706206342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oOQ7PY5RMwdW49c44PeUD39W3uvEolKYcNoKx9tZHuc=; b=l8mXHeJONk2qP4f29CT2VG+Ic1GJ0WHUID0/7wftMEwL+8/CdHAkzcsAriuUUwDUHZ8gTe tK8ULWW/TMXCAs+MVQbGRlAFKD+bOZScipO7g5V96eD8okJj7HjV3JchoGX0vzMPH6mfrZ 9ZwDt/bJw3QYzTTffSYoisUCRsP4isY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=nA15u+2n; dmarc=none; spf=pass (imf24.hostedemail.com: domain of debug@rivosinc.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706206342; a=rsa-sha256; cv=none; b=TKAPWOJxW1YPFpDbG+HoPddkqF+qhfLit3l9eRIwxjtWixKEkNhRwKUg87Lvr08Nzyd4TZ 4iTGw1v5Mejr3Ut9lB0dXx07T2ukVmhdIpKFaitOmXLNzWaODA0pHVHCYoCF32gLPXtjVp GIspikDsjhzw8uXXUBtaiRvlWLMUZYg= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6db9e52bbccso4489120b3a.3 for ; Thu, 25 Jan 2024 10:12:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1706206341; x=1706811141; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oOQ7PY5RMwdW49c44PeUD39W3uvEolKYcNoKx9tZHuc=; b=nA15u+2nLDwPMtXEJ8Q6FyrhqM93SYqKsdHlD19u9AKXwqWhEDiOCdIM5G3JDoKKeU lSzk5l+nHTa3fwRmOmr5/WQVpt15NL8IRCu6bNziN9j34VCqZBaASV9huXeLecG/iJgC vybrSNhZlJtkyZq14RwKmsStDU2yWggeZpeg/bYFHp3KlNvugBlVWrbujqGkxdtKsKHC gKi3O7AnYQlwkuzwqhJVSx39EJPES079c00ppqq6W1DEF8AxlCL+6ZlewYD0gJdBebMr byY5m7pULHBJfbGfDW9v1f3Y5LHJw8MMECZXtggSh8ZQTWZSb6Urxa6JXScGA7GgpB3q xu2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706206341; x=1706811141; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oOQ7PY5RMwdW49c44PeUD39W3uvEolKYcNoKx9tZHuc=; b=PT83wZ7Pcn24KMKhsYqtQlk/2OzCARACCnLq2GExW7J9zn3oPlejARBcsGuc0taKSp TaRyLEghDZH8luPc/zJhQNrikdP9a0bgab9qOVd3Wj/Uvv1BA4mpkykbbNkT8zzRG49u Gk5oi7b+775ADIfH19+tS87UXJYG1sGyRmbw4yEKQ4jTDAr85li/2AK9tud3Cl+STlBp DhE3v0tQFm7z2XvNyWIOJBWq/8fvXGlWRVZ84k6Tb5sZUSDFLA3eHPA2ZtllQACHx4WC Nlm9+Dh1lmd8QPqxwLtgB3JRWS8sJ8dZElNEtjJI667p/45SJFSpXItGgBSjkohxF9bv y3jQ== X-Gm-Message-State: AOJu0Yx4Afg3Hd1g/+TYxkUDZ9Kz7jnYe9SHOjF5KDiLtyGz6rTMGm1Q qC5ENEcDJItfiZjv380ohXUP0ZQmht5v7OiBq+d6F3wwLlzy02op7NNs4U5BKg4= X-Google-Smtp-Source: AGHT+IGPUyyPX5hM1Yrkm5iskfPCqBeEPRsk5d1X3OtxSMKWSiBaRZNyP6s8gkZ7PqF+fErCTpo4Gg== X-Received: by 2002:a17:902:b284:b0:1d4:2d8d:3536 with SMTP id u4-20020a170902b28400b001d42d8d3536mr91755plr.71.1706206340832; Thu, 25 Jan 2024 10:12:20 -0800 (PST) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id jy13-20020a17090342cd00b001d720fa139fsm10390442plb.70.2024.01.25.10.12.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 10:12:20 -0800 (PST) Date: Thu, 25 Jan 2024 10:12:16 -0800 From: Deepak Gupta To: Conor Dooley Cc: rick.p.edgecombe@intel.com, broonie@kernel.org, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, ajones@ventanamicro.com, paul.walmsley@sifive.com, palmer@dabbelt.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, alex@ghiti.fr, bjorn@rivosinc.com, alexghiti@rivosinc.com, corbet@lwn.net, aou@eecs.berkeley.edu, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, shuah@kernel.org, brauner@kernel.org, guoren@kernel.org, samitolvanen@google.com, evan@rivosinc.com, xiao.w.wang@intel.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, waylingii@gmail.com, greentime.hu@sifive.com, heiko@sntech.de, jszhang@kernel.org, shikemeng@huaweicloud.com, david@redhat.com, charlie@rivosinc.com, panqinglin2020@iscas.ac.cn, willy@infradead.org, vincent.chen@sifive.com, andy.chiu@sifive.com, gerg@kernel.org, jeeheng.sia@starfivetech.com, mason.huo@starfivetech.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bhe@redhat.com, chenjiahao16@huawei.com, ruscur@russell.cc, bgray@linux.ibm.com, alx@kernel.org, baruch@tkos.co.il, zhangqing@loongson.cn, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, joey.gouly@arm.com, shr@devkernel.io, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [RFC PATCH v1 24/28] riscv: select config for shadow stack and landing pad instr support Message-ID: References: <20240125062739.1339782-1-debug@rivosinc.com> <20240125062739.1339782-25-debug@rivosinc.com> <20240125-snitch-boogieman-5b4a0b142e61@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20240125-snitch-boogieman-5b4a0b142e61@spud> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 22B3318000A X-Stat-Signature: ussabubw5pewfqtag9191t1wokmj3fgd X-HE-Tag: 1706206341-282204 X-HE-Meta: U2FsdGVkX1+6NB/JGlVC5qDFj0O/8QLvba9+a9BsfTqvZWnxPPPZ3eT8lAF64cpPjYJDFSQgGxQtfRnae4TU2eqahPPYjkD+1c4E7mI08dQN44/hnW2KGff2FHc7ei4ALiz4tMy0e3l6kufhsk07HE+5byFrZ9sMs2PoVzTgGglvCKTOTiXjCM5CooLxk4VYdmZvzNABm8cqKwnlI3zZsG3ANOnDitPOWg2gB0IABdVTVsP/4LMc4HBEMT5ItbHBKpZTDZCP/AZ/NVp8GeVYBr+CSpqrO5gFvxbyxxreLz+eutm70kMM4NHe1Snl+Jo+J3GAWuywJI/6IoOMqFascLDjirxzYQRXU6a5TTHASvr1mDBf8C25AwQ4eO17a3rucphfHuokE6+T+ZCaxsHFNRclbfAYLmKbQvUc2zMRqvAZUs1k3Lz+AUYWfmp1u9WqbSWGWsk2pjzjlfFbVQiUpXoiu8vF1FN2SPXCn/plqon3ChRAZ/KicPL9Gb791ADKFJhjewIJ4fQelH2dYnOr7r5OqmAwXqfGYbFLeYjWvqf69i/EdOaX/1GTlYt1YjBHoOfFj8Qsczr9/t+quHAZ+afkGeY5en+B697w/NsIMPjfv0r77y3LcBpQB033R8RGi1cTVwIUwFhUfIrHgGLbqaTVkQ99xCOIGdTFz2ILzjGF6f8CI/gKD9SeYahHWIYF4cXvLNx5VnGi4x7qy3Mbc08vKr3ep+THjizGSdqBjnilJKZT0GXbFYjwl7gsUKaaLFPFuYmd/RKMXuwNCcSJDqLfJCAdZbkSdylMPFBVUKE2Pvynh2/XoxxQTAwXmDqcCXbOiLeYV8+fNPMYN9WI+Sho6R4FBkGRseiFzIzPLgQsGwU2egRFx6Jxjm+VldhsZ2D7jvsNzltHa2q2cHEl/A8EfHtqroM+2nC2bXRNl9+mJHKMMxHHUmAYUXGDY9xV1QlVIluBrDURUJsx/rX /HKZUrin m5uZzNklLrF1y/revddETFdULHcx98fgPF1ibwXV+/LmoHZopoPMfWFLTKKxPyMt1TdwH4gBjCVkWwS7FN2aCOb+2hEvvEcWg/jkqWeR8Loj95x81WWYtLGcDjf41wZQBsTH90VXWxoCvDJ8l+oZSJrrJ5M/7tvyqo8zKT4SKIs305YwLQmxSWzsXzKyOgnrDRnn0o9x8ZhBpn5qd4zWmWJj5jHB1+VCsa24RuC5hCwYF80BPrdC0nFX1ldgNcXEJOBaP+d8nLtUj81e5vlkeZR1vvCh6A7cypm+JAMU1zeQwG2EOMM4XRLyZT0bsxKfTnI9wRkQLmQPc+m45EVxyW3t6n1cVlQKRnKrYx3ofcc6FMXbontdNOunD+lBUVGUc9AY4Dp4B0joxKGEsfboVaVu2+iNEufP75VHDe6mdXHVRsYKEWIp0V3Sh6QyYnFHEJY/giy/dWIBO0ooi/W5rRmwuK4pFfjKClbjZx1xR8RPfwhs3HG0axuR1CezjhmSUOiFryFTFpNsZ+tAfCqLRmGTWIZ8BVHO+1qma X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 25, 2024 at 06:04:26PM +0000, Conor Dooley wrote: >On Wed, Jan 24, 2024 at 10:21:49PM -0800, debug@rivosinc.com wrote: >> From: Deepak Gupta >> >> This patch selects config shadow stack support and landing pad instr >> support. Shadow stack support and landing instr support is hidden behind >> `CONFIG_RISCV_USER_CFI`. Selecting `CONFIG_RISCV_USER_CFI` wires up path >> to enumerate CPU support and if cpu support exists, kernel will support >> cpu assisted user mode cfi. >> >> Signed-off-by: Deepak Gupta >> --- >> arch/riscv/Kconfig | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig >> index 9d386e9edc45..437b2f9abf3e 100644 >> --- a/arch/riscv/Kconfig >> +++ b/arch/riscv/Kconfig >> @@ -163,6 +163,7 @@ config RISCV >> select SYSCTL_EXCEPTION_TRACE >> select THREAD_INFO_IN_TASK >> select TRACE_IRQFLAGS_SUPPORT >> + select RISCV_USER_CFI > >This select makes no sense to me, it will unconditionally enable >RISCV_USER_CFI. I don't think that that is your intent, since you have a >detailed option below that allows the user to turn it on or off. > >If you remove it, the commit message will need to change too FYI. > Selecting this config puts support in Kernel so that it can run tasks who wants to enable hardware assisted control flow integrity for themselves. But apps still always need to optin using `prctls`. Those prctls are stubs and return EINVAL when this config is not selected. Not selecting this config means, kernel will not support enabling this feature for user mode. I'll edit commit message to better reflect this. >Thanks, >Conor. > >> select UACCESS_MEMCPY if !MMU >> select ZONE_DMA32 if 64BIT >> >> @@ -182,6 +183,20 @@ config HAVE_SHADOW_CALL_STACK >> # https://github.com/riscv-non-isa/riscv-elf-psabi-doc/commit/a484e843e6eeb51f0cb7b8819e50da6d2444d769 >> depends on $(ld-option,--no-relax-gp) >> >> +config RISCV_USER_CFI >> + bool "riscv userspace control flow integrity" >> + help >> + Provides CPU assisted control flow integrity to userspace tasks. >> + Control flow integrity is provided by implementing shadow stack for >> + backward edge and indirect branch tracking for forward edge in program. >> + Shadow stack protection is a hardware feature that detects function >> + return address corruption. This helps mitigate ROP attacks. >> + Indirect branch tracking enforces that all indirect branches must land >> + on a landing pad instruction else CPU will fault. This mitigates against >> + JOP / COP attacks. Applications must be enabled to use it, and old user- >> + space does not get protection "for free". >> + default y >> + >> config ARCH_MMAP_RND_BITS_MIN >> default 18 if 64BIT >> default 8 >> -- >> 2.43.0 >> >> >> _______________________________________________ >> linux-riscv mailing list >> linux-riscv@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-riscv