From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E090C47258 for ; Thu, 25 Jan 2024 17:05:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C57FC8D0005; Thu, 25 Jan 2024 12:05:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C2F758D0002; Thu, 25 Jan 2024 12:05:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACFDE8D0005; Thu, 25 Jan 2024 12:05:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9B32A8D0002 for ; Thu, 25 Jan 2024 12:05:10 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 597401C0B6B for ; Thu, 25 Jan 2024 17:05:10 +0000 (UTC) X-FDA: 81718458780.13.94247F7 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf24.hostedemail.com (Postfix) with ESMTP id 1072B180003 for ; Thu, 25 Jan 2024 17:05:06 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=kadb4CLI; dmarc=none; spf=pass (imf24.hostedemail.com: domain of debug@rivosinc.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706202307; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0M1FGpzVNcThtLlc0xGfB6RVNT85al2FAnsQAblSAe0=; b=a5vpLaqa60sdH/0owxyOo6SaezblC3IQk/trp/HSBcnOohK3beziQKRznxswlvbwBE6PXh e5eKAbBJS9RTUuiJ4IdUf8RwH7XQncOvCnuVzrIqNK7WJVsKNTDGNSgIJfYl/gI/q2n6tu s1XICNk9CnRxHSru4J7BDlad0nFXYEc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=kadb4CLI; dmarc=none; spf=pass (imf24.hostedemail.com: domain of debug@rivosinc.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706202307; a=rsa-sha256; cv=none; b=rDcnPpqWi8na+I2jtjs3og0UH4PJJ3aGQTsJhssYQDDpySaYnNIu6VEgfAhCRAMTGLTRqR VEUC2GBgXTotp61hwFb8cuf8goRZqwIsQ/4f9hZDymiJhEEYwzgOq+kVx4sJMAwymBWQS4 GeAgCM6DpIBGD1cQ1QgMP/TjaL+EZIU= Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6daa89a6452so5091856b3a.2 for ; Thu, 25 Jan 2024 09:05:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1706202306; x=1706807106; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0M1FGpzVNcThtLlc0xGfB6RVNT85al2FAnsQAblSAe0=; b=kadb4CLIOrVPANoI3lUmY9i9PEUV/fnemmjjG+DYt5y3UM6G1psZD4kl5Az8/60zUi ++1BCY17bEJRmt3++XhLUGLgRExqbz58lCUmpxwv/51W0uviRurGOVDGnNT/xJ+t8z7A JeJhnj/kA/JsV6GV4nORZguHzOILzfQ1WAuhIs4n+aV05kkbTUSplcFuOHHKJfO6XxxN HwBwhNY3/zHbr0JvL3XOM1K0icFmotNiDjaOeEiRt0OWEUitgN95ySUnP2nARMMRaLhi KjSJeaiLZqJ49I3gqM35AtMwKZibtwN8Agjd433hbuN5P3OwVUWV7JQx7xpS8vD5crZq AU9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706202306; x=1706807106; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0M1FGpzVNcThtLlc0xGfB6RVNT85al2FAnsQAblSAe0=; b=CJhpZJxLWlvAcTx0sA+5gjuGe3Xcsowhj1UiN2otHJnYZDPSF2+eJpZ8ywL/0Vk/me qkLjYc5/+162FHYfIREciEiGJk8Iq7DkoxaDzsEuqTPQhfdae9XJp+rgALj+0K3Pyt1X X01HFb8XiwmWJQF9ej7YedvNrRzAFqLYjbSUQfDwtCh9TIp6nHFo86oQ6ZI+qRxfFa0W Enb/hmE+RnuBe+zsw7RSGjvZA0CGzSlBjemlp6xAKyHu9Dq0xOfCzd7CnTAuiR/Ehrru qW1xMvLUjRiEUm0MxZ/KdCejuW1yfliXG76u3gaJkZ5rZPcSk+omDrOuOupuO1XVQvK3 fSZg== X-Gm-Message-State: AOJu0YzyQ9RTxRmqv6PNh0I1TtcceQTSQ3TVFGwC5kFlgwWxVvgG6ggP K09HGjVqnB1YZtZs2k8iWipGZIRJWOX/GJvNu/hTHd4WDmQOsndmcJv+6H/X50A= X-Google-Smtp-Source: AGHT+IGut0SQXr9AbScsdtYRLtI9Q1u0TcXDVvdxEucMFGumMjEZ81k2C95PoDlDDNCwCXrQvmnyWA== X-Received: by 2002:a05:6a00:1a8a:b0:6dd:892f:e2a6 with SMTP id e10-20020a056a001a8a00b006dd892fe2a6mr2044pfv.23.1706202305670; Thu, 25 Jan 2024 09:05:05 -0800 (PST) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id s19-20020a056a0008d300b006d9a6039745sm16078660pfu.40.2024.01.25.09.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 09:05:05 -0800 (PST) Date: Thu, 25 Jan 2024 09:05:01 -0800 From: Deepak Gupta To: David Hildenbrand Cc: rick.p.edgecombe@intel.com, broonie@kernel.org, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, ajones@ventanamicro.com, paul.walmsley@sifive.com, palmer@dabbelt.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, alex@ghiti.fr, bjorn@rivosinc.com, alexghiti@rivosinc.com, corbet@lwn.net, aou@eecs.berkeley.edu, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, shuah@kernel.org, brauner@kernel.org, guoren@kernel.org, samitolvanen@google.com, evan@rivosinc.com, xiao.w.wang@intel.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, waylingii@gmail.com, greentime.hu@sifive.com, heiko@sntech.de, jszhang@kernel.org, shikemeng@huaweicloud.com, charlie@rivosinc.com, panqinglin2020@iscas.ac.cn, willy@infradead.org, vincent.chen@sifive.com, andy.chiu@sifive.com, gerg@kernel.org, jeeheng.sia@starfivetech.com, mason.huo@starfivetech.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bhe@redhat.com, chenjiahao16@huawei.com, ruscur@russell.cc, bgray@linux.ibm.com, alx@kernel.org, baruch@tkos.co.il, zhangqing@loongson.cn, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, joey.gouly@arm.com, shr@devkernel.io, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [RFC PATCH v1 08/28] mm: Define VM_SHADOW_STACK for RISC-V Message-ID: References: <20240125062739.1339782-1-debug@rivosinc.com> <20240125062739.1339782-9-debug@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 1072B180003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 3j6erd5n4rme7fdg5gy4w34ddpd9umx7 X-HE-Tag: 1706202306-768313 X-HE-Meta: U2FsdGVkX18gLc9w6Bzeyph6rog43df5Ddh614N7OhxQpjcRGrVVu64kzThwoiyJbtq+XwNCQPXu5WL9/urk0V8VJ1/Yfg/ZylwbraFeWlynX1yVNuIY6mLE8hLMRq9naB78s4trXE2pYS/nV1OR0iIfhrQDMMdtf9O6OKONe6GezW/q/L34V6sYhHD/0llsm2mQDZzHhFJLikxT9EWmaYGBuDX27QZPinao/sY9TOcIqApV9fTYqzUAe4T9h/fJAJozDFw+1GC3YSg9aqIas6GWpJIiOE6zhPMftDc2qLtiS6l23GYiVFwx2uT8ljddcBIIVSAKHS6kktHg4b12bTz7lcGmcLwKQ7lj72C+HykoDgk/L144Jl5JCruCUcuTw2I1xGBZUXgagpGt0Mu8VqjrO28g2m5Rq7pU6uaBeOluAAd7GI5kZE5T917bQ3U/kZ/1hL/1CgRC86Y6iS/ENk/OTCuzVk77MgoO0x3C7JhfKecoXBx1IUN52hsmV7akaNkCksIrM4ZKuinJThYFM7NXUdyh1tXiLhEr3kbM3NULOSEVHIJ1qS8MKLssc9343dlXsT+r7vCzVy8HBEfYXZ2LAsjiQhUsGYXSikG0L7gVYax6m63CJl8LLdbCs3LZHAfJggxAXNL3ZWZa7GPV5MubpyvoPxt3PxEoNWiK+6y95qwn/DHtq6FrceeUSdI66jkAgVmLw+HgCRACqjVQbdbzxiSuepHIiUUMa84n1VzcR836j3MfnX/3jfCb8xW8ov5E8hMMv3lmVH4Ts9OP1+Hd0a1UdTf5eYKFr/sajPB/U3AwfP0gA1i6kT9Fi9Ftu5pKZgCYWmAvIg2zhw/7QLwktLymTvMOsgrZWXzcHmGe4BkN80eWIzAEOanRsyBlHnsHPrVe1kGkG9d0mZZML1UGfdP0cIzkWoz5+oMw4JgBd7iOt6QYJd9OYpDi8Pcubyw6iKVnilhHR9yRe2L 6ItKwCvd H+VzW0rBHqMOLMdIPk6GyRM1p0vYFN3s9mJ/UDn+O9Rm929N5BDrsjQQRarxX7V+4y2h/z2vvhh3fdDk40mU+L21IAA0xOX+eXMOB/Xa23UI4E/pBO3lJ7I3Te5qhHu1SIlLpgqncCnQDU6HhV+Qr7xdgiH48bG28A0XvOE/ISMugUWsm08BYsnYQe1OB+CMNQfNA97MXDe+Y7tXEJAS9Rg8E4YbNXl7DSgihVEna7XGfeQsAdtoHTeVyNHuK6ShnZglsLacAfRDnCFRb7VOdezKa3JHqxt3QoN0Sv6pnjTzQLVsF8LkbnyQ4eBqE75a83bB3wIPVkSX5jSmiufzSwlUqBQTg+5yJ4rr7n5h6OJ2DrFotPTc6DEPTibotKx6kUSbju6QqHXU1xVi5STgVjnKh81vsgzTgwXq/HvHAI40QtmYXNbkWKuLX5ZOnnUt/9b8EHFIsHRAPqYUbVl89rUVMSLEjIc3c0YkZxZCschASDFAcStM/q4J2Iso82IJ6pFS2gqtCrpWg4SWdU/FJpoxGct/KJLrjOjs+E8V2oqIa4cZiSiLKs4Z0VAgMaBAMiOJ0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 25, 2024 at 09:17:01AM +0100, David Hildenbrand wrote: >On 25.01.24 07:21, debug@rivosinc.com wrote: >>From: Deepak Gupta >> >>VM_SHADOW_STACK is defined by x86 as vm flag to mark a shadow stack vma. >> >>x86 uses VM_HIGH_ARCH_5 bit but that limits shadow stack vma to 64bit only. >>arm64 follows same path >>https://lore.kernel.org/lkml/20231009-arm64-gcs-v6-12-78e55deaa4dd@kernel.org/#r >> >>On RISC-V, write-only page table encodings are shadow stack pages. This patch >>re-defines VM_WRITE only to be VM_SHADOW_STACK. >> >>Next set of patches will set guard rail that no other mm flow can set VM_WRITE >>only in vma except when specifically creating shadow stack. >> >>Signed-off-by: Deepak Gupta >>--- >> include/linux/mm.h | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) >> >>diff --git a/include/linux/mm.h b/include/linux/mm.h >>index 418d26608ece..dfe0e8118669 100644 >>--- a/include/linux/mm.h >>+++ b/include/linux/mm.h >>@@ -352,7 +352,19 @@ extern unsigned int kobjsize(const void *objp); >> * for more details on the guard size. >> */ >> # define VM_SHADOW_STACK VM_HIGH_ARCH_5 >>-#else >>+#endif >>+ >>+#ifdef CONFIG_RISCV_USER_CFI >>+/* >>+ * On RISC-V pte encodings for shadow stack is R=0, W=1, X=0 and thus RISCV >>+ * choosing to use similar mechanism on vm_flags where VM_WRITE only means >>+ * VM_SHADOW_STACK. RISCV as well doesn't support VM_SHADOW_STACK to be set >>+ * with VM_SHARED. >>+ */ >>+#define VM_SHADOW_STACK VM_WRITE >>+#endif >>+ >>+#ifndef VM_SHADOW_STACK >> # define VM_SHADOW_STACK VM_NONE >> #endif > >That just screams for trouble. Can we find a less hacky way, please? > >Maybe just start with 64bit support only and do it like the other >archs. No need to be special. > >When wanting to support 32bit, we'll just finally clean up this high >flag mess and allow for more vm flags on 32bit as well. Noted. I wanted to give a chance to anyone who cares about 32bit on riscv. Will fix it in next series. > >-- >Cheers, > >David / dhildenb >