From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5953AC47258 for ; Thu, 25 Jan 2024 09:58:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B95C8D001A; Thu, 25 Jan 2024 04:58:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 941048D0015; Thu, 25 Jan 2024 04:58:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8098C8D001A; Thu, 25 Jan 2024 04:58:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6C42F8D0015 for ; Thu, 25 Jan 2024 04:58:13 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2674912050D for ; Thu, 25 Jan 2024 09:58:13 +0000 (UTC) X-FDA: 81717382866.06.E03E3C4 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf19.hostedemail.com (Postfix) with ESMTP id 1354E1A0003 for ; Thu, 25 Jan 2024 09:58:10 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706176691; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1VLr5iypv6tUTUNqIiFQ9+n93VJ8XxQbXLTmAJsf3Zk=; b=uFurtK6Wc1FzkfIVBb+0lUTpbumgX37fB2I4Nu1vrKsBXbXcPXefXFIOyGzvRxPgiKv9Ix geuH2BbQvTS4ysg/0Ezxv2WZu+1AMq9AHSddyz+6SZ2deSoCbz8wIuJYtQhbz/Po6Vm+gw So2Qcc6MS8mvM2V3wfdH/6hCHKhE/Bw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706176691; a=rsa-sha256; cv=none; b=YU5nBG0eQiyjjEnwQTg3mq/t3EOzQZL9X8A1HFaREPefwiwlCIsmXFvhOMXOho4rIj93x1 iAoEux4lhGxEikwHBJjPMLxH4XA90771ObTT8dzn+bMq7c0Vmq5e7W68AfMKigbSERkpsp BTXzJDcckWlEAHtvM6Z/5qBrUlccGuY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=none Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1rSwUV-005sxn-JT; Thu, 25 Jan 2024 17:57:48 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Thu, 25 Jan 2024 17:58:00 +0800 Date: Thu, 25 Jan 2024 17:58:00 +0800 From: Herbert Xu To: Barry Song <21cnbao@gmail.com> Cc: davem@davemloft.net, akpm@linux-foundation.org, ddstreet@ieee.org, sjenning@redhat.com, vitaly.wool@konsulko.com, linux-crypto@vger.kernel.org, chriscli@google.com, chrisl@kernel.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, yosryahmed@google.com, zhouchengming@bytedance.com, Barry Song Subject: Re: [PATCH 3/3] crypto: scompress: remove memcpy if sg_nents is 1 Message-ID: References: <20240103095006.608744-1-21cnbao@gmail.com> <20240103095006.608744-4-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240103095006.608744-4-21cnbao@gmail.com> X-Stat-Signature: 5ew7q4g5p3kidhgch7tipfr9gpp9piuj X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1354E1A0003 X-Rspam-User: X-HE-Tag: 1706176690-832478 X-HE-Meta: U2FsdGVkX18/jmbmx1XHUbnrniybhNqhi1WLQ3iqLnSPaG4UoqIinvyjOUvwyvvhEdwTlagZR9d7NcQB7WFUW6kCJ2JPzLMvJubBHPH5jzBDDFiZ8JdCX0nIL8DCVYhGKSmN2b94wfm3c1Ew9xNeMa6p18Is0d++8tfoKGMHFlmJmB2WmpRPfmnAv5cmVk5VLSD4V7GlGuaph5Pzvj6+0Q/wqRcyRXT/+sM3Xmmc+M+BAWJ2sWCF96qzT+oI/nGRaOFIk9IwtZvG3SWIjAHLJM41PtSfFOnGegGz9nvXsRf5JSpyxeSikNDefv7xUf3xZ8iO30VG55KQv9XpkfMe1cayACTNROICRkes1hJdqsxC45g0m7Xu4cWeN18Gdb4CtryPN7WnP3rVYnyD8US5xwVBHvCqYPE8bk8VOpJkrTao53Sz87XdGxCYKzBa6qnQe/THV63ZgnHOFUUIKaI2saeYKtgJoH9T8m/uCr8AqkyIn2GY3pupxhdwWSQOK+/C5llBpBdOtNGfE+UzvC91S20iriNkxUnb9ZLctFNaPc6WdExgH2aSCMjCvt6TXm5CQgqFq7FxveMU5Ab4A5tO/JGAXl+REXnhoEqSwp8Q9HMLb6+Fv4Tjq0kj32cEGPUJYjAj6iuFrBK2eeWQL7cqzDLv5kVjtv16W9UszYt7UPoZCJCx2JDNWNiq4bso/4Cqxcq11/7KNNGoXq/IjRPlTKMjLdzJ0pAQrtbnTohtMrFu3f6kKphc04ar5kCDMkKAT1N91mUtAo1gxbK8JDDBHVMQlOMIJjs38DuSQINPvFcVPDW2LjIaI60DczhT7v2vI5mz/SiFpuH4cA+cM45X4BN98WV3mOENSm5mydxlvPhtDsTkulPt/UNyuKg/jv8cUzAm3a3YkRJxiO5/w8bsMRRddE+0lnu5eJCqx0vMvatoFIOp/q0VU208mZhmUlZ80MAqOmZyge3T5cxbSE+ ceGFLB+U aolOw8lR7dV16CPLKu4icVwS6hD7AYtJFR4Ax8Newxbr6eBAAaIS23PuMvBIZrtpiUd2jcrU9KhQnH4aUAiSbQKGnDtGn2xReCRer4uzm1qs8Q4ZxYAoSmfAEn1JomSnWOAhzJuN/WqjKE/O4FmrYmVyB2vPrLtM6EFxuSgnc0E2GIXG87BJpPLTGDA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 03, 2024 at 10:50:06PM +1300, Barry Song wrote: > > + if (dst != scratch->dst) > + kunmap_local(dst); This is missing a flush_dcache_page. It may not matter for zswap, but this is API code and needs to work for every single case. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt