From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DBA6C47258 for ; Thu, 25 Jan 2024 09:41:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5FD18D0018; Thu, 25 Jan 2024 04:41:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E10038D0015; Thu, 25 Jan 2024 04:41:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD7CC8D0018; Thu, 25 Jan 2024 04:41:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BB30B8D0015 for ; Thu, 25 Jan 2024 04:41:19 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7E99616036D for ; Thu, 25 Jan 2024 09:41:19 +0000 (UTC) X-FDA: 81717340278.27.A60937F Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf14.hostedemail.com (Postfix) with ESMTP id E1FEC100021 for ; Thu, 25 Jan 2024 09:41:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706175678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2dLuKQxnxrLNBmwaETUmJxdBMC7z7aFdK5rqibTtqvQ=; b=3nC+Z4l7Tk8YH7fqIRjtRqO47+f/NWxq3U8Xd8cd10eC/q75bZ9yOc5kp+Bp4jxG5RQLwN F7ay9fpxrQPt5INzuKZJoSB3ZPCG1eLq+SUL2gxjPBaNADqc1nnrU/bZD1w7zNIBFJkLkd 8iMHCD6j8/mHH5sLhEWfcKTuKs6Em+U= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706175678; a=rsa-sha256; cv=none; b=Nfu/5b5ae3K89ynJldgbpeCEARD19qq3kymkAULxqE4NwA1n/1reOmXZFDEHLD8wsN8qc2 rP3J7Ld58cwOMSwyRPjVwuyU44tofwfWiP0FcVNWk8aT286R//fKKtSf3YSah+u827HdjE YxJyA0pus0IamHL9mzLQIBLS6J/sN1U= Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1rSwEG-005sPE-AZ; Thu, 25 Jan 2024 17:41:01 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Thu, 25 Jan 2024 17:41:12 +0800 Date: Thu, 25 Jan 2024 17:41:12 +0800 From: Herbert Xu To: Barry Song <21cnbao@gmail.com> Cc: davem@davemloft.net, akpm@linux-foundation.org, chriscli@google.com, chrisl@kernel.org, ddstreet@ieee.org, hannes@cmpxchg.org, linux-mm@kvack.org, nphamcs@gmail.com, sjenning@redhat.com, vitaly.wool@konsulko.com, yosryahmed@google.com, zhouchengming@bytedance.com, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH v4 2/6] mm/zswap: reuse dstmem when decompress Message-ID: References: <20240103025759.523120-1-21cnbao@gmail.com> <20240103025759.523120-3-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240103025759.523120-3-21cnbao@gmail.com> X-Rspamd-Queue-Id: E1FEC100021 X-Rspam-User: X-Stat-Signature: bh9fuoqyyph5c37x5ymrm9qq3r1cwpdq X-Rspamd-Server: rspam01 X-HE-Tag: 1706175676-53681 X-HE-Meta: U2FsdGVkX1/yylJx2KbGO3kxquNQdqbqpApV4Q8WQiTxxmT8ScMryAatoGHEMq83oEXA0pDRIGZ3qNFRKb4XJ8Bk3ZeajZ1gw9aF4p48b3ct3W4GxRK1XJSMWw8QMHnYFnibjVNzJdVWSxykR3TRseXnvUDZa2bdxZcWVO8/adHSme5dCMo100NEgK+r3d3ZpRjH0i3XMgWzVk6NrrK1MJGbEmnj5taw13LTPlaZ8P8IgMn5AkVHcZf+m48Z89AkjqS9UmPSdf7px26kycLIcSo5fqX8WvILsv1pd6x0MO3QtcnpdY75XH+JNEH92GRc432atQRNljJaFgPWMuSAdod1h6ca2Z1DeNey/m7NtkO4kdnGCVp4L2vQTcqIP5WfjJWKneqMA4SosDiYCTGHgyjJIiB8Eb7w6X8i4oJfHr7LJSfq7j3z3IbpMEK7FNO2G/0KY77YdTZcjeq8x+HUrGyVthBmCushG4ineyShQyN7Usz3MLDPvfH7EWWunnsqgqiOMVq0v5McUpZj1UwFS9KieRxPO+fofBA70Q9rTDrAlSmAmJGa84h9YJSG9OJ3ATEZuNTFZZ5mxcm1Hc7m4y2Jc0kOJL3NaDyeTa/0XV89b4+BmKkMuCmwwq80qxnHVkLJ7e8KKF1t+iO9G6Aoy3kuK1CoANxAOi7vcsMAQvI6maU8lpnk2bHvkGhEV1eFcDvkRJKP/bypC5PyiV2oRD/39onN5oYQ9Gg4hEk9Z1arrudoQIvzQGvewCtsrwpmYdrnG6ENFe66EGrubLP+3HGRh/9sGyzUBlpgt2FmnWHiMrkrzCiCIlgDQut8GDMO+oBqANG9HBLNKKTY5X5/d7JnCmbKLOjcAuyTHoM/DnQQ2oAl2Vp5jUrZvFNrxemrW3xQy/e8tIHGeHiLMM4iFljMqnYYS54arlTofb3NxMprhk+y1T4J/UcssOqQzqnxCs3wCGO4PGLNCz1UqIq iFwA/7Y6 kdI3kESu6g8qwJNM1V2Qqv0KkDoVXRL7rwypLIGj/XvN2pPshUt2PtIEtGZw/qgHvbmrs7icYiCdTBdpoEhfyRDE7IPnSWb0qcU5wtSuSHJ1bUVf08KBG3GFRhNkRJ6GjcVLQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 03, 2024 at 03:57:59PM +1300, Barry Song wrote: > > > We could certainly do that. But I wonder if it might actually be > > better for you to allocate a second sync-only algorithm for such > > cases. I'd like to see some real numbers. > > some hardware might want to use an accelerator to help offload CPU's > work. their drivers are working in async mode, for example, hisilicon > and intel. > > I don't have the exact number we can save by removing the redundant > memcpy, nor do i have a proper hardware to test and get the number. > As Chengming is actually working in zswap, i wonder if you can test > my patches and post some data? I don't have the hardware to test this. Since you're proposing the change, please test it to ensure that we're not adding cruft to the API that's actually detrimental to performance. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt