From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A835C47258 for ; Thu, 25 Jan 2024 09:38:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC6608D0017; Thu, 25 Jan 2024 04:38:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B76088D0015; Thu, 25 Jan 2024 04:38:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3E438D0017; Thu, 25 Jan 2024 04:38:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 906328D0015 for ; Thu, 25 Jan 2024 04:38:20 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3331DC03F7 for ; Thu, 25 Jan 2024 09:38:20 +0000 (UTC) X-FDA: 81717332760.09.68ADFE6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 899AB140017 for ; Thu, 25 Jan 2024 09:38:18 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=j7cXshX8; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706175498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U6l1VTlW2+CWMvZZ7YP1CM47RNRAdGs8EeGQLRBrnIk=; b=dbgumg+ZyWs51cEhSuLsqvTL3IbUs9HHqqYPa5T7RgMzKF8FzuNmsLgkXtRvQ17lfVHUcL i+4HQTaBc2jKVl0TL04dlzLIInMjQqkOYvgdTNb59EeI3KdLxROxghThMXyepv0o9gWl7t dKa928acD7Ao2LEQRGO5k8TbQCm7RdM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706175498; a=rsa-sha256; cv=none; b=DVHyMel0tM9IyTyC8F3ZAQqMfQZuLs5WuoTOclCUGOf/MS5qM/4ICBDkGTI/TbftUDDSV8 BwuO8kmaCJzCmMGaSbrSlAX9juYbnQJNzgbk/A8NRJcCL7VVrgjvUexGzKraycg3T5miNc a7Gs9vXdtfNlhPlLoDs9Kzbg/LtzjrQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=j7cXshX8; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9A121620E3; Thu, 25 Jan 2024 09:38:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DED44C433F1; Thu, 25 Jan 2024 09:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706175497; bh=uPP+taTP7ZolS6r9LsAYX+LZFusJs4p/dtdN1utPMp4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j7cXshX8VvMZ6jy4uPpWWynFqF9KKNfsuTOE+lHocKux1Enp2X7ezkrdx2mEtZ1VQ LItqtzp2SW+2CD3snw+qSYfrsmDrEq0Dn4raou7eXyBJ2dtkI+P8orlt5xAokl5o8n L0cBeGTUN9cFzTsSa+L6AcTLagQF/Y5/LBUYrGsCJ8eTWL6c56NA4hpyHlORUbS/D8 LOnSMKWCMSO8ZmNLQ4UMXAbKfv/Qz0N0UJkxikSraGGpia2d09HLaan9M226Qo2U9o xeM0WwgfCW15yfnLsHT9YlnVBBRQ/m6QJ0XvpwG7srrfyEL0qK5dkix11u+AICshRh JzCBBEhUijaXw== Date: Thu, 25 Jan 2024 11:37:49 +0200 From: Mike Rapoport To: Lokesh Gidra Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, selinux@vger.kernel.org, surenb@google.com, kernel-team@android.com, aarcange@redhat.com, peterx@redhat.com, david@redhat.com, axelrasmussen@google.com, bgeffon@google.com, willy@infradead.org, jannh@google.com, kaleshsingh@google.com, ngeoffray@google.com Subject: Re: [PATCH] userfaultfd: fix return error if mmap_changing is non-zero in MOVE ioctl Message-ID: References: <20240117223922.1445327-1-lokeshgidra@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240117223922.1445327-1-lokeshgidra@google.com> X-Stat-Signature: omn7da3incuf43n3gesjgpgc8g5r85d6 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 899AB140017 X-Rspam-User: X-HE-Tag: 1706175498-680688 X-HE-Meta: U2FsdGVkX18WADdCpdsvBxwkL52dqpWLPMpJinyypYUbCsqwcg6T4aLT7QKbLnKeBd0Hi49vQlt08gkI3WUv1IhcKylQ4QuDT/1fWV+U8jnb6QqKwrmSqiDXFZO2IDS4agNctH2n8cbv2/906n7E3XWt5kA8CAbZK1fAJWxZ0eI8ghJUvDw4E7QUzWWqwhp/DL3RIeN8OIgWx3xw005X3ueuCYpVSlMPZq022cGaE77kIVcgkfBuZYl008HH4Zk6e1TjqNHYhpAs0edXGnMpojPQTWjmMUPp06wKWuwRaH7mhkxSPoIqcdUmuJnyWWbxdVWWz2shzKN3UM/3aMDSP0o/ChiifKRNeBnb9cZnlOcy+UNznLtx4flHLTkh93OKFAlolTucwFdkgghDp/LK5x8ortZE48X2m4MyliJCa/lHth+mUNdXECCV3Qw2Daq3Rt+Sl7kPKAOPl6PQ/wmWWyIkw3GZBOo26zah1FimOXSaoVxv8o/MRIk/r1UrIf7F76mAu4rNSYRSB5lotl4Nreu2+5bifKMF9uVie+R2Ymg6e9uGGXntg1Tv57qOtqasCYLNNz7W+Ae3ptQhS9kKbyuqIDPLZ7sI2G3sa8iRvJCP3sGddvdtR9e+qGzoHPiQ9dknz9yfP6tJHm2uj7y677OrFZ9d1SaF4ONH9Hxa9x8IOAGXgbQ6cSMSrNWYV8KJ5ME2yWVBoZ/da8KaAOgE9m0smQ2jdF4P4l38C4D05eQgOBcJY2IDrEHjevvMmeuUjo+VWr0GpmRNBoUOArtQ7DFSbifbGSOZRnEr+uRm22WdLuJGATfeu1qtv4iMdaFkaEzMlejbPwTyRoUGyhta/GJGwZnqEcZr8vTnu4VHdN2d2mQ06ObEjirtY/v8CFwMoTbHd5bubWbHqs7gDnBxhP0yyZF59M+KC5d3iEMFh12VbeY3LucHxC/9vTrr4Yyovcqbs1q65a8o13ukn6H GCZmdUDc SanSwug8rxCVppMF2RfgS5qInpzhus4zvzE17BoSIh8mryr9ZpcU9aoCTebvs6KwyJ7g/rXnye2LEsalkl7V2gOGutYnWx/41T5Sj69iUO5SKmiwjA5erFwWraLcqr6GhaGQDmu6Cn8LLWsKhhi42VGJsXuyWFx58yGqZSWKESaXR7iZoSLvXVjLi//TlwmSm9ShZ+MJeXbf94Dnn23UkCqUIrwoug9fFIGHjnD5F+S3HZCyKRVLkpmOXDGVgKQ/HdlDkfqFh+XHdNpYjSzl3asPe083D2wwzk6VfwohR4Wm9fvkqa/lIxjHUDyFmUTwcB5tv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 17, 2024 at 02:39:21PM -0800, Lokesh Gidra wrote: > To be consistent with other uffd ioctl's returning EAGAIN when > mmap_changing is detected, we should change UFFDIO_MOVE to do the same. > > Signed-off-by: Lokesh Gidra Acked-by: Mike Rapoport (IBM) > --- > fs/userfaultfd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c > index 959551ff9a95..05c8e8a05427 100644 > --- a/fs/userfaultfd.c > +++ b/fs/userfaultfd.c > @@ -2047,7 +2047,7 @@ static int userfaultfd_move(struct userfaultfd_ctx *ctx, > ret = move_pages(ctx, mm, uffdio_move.dst, uffdio_move.src, > uffdio_move.len, uffdio_move.mode); > else > - ret = -EINVAL; > + ret = -EAGAIN; > > mmap_read_unlock(mm); > mmput(mm); > -- > 2.43.0.429.g432eaa2c6b-goog > > -- Sincerely yours, Mike.