From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66199C47258 for ; Thu, 25 Jan 2024 08:54:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E93218D001E; Thu, 25 Jan 2024 03:54:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E43328D000C; Thu, 25 Jan 2024 03:54:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0B918D001E; Thu, 25 Jan 2024 03:54:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BAF268D000C for ; Thu, 25 Jan 2024 03:54:08 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 86301120DB4 for ; Thu, 25 Jan 2024 08:54:08 +0000 (UTC) X-FDA: 81717221376.04.715D969 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf23.hostedemail.com (Postfix) with ESMTP id 44C82140019 for ; Thu, 25 Jan 2024 08:54:05 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=sSa+is6I; dkim=pass header.d=suse.com header.s=susede1 header.b=sSa+is6I; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706172845; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7ecjAXcF2LiHHvxYnU8Fo2z7wDNf7fQuOUP6dn1MlNk=; b=c394jymBwcffoeWSe29oX5auB64IlDtEYHsRbKoz2n49OBme5Mk293Yz8xBmSd6OI2BuKy RJIlb64rzecrC5S8bk+quOAnx3+U4bFq7kJzWmuO1RE+6Ep6GVo5e8nfGgndIPwvmk59nV 7pPwuEjSFLz01J5TpBo8fvp/ndmgnnE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=sSa+is6I; dkim=pass header.d=suse.com header.s=susede1 header.b=sSa+is6I; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706172845; a=rsa-sha256; cv=none; b=lSBP6rhx7tGd1fCXlmsNPcO6ljkCh8W4Nfvo8ogTYVmPXCpd10/OW3NoQJbqgjulLXZjv6 nySSGtGUQTVSZfx6HTalkOwIfh+OYz/tdM5UlsGomu6mkl/wLkjroJKQpqPWwUSxU0YX9T D1+nvz+LYANh4oKS4o3cbMR/RJaqRzQ= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 603AD21F5F; Thu, 25 Jan 2024 08:54:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1706172843; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7ecjAXcF2LiHHvxYnU8Fo2z7wDNf7fQuOUP6dn1MlNk=; b=sSa+is6I8ZeE4cqganZ4RLhvkR6KKtqLp98Nl1vxh2lwcgKBLKM5lsuv8lrs243U4F3jHp de/SVoIpJwrUYWelmAchqHmAIX8DPjO/WuGo78iVezDvZsCw9DuA+MuqvtopfrPoXcgWk6 vh545D1vtOu5bNHdDgl3aNuTy1dGKPA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1706172843; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7ecjAXcF2LiHHvxYnU8Fo2z7wDNf7fQuOUP6dn1MlNk=; b=sSa+is6I8ZeE4cqganZ4RLhvkR6KKtqLp98Nl1vxh2lwcgKBLKM5lsuv8lrs243U4F3jHp de/SVoIpJwrUYWelmAchqHmAIX8DPjO/WuGo78iVezDvZsCw9DuA+MuqvtopfrPoXcgWk6 vh545D1vtOu5bNHdDgl3aNuTy1dGKPA= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2779F134C3; Thu, 25 Jan 2024 08:54:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id exlXBqshsmVFNQAAD6G6ig (envelope-from ); Thu, 25 Jan 2024 08:54:03 +0000 Date: Thu, 25 Jan 2024 09:53:54 +0100 From: Michal Hocko To: Yang Shi Cc: jirislaby@kernel.org, surenb@google.com, riel@surriel.com, willy@infradead.org, cl@linux.com, akpm@linux-foundation.org, yang@os.amperecomputing.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: huge_memory: don't force huge page alignment on 32 bit Message-ID: References: <20240118133504.2910955-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240118133504.2910955-1-shy828301@gmail.com> X-Rspamd-Queue-Id: 44C82140019 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: xexofqpujpny1sxrusxm6kq91gwicrud X-HE-Tag: 1706172845-695284 X-HE-Meta: U2FsdGVkX186Xmfi2Woi91iXLXUbhm5tfugata1M4+b8lBbjsoKzwT9Y2Q8BaF1IbNS1PXQs+sBYSyintR6lHSCrwIvJpbyf7r5J9WOIhzZFmL0VONWa7QchvGFV6iHFf/bPhSHzXjDeSvMHwIfEbyFtNkRKM4Gi10ohUeQtv7hRKSniJi1DT2tbcj2/6vsGxRSaO+Ivadn8kWKIGsDQuKtsdspDAv5MMKXajaRziLoQjPL+8fDQVE2U4j8ozx8p7MuFb/oSDD9DNFY9GJEygnoauIkhdN6v25LdYp/tv5l1E1qTJu/t4oYTmR5CQT4YV7kPGunaBRGb21x4CiulHbKTYGkXuSWpCEqMzc0ND4t1r5QazO2PLvIvB2+jDtmljnl3SouQYdoHWbdNLN3JxCwRBaDiBqgS7OkxCCRMI/b0liwirIbRhBP8PFP02of4jm0QXWWh2szhJynPddcpzyz1RJZ0yysmPS2raiQl7l7KX4llcV87MmYR/Fs6pn4T9rsJS4xHNNvIYDhL/IefNmJFjnIYk7pHWnGCjZAShivKSuEZHsNSYlvXLjmxhm6nY+1ySl/0K+nhAmt4h02YR5HYp179LWSdTNItdJaUngy+zUnClGsBio3l29eA8YKcL0q9l/u0bCoyltv6+zRkCqrzniujM0RjeG6BsySwICzqSYMTjOUMtEZlXbOWeX/m7+FDMOuFERqVTbY+8+lbKD9nowCU2lWIxPLzN3DSq8/MN0XS1Pfo1WMy75pWh34QWJ3t5JkI8Y5ScRRgeFi1Hr0mGmuPVWIGMNIy/aqR+qaRDBXElXrmIAbRBQVxhMx2KHtvJG32pJ2J9Sr/leU8LILUOK6YUoJgOOXyGb7XxkbmFRzIYJWlgTJnkbU9NWjIY5Xkk2mHBb25dMy5wffzuc6Q1fTMnn8+s1lWtuCGWD4yBQDSGaFi5GGLZwOctjIOsvvZn+lzDRhOKTKamoO bWdHOjdu tfegxOaDh7jC0hpfDaDoGxjxoHohaybfFFN7mBrARH8SaE7pI6G95K38oaRj7SlsW+J00WGvIVnMxgU9Be2aowVqcKuzvpbmELTT1bZdGmDwjgAbDjBztjNzMR+9xXINOZOl5SSs2rrF7xqjUwk659ih5GcFjgNGNNuDc9cgy51i7LkK1kc77L1Qu9pYav6Fq6YdMXQG5CeLyXndTfNV8MQbusDsa6V176Z1B6eBe0hFJWE/TT9SRSmK+DbjFv+mm8HXGdy8yKo5Y8saRPTjGBDwF7PW2HyIZBeQMViv0ym2Lt/jfGyYgHFeajytr7axp9I0bCtNKVVDouJSZ1XUlue5B/0V61ouLuIgadFZuAbZkyaZkPjdRboaX1Z4IzE+Q6tnjfLJV7lin6QVA9/9IjrYVQBNyjbhahwoTbhbonm0aibf8mNWw6vmezHL1VW9xvTZlZD+uOJg7ePLsH8uuP/yzRFbI8gMmRcEibSZ9J8u1dHJWoqdCkQDr6J3TkgYZiYkCRRBLvvS35+N3vfIIjQB9vi6MdCyonS6/Idz+sjIc0AQx8/dMYhKf/R+u6IxJYQZsLDqrYnkVZQUi0eBgkQy6Hjss2G1koHZD+nrt6V7jgh+SbJhr5kmRcncVe/9SrIZDa0c4yhcOFEnmV4fgy8vDLI3K1giZvbrtOo/dGmMGTuIPnYZpPP/noXuHwP9ywzgeqGYMk3pY6ak= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 18-01-24 05:35:04, Yang Shi wrote: > From: Yang Shi > > The commit efa7df3e3bb5 ("mm: align larger anonymous mappings on THP > boundaries") caused two issues [1] [2] reported on 32 bit system or compat > userspace. > > It doesn't make too much sense to force huge page alignment on 32 bit > system due to the constrained virtual address space. > > [1] https://lore.kernel.org/linux-mm/CAHbLzkqa1SCBA10yjWTtA2mKCsoK5+M1BthSDL8ROvUq2XxZMw@mail.gmail.com/T/#mf211643a0427f8d6495b5b53f8132f453d60ab95 > [2] https://lore.kernel.org/linux-mm/CAHbLzkqa1SCBA10yjWTtA2mKCsoK5+M1BthSDL8ROvUq2XxZMw@mail.gmail.com/T/#me93dff2ccbd9902c3e395e1c022fb454e48ecb1d > > Fixes: efa7df3e3bb5 ("mm: align larger anonymous mappings on THP boundaries") > Reported-by: Jiri Slaby > Reported-by: Suren Baghdasaryan > Tested-by: Jiri Slaby > Tested-by: Suren Baghdasaryan > Cc: Rik van Riel > Cc: Matthew Wilcox > Cc: Christopher Lameter > Signed-off-by: Yang Shi Acked-by: Michal Hocko Thanks! > --- > mm/huge_memory.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 94ef5c02b459..e9fbaccbe0c0 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -37,6 +37,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -811,6 +812,14 @@ static unsigned long __thp_get_unmapped_area(struct file *filp, > loff_t off_align = round_up(off, size); > unsigned long len_pad, ret; > > + /* > + * It doesn't make too much sense to froce huge page alignment on > + * 32 bit system or compat userspace due to the contrained virtual > + * address space and address entropy. > + */ > + if (IS_ENABLED(CONFIG_32BIT) || in_compat_syscall()) > + return 0; > + > if (off_end <= off_align || (off_end - off_align) < size) > return 0; > > -- > 2.41.0 > -- Michal Hocko SUSE Labs