From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 190CFC46CD2 for ; Wed, 24 Jan 2024 11:19:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 897AC6B0075; Wed, 24 Jan 2024 06:19:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 847E56B0078; Wed, 24 Jan 2024 06:19:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E84C6B007B; Wed, 24 Jan 2024 06:19:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 58FF86B0075 for ; Wed, 24 Jan 2024 06:19:17 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 074ECC09D8 for ; Wed, 24 Jan 2024 11:19:17 +0000 (UTC) X-FDA: 81713958354.21.362AAC2 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by imf14.hostedemail.com (Postfix) with ESMTP id 2D86E100018 for ; Wed, 24 Jan 2024 11:19:14 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kKm6BhTB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=olsajiri@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706095155; a=rsa-sha256; cv=none; b=vEuYRhHudCzep6g4rzUlAPXtIpNAX0CxDktaJyUkZ2+Mp89D/jMmEdQj5kveGoolqr9j3b 1HDUr65/KXmUgO4HZu5e4KRTh3rZxBYIN/LZrgQ886Ff2VPJegaP7J6NoDAiiNmWwS1bxC jtp6RQ+PuEKwePJNGgRvva/unrfGVWo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kKm6BhTB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of olsajiri@gmail.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=olsajiri@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706095155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ax2WAgA+IWHYbycpjwhzRdnKEjPRyvd6ox/DAOqjIDc=; b=FLjt0kWaaHVx0YLFatrkngA2dkfAv++J1KuW0yDl6JzgWl/JY9Mpon5+WRK6NHNNmZMr25 7vBPPMxwcWq7WIIFNdW0oJ2UtfEqK5/Tiz9pI1J9NODRLvnMjN/QTPGohbOvnP85fnl/fJ IPT4a46j+9+2svJ8O7fy9w+FuPfTPHU= Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-339237092dcso3898618f8f.3 for ; Wed, 24 Jan 2024 03:19:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706095153; x=1706699953; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=ax2WAgA+IWHYbycpjwhzRdnKEjPRyvd6ox/DAOqjIDc=; b=kKm6BhTBeCAuuUwEkV15pCgqTchpYqviXABKuav/nwJgHEcgGWqd5vrorbeKNaSYPX zBPrK7U55FeWAzWgwtAJdISh3vgd6tt0AMFWIP5CbIvRd1fsSsVl2ohARb0bmX6IYPwg GUjXTAACj1rqsIdRunaC/8ZQVRLp3fVpZxKtyU/tQ1PIJQ515pKkuCnvWnF5hOB7C4oU uExcEMvB5X2hzxhrmXuEoQrUvoOAVnHktwfXf9ahHZgRjcjlKuFtJBbcwA17ZonnIKNi 2ExvoXeuLs/a3EzNY2V9231wu9ZPH2rtC+r5eDJs2BYAMh0rD6mEnbOPsVg3PTY8Ohk6 l03Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706095153; x=1706699953; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ax2WAgA+IWHYbycpjwhzRdnKEjPRyvd6ox/DAOqjIDc=; b=e0BPjDSqeiTntEyv2Bx/tK61al004phruHSWRoLWKE5Kg+zUbGNrMZbnJyvNfrkhmC jxCFZ/ySbmKivFU8tH3ZbsRqokqCxNTPJJuS1fPO8JouWciFxloSJ2XtMbZdxFSnT5EW KtRaU1gIJTUCfFR3dxAgq1xCwbCafAB5Scze7CLIX6iIJJIoAG3BMB/6Qz9qmFFnnDJu 0LXQDbyYh2qpIGA0dvSlQCBI5CNbNxW/JOv4fj044R64QBcHL/oAyRFaHUP6DRKpD+vj L4Y12dvxhDTus2+mmKoUQ+4PnMKBMAWu2DeyjjCGPj9HM7SwjYSbxXNSO9R55LxuCbAY phYA== X-Gm-Message-State: AOJu0YyV/yLl0erp/axn+MqNUOW5HOke6rBMEuw44R3MJmYBuss0YRix kngHOr94PaVJogKVMUe7YF9HR2zYQaXBzIBw047FzITNd6q90faR X-Google-Smtp-Source: AGHT+IEHrYSNYEV1+Dcij+tz/QoBsH6YJTLbxoqlNBdasWoDuViAcRoyJDbwKwUowv7rYDqrt1memg== X-Received: by 2002:a05:600c:3145:b0:40e:b93c:940f with SMTP id h5-20020a05600c314500b0040eb93c940fmr966856wmo.28.1706095153415; Wed, 24 Jan 2024 03:19:13 -0800 (PST) Received: from krava (2001-1ae9-1c2-4c00-726e-c10f-8833-ff22.ip6.tmcz.cz. [2001:1ae9:1c2:4c00:726e:c10f:8833:ff22]) by smtp.gmail.com with ESMTPSA id p16-20020a05600c469000b0040e39cbf2a4sm49817817wmo.42.2024.01.24.03.19.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 03:19:13 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Wed, 24 Jan 2024 12:19:11 +0100 To: Sven Schnelle Cc: Ryan Roberts , Jiri Olsa , David Hildenbrand , Andrew Morton , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Alistair Popple , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Barry Song , linux-s390@vger.kernel.org Subject: Re: [PATCH v9 02/10] mm: Non-pmd-mappable, large folios for folio_add_new_anon_rmap() Message-ID: References: <20231207161211.2374093-1-ryan.roberts@arm.com> <20231207161211.2374093-3-ryan.roberts@arm.com> <41dc7dff-1ea8-4894-a487-88d46ec2b2d8@redhat.com> <1188e67e-5c04-4bb5-b242-78d92c3fc85c@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2D86E100018 X-Stat-Signature: pwrbif99b6setuqpm19cz9j197d5fxph X-HE-Tag: 1706095154-235915 X-HE-Meta: U2FsdGVkX19+1/BPDrkNbN4jG5J+A3hj6ct34G4JIYdPNeqKf0/8ujyKk+HnmXDADJkc4tPXAIxY4gTGuTkhZSwFtdzZgZLeSc+fSb4AK3McoFXq2I3753qtP15IVd8C/v3PalBuV5n2Oy1TgUbn2vb0+MTdKUhlB//B5nRFEkd+53WlHdShbM1/vItk5VsiMphnU3mxkQYhyfcSHl8YElXKkA4+i0u2nSCQxe0ARoazgBaL3nVqlrwIqhasjom6C4yeaKRzEJb4Kp4c90RdGvxGjmU4waUcpO5rekTIzmFoiQj5Z58CCtvSVFp0bWF46d77+BjkJhSgLhzBIMukHXXl1NwtzLe4ViuhHT5Rm5W+E6FHIPyoopIaD/jpDeQgTxeBeC7l12tJjUw+5LgHHa3b+BMcok0o1h2JdDw5h5lkh3Ogz1Kv5PWN1mTxbOk1yxuwvuajMnmNUTEyjDON2k98/QXU2Wc3W1upedhm9LsonbNz3ct4rIYJiLQ/rZR/bdGIvjOKvCGoLgfdxHBntTiAkQeNVFgsVcKbWLHgfWfeZPi7u2Vi9ML0VppNvDRwWRJ6sp/I+Uu1MuQw3JohYeNvbHwYNT7XbMn/bvcrgyYNNSPvpSUimGMSaFQDc3OpxwVpc+/JSAgFjqTJPaLafHeq30lDkO4MB8qXorvwM7+rkok2797vEpOy3Skc3ge4pr0mKKD6Q1Ye0Osg/HgkLFCOtjfhwGnUtMxdkN77Cleo7ROkPsRRR080IIUt4jBQ8/mHCLKdldvMCQTUdm9A2SwY91X2vmG8KDK7jUO9RRhneAVWWluq4TYaZhLV6QM5tMrJQOZrp0bXrf4X5HnunT1dh5/J5LAu0BJqBNJhWO8HeicPeYY3Yq92bhsP8NaK47lztqw8Oe0gc6jg4x18/ARRnw9elq51jD2fi1XhD01mBuBjVQxkqAXaABlSpXoVaId1pGpz9IT0k68W8+y T9Tg8l31 dtQEIMQd9zCN2RX7RjSaNVYKVBJMi8otmtz6qNowtUgkb34P60W99OCAxnh68p2pfSU7jW/vMPY5kww8NSMxMP2VMP8M3UUJqQk8wftN5EWvr7j6LqNrF44Xt/wGnhE1SCt9oTiIKFVjIJwKTtTMpxCEAyy5s1xUt0Dq9My46zZ8kVlpq5HEYqwCAGCxZl7AvYeFKY4jfSopXJ+ROQQCnv2TGoEnZgqod1ZGeKB+7Rb8pEXOPxDLopVJYbmqyXhh/aDBDteHHCGhzspivdsmgEP4xcADUaU1SrqAYMZ/E9IaqtzI9Fax06TRw3vHTTTKrzfJ/NXRddie/7wYcOiTjLkEmAlIAiBwFaBsWbnAbfIcdQXcX3wWBq262R1MgOuSuRFl0044bilQsc/GYCLKMtnSdr5DJKYQXP/Y6lZs951ref+IZ1GNM3e1jfvq1lXLVObBvhara+BhPhrf6gViZHhWbFtwY0J7+/GVhSXWHg67GvEtnujNDwsT2d2YuqgavWsC1mPAMfmfDtXSzM9iNj0ggKvGdmsYi+89ICQS5ZUi1bj2JCnShacJpJcsdyxE5+N4OKS3xFDyOvmbS1vE+O8bFcRkNcFSm8KwRz5+SUBvgrANMNP0lx6NdFvbc7HziwcLX7m42gyjxUfMcwt5ksLGg7t63nqDMPLTmkkaqIxHyC1hAsdPR/uZqUjyJnU9b6ZT/WsUixjULsHAhr1sl0IU7TcxG0M/sUvZdwhAbDO75rENcYpJ2tzF2eLkAsZZqc2l0SmsmpxjdQyJEHWABas0GGEqQ9AI8+WUY0Zr9cgxVxkl7NQIskHR2EFjlKf6axU70 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 24, 2024 at 12:15:52PM +0100, Sven Schnelle wrote: > Ryan Roberts writes: > > > On 14/01/2024 20:55, Jiri Olsa wrote: > >> On Sun, Jan 14, 2024 at 06:33:56PM +0100, David Hildenbrand wrote: > >>> On 13.01.24 23:42, Jiri Olsa wrote: > >>>> On Thu, Dec 07, 2023 at 04:12:03PM +0000, Ryan Roberts wrote: > >>>>> In preparation for supporting anonymous multi-size THP, improve > >>>>> folio_add_new_anon_rmap() to allow a non-pmd-mappable, large folio to be > >>>>> passed to it. In this case, all contained pages are accounted using the > >>>>> order-0 folio (or base page) scheme. > >>>>> > >>>>> Reviewed-by: Yu Zhao > >>>>> Reviewed-by: Yin Fengwei > >>>>> Reviewed-by: David Hildenbrand > >>>>> Reviewed-by: Barry Song > >>>>> Tested-by: Kefeng Wang > >>>>> Tested-by: John Hubbard > >>>>> Signed-off-by: Ryan Roberts > >>>>> --- > >>>>> mm/rmap.c | 28 ++++++++++++++++++++-------- > >>>>> 1 file changed, 20 insertions(+), 8 deletions(-) > >>>>> > >>>>> diff --git a/mm/rmap.c b/mm/rmap.c > >>>>> index 2a1e45e6419f..846fc79f3ca9 100644 > >>>>> --- a/mm/rmap.c > >>>>> +++ b/mm/rmap.c > >>>>> @@ -1335,32 +1335,44 @@ void page_add_anon_rmap(struct page *page, struct vm_area_struct *vma, > >>>>> * This means the inc-and-test can be bypassed. > >>>>> * The folio does not have to be locked. > >>>>> * > >>>>> - * If the folio is large, it is accounted as a THP. As the folio > >>>>> + * If the folio is pmd-mappable, it is accounted as a THP. As the folio > >>>>> * is new, it's assumed to be mapped exclusively by a single process. > >>>>> */ > >>>>> void folio_add_new_anon_rmap(struct folio *folio, struct vm_area_struct *vma, > >>>>> unsigned long address) > >>>>> { > >>>>> - int nr; > >>>>> + int nr = folio_nr_pages(folio); > >>>>> - VM_BUG_ON_VMA(address < vma->vm_start || address >= vma->vm_end, vma); > >>>>> + VM_BUG_ON_VMA(address < vma->vm_start || > >>>>> + address + (nr << PAGE_SHIFT) > vma->vm_end, vma); > >>>> > >>>> hi, > >>>> I'm hitting this bug (console output below) with adding uprobe > >>>> on simple program like: > >>>> > >>>> $ cat up.c > >>>> int main(void) > >>>> { > >>>> return 0; > >>>> } > >>>> > >>>> # bpftrace -e 'uprobe:/home/jolsa/up:_start {}' > >>>> > >>>> $ ./up > >>>> > >>>> it's on top of current linus tree master: > >>>> 052d534373b7 Merge tag 'exfat-for-6.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/linkinjeon/exfat > >>>> > >>>> before this patch it seems to work, I can send my .config if needed > > > > Thanks for the bug report! > > I just hit the same bug in our CI, but can't find the fix in -next. Is > this in the queue somewhere? we hit it as well, but I can see the fix in linux-next/master 4c137bc28064 uprobes: use pagesize-aligned virtual address when replacing pages jirka