From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC869C47258 for ; Tue, 23 Jan 2024 20:46:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CFB96B007D; Tue, 23 Jan 2024 15:46:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 658936B0080; Tue, 23 Jan 2024 15:46:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D21D6B0082; Tue, 23 Jan 2024 15:46:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 371676B007D for ; Tue, 23 Jan 2024 15:46:38 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C694380C1C for ; Tue, 23 Jan 2024 20:46:37 +0000 (UTC) X-FDA: 81711759234.08.D6B79E6 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by imf11.hostedemail.com (Postfix) with ESMTP id D854F4000B for ; Tue, 23 Jan 2024 20:46:35 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="I9R+2/mk"; spf=pass (imf11.hostedemail.com: domain of htejun@gmail.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706042795; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1193ZUcARbQXW2VvJBKE7RwBOAanI7LZN4mhx6j3UEg=; b=JaVHQZo0QgxBPvb8ghnVcaKcNxFqfwh5xZag0rcBddu7sq3JA43sj91bAcjVpFCEMtHmKl pYv2INphLjjQ4Yw9uk9rOTAVEV36YLOs2G0VR7rZoFsg8k2GpSsPpO1CjjPM/2KRUwupt3 qM9ncnQrGz9R6pAW1nui38x/0Cgot1I= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="I9R+2/mk"; spf=pass (imf11.hostedemail.com: domain of htejun@gmail.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706042795; a=rsa-sha256; cv=none; b=hpkovHGW+Xa4waCa5bZLSFu8Mp/PLC4NosDh2cn7Fru07MdaEhgdd9gRdfJp0H4h+i+Z9y EeWvhlq/ATCCl0jT+twCwVUwX8lnB/eP0/lYg96Sj9OfZAGj/ecDU8yEl9rpa8ETbKSXzg tosbElWJXn5TiR8Xobwonc8pjmo87f8= Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-5d3912c9a83so673339a12.3 for ; Tue, 23 Jan 2024 12:46:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706042794; x=1706647594; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=1193ZUcARbQXW2VvJBKE7RwBOAanI7LZN4mhx6j3UEg=; b=I9R+2/mkF/EQHq83Y6EaT0vAHd1rP0POaNm6EjNWR1vfH3q31IHkLncQG9/f++BgUm R7X6rpJu0PYeneKoEhW8h9i4Scm8eCi1/K61iUuqByEM6a2TBdLzSoPECHlTnohjkFTn olMGpZplKV3AiMvkwgXcHsI6uAafsOlFG+pxWI+38aLqKAmUfwrX8TGVA5hCK4L4LQf4 SZOcrMRfcyGNpyLa+Pb9xqt948gAxwU+C+6GDvu8+tfPeN+VWz8DWIgOKKPBCIrArWok Gqh8vD6Im9MkzX859zWoJuRGBpgNNOJ29Mgdhz5+iyng0jVp72YSd44RW5FPRRRGYaOE PnHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706042794; x=1706647594; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1193ZUcARbQXW2VvJBKE7RwBOAanI7LZN4mhx6j3UEg=; b=bzdtxIPh4Z2U85UQe6+Cj3dRuYU9FBqMAsWBFB3XZ4oJ8FqNZ8rt0wKnpVCe/ToMDJ xB7dc2hxWkG9S8/wR0UktD0sBY1JDKsVCbQfgc5uXqho9FLn4yScU4ZVe0j6NDSisqd0 gHxnjpkYtoZe5MgvG2YTRIjAE9hbbclN44jrCtc/vJhdgh+Y0C9hyJdDy3CDQ4zfz1iE cH36aR1LjdkfrKcsfqTJVJp6qz/kdkYbLiaCebRi3QvkuWmy9ZUB9P0Grlows8C3AJJZ irfNExtDUnIgGxjFufUvrds6XxdZ6GhKFeN7w8OKpQwJuEonKWmeSeYw2TugBvcKWCJ8 e31Q== X-Gm-Message-State: AOJu0YzWJ/ksDv1STi880TYlxsGzpX/ToR/Pr6E9ADPF9jH6K2vw8p6C 6c0ALRY2a53gD26oa/XETKsS+shWK51E0u4GBDdU0fILxjixUrCIJnGB6luX X-Google-Smtp-Source: AGHT+IHRlB0tSZZINjSUHO0zHKwAMgzJQcJzD96eqvVlSKplexha/BylAQa/rUNq18wO1981hAOVmg== X-Received: by 2002:a05:6a20:9f9b:b0:19b:238a:85f5 with SMTP id mm27-20020a056a209f9b00b0019b238a85f5mr3922586pzb.11.1706042794455; Tue, 23 Jan 2024 12:46:34 -0800 (PST) Received: from localhost (dhcp-141-239-144-21.hawaiiantel.net. [141.239.144.21]) by smtp.gmail.com with ESMTPSA id g5-20020a636b05000000b005bd980cca56sm10569872pgc.29.2024.01.23.12.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 12:46:34 -0800 (PST) Date: Tue, 23 Jan 2024 10:46:33 -1000 From: Tejun Heo To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, hcochran@kernelspring.com, mszeredi@redhat.com, axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] Fix and cleanups to page-writeback Message-ID: References: <20240123183332.876854-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240123183332.876854-1-shikemeng@huaweicloud.com> X-Rspamd-Queue-Id: D854F4000B X-Rspam-User: X-Stat-Signature: 6p515xr8cfngtijfqzpngagdrfcnsod6 X-Rspamd-Server: rspam01 X-HE-Tag: 1706042795-376918 X-HE-Meta: U2FsdGVkX1//4rkfOd/Hb9oRoHqWu+o35zil+zpZTYJGASafXOPpZXdL18KVNcTAHCTBgkCmqX760RigEDLgIp2/pcMbWdY4Et+1G+oWvIJpnXr+WHkktIvu8BoUTsPD9+oePYU6C3SLfige9Vq55hUw3JrOUSFtieqoqW3RhYBOmKTtYS6H4tjf8dj3PGirqibwrpbIhu9+flYAZr4t/VGxRtPTIbDTD0Uaj+uNDk3UT+Rk4/H1Yi2ycgPh3D+JHFhaElLz/PXlMx+vlnl5dah7BlpY/VtV1v5B5ol5B5kDf0nFoK+jmEzu34FnTHeC1KxRR8bMMXzYi4pUhFb/Zbk0QdmATt5e6Ok8OnihxMfabYpJWe1xKXAlWnF9fEUJF3GU3PLjaszIoAjne/NgJKoHmV13gZKDNq156ZYuWMT0kGrEQCwLZZnObgomGQe+T4OmD0WWs3JOEkvpoJgnVGt7TtInPhgqyabAUpVbSRmC6HouQUKIR8hAI7/mqCiCGrw+rhnWd229GRR/k/AOYw18aIdXxEBxh9F7IYJCghtc1cBiBhvpMOey3JhhZVs4v+KEtaL+G+1GVHe/oyE9bVIan0E8yzw4aDE7DEaPY9suOzMQeoKdygqBTVtDQ+bnMFA/DAU37DAoFSELJe3yyUuB4FakTCY/H1ipW4heJK0SxW8LmdJajr2ZE1pOLzBd7DmntflUzOkCNVxB+Ddn8cUAdocs4JS13QHts5Tzj337onjGWy0AY7uf1Z0QJgieT4y5PqitlZslkadOMINdghPEKNLUc4smDe0GYzPrDbUGe31C7lwbtQQcnKnSRt4ClH8Kv0+PEuyhUDbsj4KQcdo9bmmJ6q5mwyRryRSotqLLIDM48efk2+2JE9pYyJjEW4JgBXIEZgSoEdpB77tplyhCAwoLFV9NpeGzhPiC1k+cUPefmjPRnjqMkS7AitFxQuRcR3yaMGnn+q42vfx 7MlwbDsH eo4WRC0jS75BYKYqRTCNb7La8fBzUsbhMxxGrj9U/v4ZU6mZbaOMJLXJWUNkt/Dm6CHZo7axH9ui5ecT6TEqxJaNwEAyxFjJJ9shIf3Xfa5gtDhelex5v8f4B3gX/GPqzlBanUCE5iBY4fK3kP1NFcvkWzih/iK9IUNPyvINyiCy3FVL/LBh11f0m9pVdXh1AObyORgsua8xdDA3RT1+3zY5uKj70aFszz87oIzH4TJqQq6aMa8xwZyCP6b4Yki6oyffYvlUP0MmiuTIFfBj6uOsol2aRtGQxkeeMeGM/m+iOiwPY+pfHuBpAx/urVTh3d24ZeLQzRhJXOXCjm3Im+tEnwQlVHg22BAwWD1msRD+1Te6UKPWMzSUEfBeMAhgDbhGgZbaDZaE0B3GzVu7Wwz4SiG9p4WRxvxwuERfcre0fPe7X0S7X83awEug9W5xkIQ/PB+7TUOFkTSS9aH3Oy6q7O10LdT2UbxpTPY9AYJ2tMFQCa/dmdp5Hvv5ygIQ/a12eYNl43NOIeG03pd0YStN9zg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 24, 2024 at 02:33:27AM +0800, Kemeng Shi wrote: > This series contains some random cleanups and a fix to correct > calculation of cgroup wb's bg_thresh. More details can be found > respective patches. Thanks! > > Kemeng Shi (5): > mm: enable __wb_calc_thresh to calculate dirty background threshold > mm: correct calculation of cgroup wb's bg_thresh in wb_over_bg_thresh > mm: call __wb_calc_thresh instead of wb_calc_thresh in > wb_over_bg_thresh > mm: remove redundant check in wb_min_max_ratio > mm: remove stale comment __folio_mark_dirty I don't have the fifth patch in my inbox and I find the patchset difficult to review because it's changing subtle behaviors without sufficient justifications or concrete cases which motivated the changes. For now, I think it'd be prudent to not apply this patchset. Thanks. -- tejun