From: Tejun Heo <tj@kernel.org>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: willy@infradead.org, akpm@linux-foundation.org,
hcochran@kernelspring.com, mszeredi@redhat.com, axboe@kernel.dk,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] Fix and cleanups to page-writeback
Date: Tue, 23 Jan 2024 10:46:33 -1000 [thread overview]
Message-ID: <ZbAlqdwNv_uxnKT1@slm.duckdns.org> (raw)
In-Reply-To: <20240123183332.876854-1-shikemeng@huaweicloud.com>
On Wed, Jan 24, 2024 at 02:33:27AM +0800, Kemeng Shi wrote:
> This series contains some random cleanups and a fix to correct
> calculation of cgroup wb's bg_thresh. More details can be found
> respective patches. Thanks!
>
> Kemeng Shi (5):
> mm: enable __wb_calc_thresh to calculate dirty background threshold
> mm: correct calculation of cgroup wb's bg_thresh in wb_over_bg_thresh
> mm: call __wb_calc_thresh instead of wb_calc_thresh in
> wb_over_bg_thresh
> mm: remove redundant check in wb_min_max_ratio
> mm: remove stale comment __folio_mark_dirty
I don't have the fifth patch in my inbox and I find the patchset difficult
to review because it's changing subtle behaviors without sufficient
justifications or concrete cases which motivated the changes. For now, I
think it'd be prudent to not apply this patchset.
Thanks.
--
tejun
prev parent reply other threads:[~2024-01-23 20:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 18:33 Kemeng Shi
2024-01-23 18:33 ` [PATCH 1/5] mm: enable __wb_calc_thresh to calculate dirty background threshold Kemeng Shi
2024-01-23 18:33 ` [PATCH 2/5] mm: correct calculation of cgroup wb's bg_thresh in wb_over_bg_thresh Kemeng Shi
2024-01-23 20:43 ` Tejun Heo
2024-01-24 2:01 ` Kemeng Shi
2024-01-29 21:00 ` Tejun Heo
2024-02-08 9:26 ` Kemeng Shi
2024-02-08 19:32 ` Tejun Heo
2024-02-18 2:35 ` Kemeng Shi
2024-02-20 17:34 ` Tejun Heo
2024-01-23 18:33 ` [PATCH 3/5] mm: call __wb_calc_thresh instead of wb_calc_thresh " Kemeng Shi
2024-01-23 18:33 ` [PATCH 4/5] mm: remove redundant check in wb_min_max_ratio Kemeng Shi
2024-01-23 18:33 ` [PATCH 5/5] mm: remove stale comment __folio_mark_dirty Kemeng Shi
2024-01-23 14:07 ` Matthew Wilcox
2024-01-23 20:46 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbAlqdwNv_uxnKT1@slm.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=hcochran@kernelspring.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mszeredi@redhat.com \
--cc=shikemeng@huaweicloud.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox