From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 039F1C48291 for ; Fri, 2 Feb 2024 15:40:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 149EA6B0075; Fri, 2 Feb 2024 10:40:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FA136B007D; Fri, 2 Feb 2024 10:40:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F03E26B007E; Fri, 2 Feb 2024 10:40:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E51206B0075 for ; Fri, 2 Feb 2024 10:40:26 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9BAAC80F52 for ; Fri, 2 Feb 2024 15:40:26 +0000 (UTC) X-FDA: 81747275652.17.283B92D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id 31A3D1403FC for ; Fri, 2 Feb 2024 15:38:50 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="JE3/OF6P"; dkim=pass header.d=suse.com header.s=susede1 header.b="JE3/OF6P"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf26.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706888331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7DD5NcDaE4KXkL73aEaoSi9tMEuvt0oHfZv8FAecTdE=; b=qMh3maGSP60KGT7x3UrYV8aQukfh2aeR3hWwqDah2sXiV0FsvW/5k18bZDkHgdOfMTCMFT AXL17tiWpQUAfw6maXa9hrB6PhwWUWpDNmmw9tAL2mbUq7Ig6u2DIriOyhpihGyIGJDmWU w4+U/nZDLRZBxGolGSmLdq6GK5QzLno= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="JE3/OF6P"; dkim=pass header.d=suse.com header.s=susede1 header.b="JE3/OF6P"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf26.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706888331; a=rsa-sha256; cv=none; b=WusBAz1LCqjfpNfiARmek/1Xrt0YS+iSqsH6ssLVrISfJz2SnJ/nVfVpsQC42DVK/yJyCy yOikxnd2UIEsaht2cuWy4wtj17IfAN2NBMIZN2zcn0b9oNl1XD1Xc00JX29u1l5YwbRf5E 6vnsWHv5oQeqRVnWiLhKCZrGyREUbzU= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3D71021E95; Fri, 2 Feb 2024 15:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1706888329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7DD5NcDaE4KXkL73aEaoSi9tMEuvt0oHfZv8FAecTdE=; b=JE3/OF6P/OICQQObQF+DQQ8eB5RUYQtXiBvl8Dn2OzA9BiY6zEjcozPa/dL3PdOzAJwq3g xtL/tF+edkLZESb51NpOwIykl3OsP5jOwq5aGwJOUcehIb5xdVk07tkJBGuN690O9tJJwp qmJ44rbfcdkW7XLFO8jmuAMJs+K2A5Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1706888329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7DD5NcDaE4KXkL73aEaoSi9tMEuvt0oHfZv8FAecTdE=; b=JE3/OF6P/OICQQObQF+DQQ8eB5RUYQtXiBvl8Dn2OzA9BiY6zEjcozPa/dL3PdOzAJwq3g xtL/tF+edkLZESb51NpOwIykl3OsP5jOwq5aGwJOUcehIb5xdVk07tkJBGuN690O9tJJwp qmJ44rbfcdkW7XLFO8jmuAMJs+K2A5Q= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 201AC139AB; Fri, 2 Feb 2024 15:38:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 5RaJBokMvWXWMwAAD6G6ig (envelope-from ); Fri, 02 Feb 2024 15:38:49 +0000 Date: Fri, 2 Feb 2024 16:38:48 +0100 From: Michal Hocko To: Lance Yang Cc: akpm@linux-foundation.org, zokeefe@google.com, david@redhat.com, songmuchun@bytedance.com, shy828301@gmail.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] mm/khugepaged: skip copying lazyfree pages on collapse Message-ID: References: <20240201125226.28372-1-ioworker0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 31A3D1403FC X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: yfuty934imwnnpay4nj369n89ez4kwnr X-HE-Tag: 1706888330-414341 X-HE-Meta: U2FsdGVkX18zOURlXrSalAlTissyuxkovcpO74SSai41WydOnAOIWzXrEkGkVgBzcRlCdb5sbrjANivfWlLYedvB6Vs/p6FYdqQD4Pz6H/2SzXTlgpx7shLX4Exk14Ut61qcOykAFcYBNW+OPzlo8q37U9nRmeiB2kxq2aCynctpfjfGQX/LPFMfVAv7iFjMqp3hgVsRCaPydEBScwDy6DX491MBWdia95/LKOXSBRL0Hq+a0tvAiyP61lwEnjne5D0xu2DIetBB2abT4vNDx7VUJ92hiVfh6MB5Hw5mtWMMWYpxU2RgY5oVmuJLJkJgvHaWt9mqUx7gNGFXocQMx5c79GpVcQY75nGLlQkiqECW2//1XZUZmVWHGNobk7f7YPjF5gbUAXqYjAidjJHfxjze4SkgxRd54482Pe41cbXJtdrTNv9jW0BR0dlJJUMk4o0k7TcA0Do4v7tlZzamlizfHt7t6mWc3VWV9XHeWi9+fEin78iKsWj4B8RjU4D2GvgMP2QLD3mnZHufClXOvCBeanvV/+MSpWt4Kb0pIW851LdDoU0lUTUZ6bzA6Wyn4c8Ero7HPaWnrlDq936dyfygMkrfy8uvKI0RX5cg5Dr8i+uyH2Jw+y18g7dv0slNQPZCwAsJ71E8Qmty9k90PAkJXHkxv9IFqJYQ46YhTOeaKChJDNdf7Z1ztAE7+zd4jLfYapK8+AppfnYgHI0vEv+FXaI0ExUGTjNmCfi/1hVfR8PpmCYOOFs/vcqcXQUIUv/7oQj1Fm5YsF3wzvRtHHpmnBpzpwdaiwp7fy+JamvI2LcgbYn2ETuQ9f0vUwGZDMAtChu8uhYNm+B9qWnl511n2onRFa3lqDmZ9FmHxG9eGb2Oa5QSxs9qduSjh/XlQFc0kxArhaeZst2EhPF5BkXzjy0Xy2r20N+yunE6WUEkDWHdn3aOkjw//lb513sridigiSWqyA5NY94lgjG DfWeqV3U THRW+6eeqID56KEKaU05UJ2i4lPf8LMKdIz7qcPHGSLC3wc5cRuw8JSEfj9PJa39LeNwa96U4dB47jRG3PfRmASVzhpXh/mOoRHztAMV3penTJcpQyL64TWWcDFYD4ZGIbtTGLEUbkAVZbvjf8OwGt8aJ5lJPRfuPN4SHVxt7rDCZGwG1yHUtDhCBv3wd8iRmoQ/MfX+uVS5ToilyhK0+RgeE7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 02-02-24 22:52:49, Lance Yang wrote: > How about blocking khugepaged from > collapsing lazyfree pages? This way, > is it not better to keep the semantics > of MADV_FREE? I do not see any reason why. And you are not providing any actual reasoning either. Unless you have a very specific example in mind I do not think we want to change the current behavior. -- Michal Hocko SUSE Labs