From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5CCFC4725D for ; Fri, 19 Jan 2024 15:46:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A4636B0082; Fri, 19 Jan 2024 10:46:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2548A6B0085; Fri, 19 Jan 2024 10:46:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F5336B0087; Fri, 19 Jan 2024 10:46:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EFF8B6B0082 for ; Fri, 19 Jan 2024 10:46:12 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BB054804A5 for ; Fri, 19 Jan 2024 15:46:12 +0000 (UTC) X-FDA: 81696486984.02.D56B44E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id 6A6F9140002 for ; Fri, 19 Jan 2024 15:46:10 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Jk2YMo1P; dkim=pass header.d=suse.com header.s=susede1 header.b=Jk2YMo1P; spf=pass (imf26.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705679170; a=rsa-sha256; cv=none; b=MvCBlwZBfws22EBULBPmCRU6kE2WF0YBiOyi7Ip1X9OFCHrC7h2+DInUa42r5Bz0F/5ROe 6ap+infADuRf1z2VNh0sjpbpkuQo1/SNR+4wuVHlnuo+ru9cpiA8pcF2Mau1kRV/Erpf29 n9HC6fj47tNX0grtae+7IOG0FgbffZc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Jk2YMo1P; dkim=pass header.d=suse.com header.s=susede1 header.b=Jk2YMo1P; spf=pass (imf26.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.130 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705679170; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L/IkvwqWM3HNNg1/Uy/USTNPgBNZMsOoOsiNX+V4qTA=; b=RrMtgXKSOKbfYst7vx/0YUe84cqU2REVt8fAJhBHuClHkiMiHIf/BcYRCzCnU/AaNPHPRk vlhss9nQxTSz1+iM7Fv5lPIoJYOf58DAsJzWkqGkV9peA7gJyLrUQ51Wlm0Zptoxb1HQ03 vfnXTs9Z7smGUW6lfb+jymGhy0m9Qss= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7BC0721F6A; Fri, 19 Jan 2024 15:46:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1705679168; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L/IkvwqWM3HNNg1/Uy/USTNPgBNZMsOoOsiNX+V4qTA=; b=Jk2YMo1PILNRnK/XmsvxK6a3fjwq9hnkYALMaPIQX5lVSlPZEbs+9XXCUEQhFgR99iuhop eaRKLtTNFM5tt4TxuX/JyqxszSweMfJ7SRlfWn6u0fLGI79jui4M3iDBw5kIakjE3IDjjU c3HphCMmA12v22HJCKVHjGCjQyohEis= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1705679168; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L/IkvwqWM3HNNg1/Uy/USTNPgBNZMsOoOsiNX+V4qTA=; b=Jk2YMo1PILNRnK/XmsvxK6a3fjwq9hnkYALMaPIQX5lVSlPZEbs+9XXCUEQhFgR99iuhop eaRKLtTNFM5tt4TxuX/JyqxszSweMfJ7SRlfWn6u0fLGI79jui4M3iDBw5kIakjE3IDjjU c3HphCMmA12v22HJCKVHjGCjQyohEis= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 64C8A1388C; Fri, 19 Jan 2024 15:46:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 6vyaFUCZqmWzSwAAD6G6ig (envelope-from ); Fri, 19 Jan 2024 15:46:08 +0000 Date: Fri, 19 Jan 2024 16:46:07 +0100 From: Michal Hocko To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, Matthew Wilcox , David Hildenbrand Subject: Re: [PATCH v2] mm: memory: move mem_cgroup_charge() into alloc_anon_folio() Message-ID: References: <20240117103954.2756050-1-wangkefeng.wang@huawei.com> <14ae628d-a9ef-42f3-9201-e90c5c88c133@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14ae628d-a9ef-42f3-9201-e90c5c88c133@huawei.com> X-Spamd-Bar: / X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6A6F9140002 X-Stat-Signature: nx4md9hgoxz61ygf4qjf79rdrkm67xqm X-Rspam-User: X-HE-Tag: 1705679170-772691 X-HE-Meta: U2FsdGVkX19DE00xKiromgrWrBoWPDnpIx1hFGiCxBIsOtcmCLUYuAVKk8EmnHUcgh45K3eabOaSrnjJaF+AWWK72oH/56G0z83eTkwglnj1cBK+W2fNCsme7QajhJYiXZsz1pVyNp7pDZrfn3L5UW1EaTNMZN53ZTuZM9RLmy12DXQ9zoGubXHbdsAO0IfEm5Dpp8U4dtkGng8j/qaP1Y9giD5a+XVARiRw3BZEfTszkx12LG+VYiu5DcpfvXUOuXhv/YQGCxXLlML+LGnSMLEZqSGDgAmnUhm1yjvgwgv82Dlh12ywQTxRbWmPsglh5ofLdVWCLvY0ru/vTy9ZwqTYxPdpnJnguXNGvPUIbNO40vbaMOFfGCb0V3AFrg9ClR6LSW8HxGJxkMq6Br7Yfv8t3zBbZl5GV1Q7x/Y65ug0kxXRtyrWWmpbw4P01fBEtz7VRTW6TSq+bK+zOBMYM3+N2jjzGduJ8p1W6vO4IUBmVP8h2eOCpusWNWVnO6YuyFBGO3QspySYNo2UgK+aaPc39Bv4xhP1Z6pfZ2bV5EvB3dNPygz8h/5SCKXSNtW85pCnqz3yXSkjEy9Kzzb14rhvvzdqkB0QMF/Zp1YZJAGnM7w/i0FkVK/TAVl5TZv/lr4e22FlRaw07TLAySDw7gbIAVUtWu8DCeln2H70Ux+nWN4Drc8+knqtqjHiuEHl5iEHBx7ecAELkz+ajTX51WuszN5bYIoPxcyUsr7Ta8FDoHJshoOAuPeUhqj4fBnQJ7dHOaDxXYc61pYcoGodFISxSQtqe7VJMNBR2PYscyPlIZ7Q5Ee0p1ZKkLVdUxnDKfSz/tjDIVH0q/IQTvtKmdvM06xekuULOLBCBqAvrt7n9LjhD/2D1/8OWRwDdjWDBf3ED5a7VFsIP7ecbFgB73pvaJTd2DqVVOEzSD02GQhEMWMKG8g1ZuFyO1423qMqF34Y4JGsc5W1c6ry4nu eqlBlXhh zI2dWJykL0xe/u8/SOk+yFt3CGiA2ERe/x4Ei8bId/67n8KILMI027896QYUtvCzrg2rMoG2xc8eYtLiU5ExhvyJlF4H2PGxzS7LeIfUuUTmdzaDPz0+4VwE2sOyq5i03ITD8XsJbCjEmqF4nuK1eTp5zWTS6BI1LrHov3i2V4/xCz3RHN+svhXGqiMa4psfrT2F6PQu4xWk94cx4DTF2hsfVgoFMCgwmBYKG0GOtGBjNZEFtHSBgs7xI6ypeCOcYdsPy4OiOkWgtnr4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 19-01-24 20:59:22, Kefeng Wang wrote: > > > > GFP_TRANSHUGE_LIGHT is more interesting though because those do not dive > > > > into the direct reclaim at all. With the current code they will reclaim > > > > charges to free up the space for the allocated THP page and that defeats > > > > the light mode. I have a vague recollection of preparing a patch to > > > > > > We are interesting to GFP_TRANSHUGE_LIGHT and _GFP_NORETRY as mentioned > > > above. > > > > if mTHP can be smaller than COSTLY_ORDER then you are correct and > > NORETRY makes a difference. Please mention that in the changelog as > > well. > > > > For memory cgroup charge, _GFP_NORETRY checked to make us directly skip > mem_cgroup_oom(), it has no concern with folio order or COSTLY_ORDER when > check _GFP_NORETRY in try_charge_memcg(), so I think NORETRY should > always make difference for all large order folio. we do not OOM on COSTLY_ORDER (see mem_cgroup_oom). So NORETRY really makes a difference for small orders. -- Michal Hocko SUSE Labs