From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D494C47DAF for ; Thu, 18 Jan 2024 22:42:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FE496B0085; Thu, 18 Jan 2024 17:42:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AE176B0087; Thu, 18 Jan 2024 17:42:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0772E6B0088; Thu, 18 Jan 2024 17:42:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E84166B0085 for ; Thu, 18 Jan 2024 17:42:53 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C4AD11C15D9 for ; Thu, 18 Jan 2024 22:42:53 +0000 (UTC) X-FDA: 81693908226.07.441C4F1 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) by imf05.hostedemail.com (Postfix) with ESMTP id D5FF010000A for ; Thu, 18 Jan 2024 22:42:51 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=N4IE1QCV; spf=pass (imf05.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705617772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/NW4TFX7CWHcAM/ELBrbNoRjZoFg4ECdesduuMPSbGg=; b=jFqjBBwp/bG8zXhP87VhO6TqQxeGAbSPPevgjXaGpMW6MkG15FUI55YaZo5yZvvtOHbvlQ zAwWlg+iBdXj+7EVl4/9rTBwWJVwHZSGh+12MyeBjSeAAGYZMEWuNbmA6Bkq2ABYVfnQHO 5sMGArxYiybh+8xoGOEpJNYw8NXBanE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705617772; a=rsa-sha256; cv=none; b=nnvL1qAmBK3PyZBW52aaDizJcFjsdymMc+a0SVr6oVL2+00MbkPnm7wQZh2Rj1DmmXsCz+ CXT0NuoEvREXTyXO4wBldEIyT4mDJ3rHgYWgnits92A5xlJCnvRYTrRey+Njfhy/Pp5VO0 hvF3qI/raEcWl8t31Ao9ubjZAZDwV+c= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=N4IE1QCV; spf=pass (imf05.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Thu, 18 Jan 2024 14:42:44 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1705617769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/NW4TFX7CWHcAM/ELBrbNoRjZoFg4ECdesduuMPSbGg=; b=N4IE1QCVP5VIcbuR4Mcg6nA+HVgTdyZjjmPLO5un8b8uPzNausMnYCjqobPCaZI8wxOxAC vhTC220fHpAXcjr+SWKeqaGT6V84JiNihZa9Bx0OJUm5q5b6hZwLpaSRseEcXg9CnR4+8H GtBpMR3RI2JnOh3/MdavJtceCr2yLcY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Shakeel Butt Cc: Andrew Morton , Jens Axboe , Johannes Weiner , Tejun Heo , Jan Kara , Michal Hocko , Muchun Song , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: writeback: ratelimit stat flush from mem_cgroup_wb_stats Message-ID: References: <20240118184235.618164-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240118184235.618164-1-shakeelb@google.com> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: mxcc4jb8jq5ziu35txt6yzm3ko8h47wg X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D5FF010000A X-Rspam-User: X-HE-Tag: 1705617771-931370 X-HE-Meta: U2FsdGVkX1/TigYG21TvgZ1CXTNLgh3Sulrhn5OY91Kdf33jFz/x8sknpBsyHn4vWzFnsVR4lDhnL7kOxHZQUSEgYxQrdn/WN4eThk8/UZCxcXcqq1iz7euRGI6sRImk2m8SsEeWAFBJf3yClSxinwS9Sk4w7XJ0gxMX3iAcTTsA+4Eee2z2bxj2i9PxV30uDQd+8HLZ51azWf4l/ii6zdlsFDVhEpoQ+b270iVCsM0r/9/HOFCX+Zhtp9sKZmWmytlYzyiePkiB131cFLdAlKnhS0M9IhulAqOIZv6aviIiWooT8WZ2zA0wsxumdXuv/MkyEnuSRMZHdXC/rHzkbXfatrezLS0K6JwFrQ4MlYqgNzF9SrILHsiulxRK5YrNP+DgX7b/WuoA2TTVpXXvj2ai8vDXXmKS/RxzJszyQ4L8GT4A0IahYNg84wL43LzfXq9ugWjVMjpZCX0Ng+R2OkCA1z2Dt66n72tSKAXTSPU/v3vnH3Q3v9SlAu0SDucUbOgPVc5JncpDNBvanaj9Pcpu33BA9wHpD5VdrKpmXPAMfez3E0LjXnBKAbkdiQlP1LBueMr02O5t2HLscjsuck95oXWNfbjLnwbG9GzordXrzGybfx27jokBaceWj1L63RVHW5jz0yadE40pSe4El8sF0pNf3YHXdyBTh5k/vtxsSGKA2g95mqi7aCHUw0bAuccAFMQSf49I0tq+qwwmhi9U+MTs+4SJHUXi5FkG2YkvCIylcO8Fr14/lZrcwQ4ErtWs2DIFjY2Kedq+XadrBZMN2IlB0EkC0cyEhESsuozuHv6dFfwfpoJYTGA1F8JOxkTSocKsx/O+aABQYKzBPEjnSqgB9zBifQ7I6dNWRkcuereq4/C3QUdwNl1KTTCbNYVka75Uu/EomklSAiEzV8Nmkhw2GtOusUxUTMnoiVE59Nf1yFzso7qPlMvDlOAwSGnSlg0AMgfdQ5bzXBh GOE5iMbr 1b9KsdY7QWeG/mYMthOUzlbpyF39w6yE2kAMy6rdGpnwYrpXOumQ206rWynvJXxNK4J50NBszGypR3i7zYKZuq/dm5i1pdQNwxiNxZ1muTgz84p9ow8f6uWcvU3pSE1XMYddUsACMbwFDdpDyrViF+OxMtxVgO1eCU4wGYiSNtHD/L1H+ciT94srGqYxTk/oTX7yvpPfKG6XumsNvsMdeYbWaWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 18, 2024 at 06:42:35PM +0000, Shakeel Butt wrote: > One of our workloads (Postgres 14) has regressed when migrated from 5.10 > to 6.1 upstream kernel. The regression can be reproduced by sysbench's > oltp_write_only benchmark. It seems like the always on rstat flush in > mem_cgroup_wb_stats() is causing the regression. So, rate limit that > specific rstat flush. One potential consequence would be the dirty > throttling might be decided on stale memcg stats. However from our > benchmarks and production traffic we have not observed any change in the > dirty throttling behavior of the application. > > Signed-off-by: Shakeel Butt Acked-by: Roman Gushchin Thanks!