From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E311EC47422 for ; Fri, 19 Jan 2024 00:16:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4886E6B0092; Thu, 18 Jan 2024 19:16:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4384B6B0095; Thu, 18 Jan 2024 19:16:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 300246B0093; Thu, 18 Jan 2024 19:16:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 208B16B008C for ; Thu, 18 Jan 2024 19:16:45 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E9E54A2407 for ; Fri, 19 Jan 2024 00:16:44 +0000 (UTC) X-FDA: 81694144728.16.9A2BC92 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 930A018001E for ; Fri, 19 Jan 2024 00:16:41 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=E09b9+pu; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705623403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cyFCAw+3MWHn7kvC5txRDNiZL7S1o52REXRdj6L83qY=; b=1qFNxRz5NHe/5A0v0HdwiQe3KXtGGQpLaQvFi9N68sSa8Us7IAGCh1lUgWT2gPXvV4sIkF 8IXRfMjPaXBrde9hWaSVrEj1/sY1xe/uzpi72dai2McLJP9jt+MybMscQLxoSbmpGOYuua w+K9rx8boSrIbecbj8OhLOjxyKkkCqE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=E09b9+pu; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705623403; a=rsa-sha256; cv=none; b=7CGjyNt/Kbg2RfuyhPTVUEJm7LDT2q0OhPawRBHxhjp9DvxD8iPAMxJTh0S0TjNeR0wujM YGVXyWxrwFXisUjlY1tybjuI01vshhQTbcBEIWsUGSs6/9lNTKOB9dO3KJ3QTP5iFJQrKz X5i2kyMI2znktZLhRd1wKHyMbozOvR4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cyFCAw+3MWHn7kvC5txRDNiZL7S1o52REXRdj6L83qY=; b=E09b9+pu/yyJLV8I9ejzRpgg27 t2xrXuesPWZ4KyEi6kuTk33cV4T8pjHbRzMgUvjk1L9VGHpT0XE7+SPyOnurLRoq92kk+KYw2HFSU uP/mF+czpDJrS6uM6KmFpEqP0oM2Q8KzQK62tkjDIDtiQ1P/vv/TRG690RbIUdChuTnD7jTIKzDI7 6CvB/ST7kqIRVSldOwkA2eB+CIBF+hEdgDBRZ30thiN9jIa65dahYalITEEvPva0BIEWoaYXsIv8N YOYviveCFqML+Sx20pSAILQiSLE+horKBAPw44gYuSIkDWPMaOVNURbfR3QlOLZ1M8MhhXfcplxEP hDS80hWA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rQcYl-00000003Tb7-09Gt; Fri, 19 Jan 2024 00:16:35 +0000 Date: Fri, 19 Jan 2024 00:16:34 +0000 From: Matthew Wilcox To: Yang Shi Cc: jirislaby@kernel.org, surenb@google.com, riel@surriel.com, cl@linux.com, akpm@linux-foundation.org, yang@os.amperecomputing.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: huge_memory: don't force huge page alignment on 32 bit Message-ID: References: <20240118133504.2910955-1-shy828301@gmail.com> <20240118180505.2914778-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240118180505.2914778-1-shy828301@gmail.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 930A018001E X-Stat-Signature: segn1xbxpqk35up4pcemgowsjz19ucfu X-Rspam-User: X-HE-Tag: 1705623401-344289 X-HE-Meta: U2FsdGVkX18KAC0QopaLrf7i77Hc2AsHTu7M2Kd9ooL4yo7Fv2Q4Md7tCAml0IMuzjyr889UdEm821gDlJiXs0IDjYbZuyW2vXiSLmcyPNJVEOfnGxbdScwh6hvJRaSdVc5RZf2iJVTQg8WIr4zptI5U1Z7G9bmTia8HF6sNVBlznCN6SqLEl4ONrRubGkcWO2HcGsAbNzczLZnu5qH1rVYou+AstSw41XYj2UOg1dKXqNaXE+2ti99Iyh/25hc5FY3vA9aXlRJ3kCH0PddCQRE1I43HWP9bMfgVx0TjRd//nhbpJAZjq0RIpBgEQpxmbVMPAPnLU3lawLpJyge6333bw3qvdX3A50R/DG2/IglbF2iXpONbkt2suC9avdfmy47g3iNJ23bYQ6abpxclPPCOeVRWfuDjjLhCSclbATI/hff65ou6XsrdMS1ZPWi2V5yoTjrirLZPY8Agd6WvmXjkkcta/Av1dSTK80YvwGCphqxeF6oKZpyyvCSbuXWvRQS3I3XZfJDGmxZL+uY/Ojikmd3VxsjaPLzzzelc+xLqmaUhRH7qA0zVBAawOPuSOL2P1TfOXduKZ+DhaqzWG582cwbMyJ1Sb/eto52l/60cl/OLOpAa3fh8yuR/k2vP2SdqDRbCMZ/eVInCDJ2ILQrLpQ0bUB5/oNKXP1e2BG+mU1QHZzab7/riYLzydQGbgQ05Gazm0zPMVz16bah+2XJreI1TrW1P+4i7DdQU2s2VO+NQehfGElqwOd1zj7qN5h9DqiuHNl4JmqSmbIxgiGy7I0Gsoi4CXBRWadl4fMLi5QR8Z97MfFVAB6hqFWZP6NGNsW1k//OJL9KrMt2DP4NoXvwgRiUqW1y9J6+uZKnS9O5G93XHvuoD+1EML/mDL8nzkML7nbZyQrCcz25pWdJRnZohvlN7ufHc1yJbZRiEFsaje7q9L/0lQrPozpQW8uZs8yd32q8ogMkB1Md Zv3oX0kz iFV4HThUrKoa4GPDkuVEp5IYgaLVbiQ/ocSg/QCs/twRXxkdcjCLKQtGtbhJgiBEj+V1/dOcPe0DEV4NpY7D9RvQzwXlRTB6aMZolIMFdqstx4nScCRz7FZgf/HE32KKnTkbEYbVbYLoO4JzFRI2c3tcIVTT/c9EOP0eUzEV7IUgsKnYpu0r4jmEIFIaknKcX8u6/dNE/Q8xliT/9Hi8cAVgwrTPEcvPwLKRdHho0l3+Ibe4IoHt+tNVSF4LXy0PuZRm6h1M7H9Zqy35yv59NIb8he2875K0H72bBcymMnV4WI33Nwy2V5bSHPjDSVvyEH5p6KtvF3voG7DQ41kmeFnbX+ZtTPh2hf+t+Fru1gPd4umHn7ODBon41yXgufRckynnTm2jvL3U/BBCOL3PI7W7d5feecBpVltN8TPRiwcIR5DERd6uhK0xlMaWSJD3hFS3ghsYJwGIbhwulAOB9ZZ0p8H/ceP+iWMHes2jY3BdDMWKn0cr1RWL2AiF0n43lf3B7xCAhCyoN51NGoaQ9xws36Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 18, 2024 at 10:05:05AM -0800, Yang Shi wrote: > From: Yang Shi > > The commit efa7df3e3bb5 ("mm: align larger anonymous mappings on THP > boundaries") caused two issues [1] [2] reported on 32 bit system or compat > userspace. > > It doesn't make too much sense to force huge page alignment on 32 bit > system due to the constrained virtual address space. > > [1] https://lore.kernel.org/linux-mm/d0a136a0-4a31-46bc-adf4-2db109a61672@kernel.org/ > [2] https://lore.kernel.org/linux-mm/CAJuCfpHXLdQy1a2B6xN2d7quTYwg2OoZseYPZTRpU0eHHKD-sQ@mail.gmail.com/ > > Fixes: efa7df3e3bb5 ("mm: align larger anonymous mappings on THP boundaries") > Reported-by: Jiri Slaby > Reported-by: Suren Baghdasaryan > Tested-by: Jiri Slaby > Tested-by: Suren Baghdasaryan > Cc: Rik van Riel > Cc: Matthew Wilcox > Cc: Christopher Lameter > Signed-off-by: Yang Shi Reviewed-by: Matthew Wilcox (Oracle)