From: Matthew Wilcox <willy@infradead.org>
To: Yang Shi <shy828301@gmail.com>
Cc: jirislaby@kernel.org, surenb@google.com, riel@surriel.com,
cl@linux.com, akpm@linux-foundation.org,
yang@os.amperecomputing.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: huge_memory: don't force huge page alignment on 32 bit
Date: Fri, 19 Jan 2024 00:16:34 +0000 [thread overview]
Message-ID: <Zam_Yv8ZLnNseBOW@casper.infradead.org> (raw)
In-Reply-To: <20240118180505.2914778-1-shy828301@gmail.com>
On Thu, Jan 18, 2024 at 10:05:05AM -0800, Yang Shi wrote:
> From: Yang Shi <yang@os.amperecomputing.com>
>
> The commit efa7df3e3bb5 ("mm: align larger anonymous mappings on THP
> boundaries") caused two issues [1] [2] reported on 32 bit system or compat
> userspace.
>
> It doesn't make too much sense to force huge page alignment on 32 bit
> system due to the constrained virtual address space.
>
> [1] https://lore.kernel.org/linux-mm/d0a136a0-4a31-46bc-adf4-2db109a61672@kernel.org/
> [2] https://lore.kernel.org/linux-mm/CAJuCfpHXLdQy1a2B6xN2d7quTYwg2OoZseYPZTRpU0eHHKD-sQ@mail.gmail.com/
>
> Fixes: efa7df3e3bb5 ("mm: align larger anonymous mappings on THP boundaries")
> Reported-by: Jiri Slaby <jirislaby@kernel.org>
> Reported-by: Suren Baghdasaryan <surenb@google.com>
> Tested-by: Jiri Slaby <jirislaby@kernel.org>
> Tested-by: Suren Baghdasaryan <surenb@google.com>
> Cc: Rik van Riel <riel@surriel.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Christopher Lameter <cl@linux.com>
> Signed-off-by: Yang Shi <yang@os.amperecomputing.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
next prev parent reply other threads:[~2024-01-19 0:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 13:35 Yang Shi
2024-01-18 18:05 ` Yang Shi
2024-01-19 0:16 ` Matthew Wilcox [this message]
2024-01-18 20:14 ` Matthew Wilcox
2024-01-18 20:39 ` Yang Shi
2024-01-19 17:16 ` Rik van Riel
2024-01-25 8:53 ` Michal Hocko
2024-01-26 9:36 ` Jiri Slaby
2024-01-26 9:41 ` Jiri Slaby
2024-01-26 10:51 ` Michal Hocko
2024-02-03 9:24 ` Thorsten Leemhuis
2024-02-05 17:07 ` Yang Shi
2024-02-05 17:53 ` Linux regression tracking (Thorsten Leemhuis)
2024-02-12 13:45 ` Thorsten Leemhuis
2024-02-18 9:26 ` Greg KH
2024-07-11 20:10 ` Yves-Alexis Perez
2024-07-11 20:47 ` Yang Shi
2024-07-11 20:50 ` Matthew Wilcox
2024-07-11 20:53 ` Yang Shi
2024-07-12 14:41 ` Yves-Alexis Perez
2024-07-12 15:31 ` Yang Shi
2024-07-11 20:52 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zam_Yv8ZLnNseBOW@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@surriel.com \
--cc=shy828301@gmail.com \
--cc=surenb@google.com \
--cc=yang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox