From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BC1BC4707B for ; Thu, 18 Jan 2024 13:52:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C30DC6B0088; Thu, 18 Jan 2024 08:52:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE0E46B0092; Thu, 18 Jan 2024 08:52:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA83D6B0095; Thu, 18 Jan 2024 08:52:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9E00F6B0088 for ; Thu, 18 Jan 2024 08:52:52 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0EDA680CF7 for ; Thu, 18 Jan 2024 13:52:52 +0000 (UTC) X-FDA: 81692572584.06.C02A1E1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 741AEC0021 for ; Thu, 18 Jan 2024 13:52:49 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=f9C8gWyt; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705585970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W9/7D8zr0MVRfo04WFLM2Hg/uD4l3zgSP1ZQDm3F38c=; b=r9fLMrSQQVW3Ce8LzX+/GN28vi3iFN9EfSJBxLkJH2e1BMK65t8CZYjrc6mkT6PgEn5FkR tth4a1lQZ8Tr43EHWoOFHz+Ggr75R2s2vLxQQiGwBkMU31fbAIUXkZpG5he8n6I4ePVZfk 2U+6kwRujEkXagcPGfVyzFydKEtYwQU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=f9C8gWyt; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705585970; a=rsa-sha256; cv=none; b=HtlWTF5pDYZbNTBH3eTGTrGlyyGOAG9/2q/4rxvwzTT+a8yBzcjgJb/4xo5AzsOKl29KKZ OdyfCGjdaPsYzvZxNviwEaOaZRq0cPZi3G7Ia/dWmryvdy5YELWqKuJ4Wl7g4aNorZ8K9b HrswQTxo+JCq0r8sz6jLAw6v4UdizT0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=W9/7D8zr0MVRfo04WFLM2Hg/uD4l3zgSP1ZQDm3F38c=; b=f9C8gWytSlHaoCzve+NEsrEN0e n8GeYnFhf3w7fe6Xw8td+APR8rQXPLRwAF7vCPFKWGXjIaRjskZQJ7IsNalOZHxSiZk47mk2LSHAu kuKrRDc1n2Qpgu26poeGELzxdXMKzUMwCyUyPlXV2zIuEPmDSbxFUUDbHvejN/lhDr5kFGBZoNGtE uPqdWKoRVl58HFQjNZ/83Np9JhKExqqraKnhnOEBoS5sFsc8cZveEvgYe560um2sl3qADr9tyMwXa KwS39DRsbH5X6UfN3pO3ONh7noHCZxZo7ImWO6a6EsYtjPTo+bMGVcX9V1fNtfSdCGpjn2FnvznND ftuH64Ig==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rQSop-00000002JMU-2dbI; Thu, 18 Jan 2024 13:52:31 +0000 Date: Thu, 18 Jan 2024 13:52:31 +0000 From: Matthew Wilcox To: Yosry Ahmed Cc: Chris Li , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Wei =?utf-8?B?WHXvv7w=?= , Yu Zhao , Greg Thelen , Chun-Tse Shao , Suren =?utf-8?B?QmFnaGRhc2FyeWFu77+8?= , Brain Geffon , Minchan Kim , Michal Hocko , Mel Gorman , Huang Ying , Nhat Pham , Johannes Weiner , Kairui Song , Zhongkun He , Kemeng Shi , Barry Song , "Liam R. Howlett" , Joel Fernandes , Chengming Zhou Subject: Re: [PATCH 1/2] mm: zswap.c: add xarray tree to zswap Message-ID: References: <20240117-zswap-xarray-v1-0-6daa86c08fae@kernel.org> <20240117-zswap-xarray-v1-1-6daa86c08fae@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 741AEC0021 X-Stat-Signature: gxmkjuuuk67fsh1y4jxjgossdzayj6ob X-Rspam-User: X-HE-Tag: 1705585969-979743 X-HE-Meta: U2FsdGVkX197l8VzTND2OAuuUiieYO4Vr4dd9LMjw+EL7+gozXPWwLu6ZTKpTp/nbhsA8UCejtVzQOYMRQ0eVcbedqgVWY/4rc7Km9JYwyoFZvInol7HsY8wtvj2u4egYRRuSqCvyK9fzSF4wZsrkfMfSpnMNoXwPw9DwboDKcr7Tr7LLUXC2cR7qVEDTELUpcaZ1bx2okta19b3VNptKJwXFscMdU/69nYcY2UFkq5OtwAMWJp/MtMJOcOndE3MjSkj7gJ9P+Kw2WcBbvHimBCBdPwbWZsrRoboQ9YHK4Cgn0kSqIqw86kut+7O77CZwpvcPwY0euM7aLt6Fy1wSvAZDbX2cGC9pdyLxnQCHy+5dCwkspsuDDSnZ/c2aunlT55b1XSbNbrWltYZqnMGZbDC5Lz2icGGRBUHEdyjrO0EtpePCVj6GQucjR4bM9aIEVb6nf8bK8T+kvXeMyAD8wPmhWxXz9Eay+P7FEtnWm5EdYiiF2dCOSNvM4aoyTMbsD3ignefAVrIkH879dOJDw++my/ihJQTp4NV5e7bdieLJV4XvIOkquML2+jqC8YJfJUk145PyxBKM6NldeUxkpGAA7l6Xo5ej8YIAl4UtCAMzlZLP8KMxXVVr/aY14Q3PkBi/t0K2o3LRYK/TnrbiItrz/a/XXSL+t3lnDEHa6MAKH6IXmHsVHarWJHvZx1hrid+YDrkcKWf7B64JrVfJdih/Fb0c/pqWLqCr+lFMuzKmj8dAiQCLXPLR35t7CC2MFoZMV2kQcoBWtgRadMTwH6WBFVwM+54i3rq83+KtGUWKJwdixHOQnG+8kHWjsK0UA28zV3a3EtvR+eJw9lHvAfJIgIjPwE+cnv9SBk+bjJoaGGI7K9hkWl2ZaG/ssqtJlN1B6sX0THO6p2OlMdzIzLr5Tzlo6r+RjaYj9quTBO1skDHffsKoZDuEfMVxoEOjPptdSQtDDWrejXC/Cp hkYhzNMl xsCng0vac+R0Yr8uSrMAw+RNJxHe4SciLddYUcznIMTLdPAr14VwXJhnkRTuhIJSvQoLJVhWv4bl8y2qaqEUymE67AD2DjnScWycUn1MtRv3E3ety0ZBEYtuApApw05mqajMBAC5jbhVlNow= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 17, 2024 at 10:20:29PM -0800, Yosry Ahmed wrote: > > /* walk the tree and free everything */ > > spin_lock(&tree->lock); > > + > > + xas_for_each(&xas, e, ULONG_MAX) > > Why not use xa_for_each? xas_for_each() is O(n) while xa_for_each() is O(n log n), as mentioned in the fine documentation. If you don't need to drop the lock while in the body of the loop, always prefer xas_for_each().