From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D5FFC47077 for ; Tue, 16 Jan 2024 21:04:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5CEB6B00A4; Tue, 16 Jan 2024 16:04:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A0D0B6B00A5; Tue, 16 Jan 2024 16:04:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D4666B00A6; Tue, 16 Jan 2024 16:04:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 79E276B00A4 for ; Tue, 16 Jan 2024 16:04:09 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 37386A2139 for ; Tue, 16 Jan 2024 21:04:09 +0000 (UTC) X-FDA: 81686401818.16.F0C3FB7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id A566120016 for ; Tue, 16 Jan 2024 21:04:05 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZD1zCV09; dmarc=none; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705439047; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aa38REvmK5S3+j3Zy/vUzY/XryNOBNttaU4QwgDik0U=; b=AkeN3fiyc87OJ4tdcf7NKMort3/MTCboYKip9ug8gt6rqCFBo472Wima6G8QKjBcQ0JtgL yngrv06A5TbvAYbP3EazfVdce5u1Ht9ln8jYvTDcgtsE6lNgLl9oVyeEDtNdQD+KvHGorW a/icd8Xlsv/FdmlhGFHy09pjKGpKTBE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZD1zCV09; dmarc=none; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705439047; a=rsa-sha256; cv=none; b=GUW5niLutVdZB1+eqhFQ2EsKYSDgHXRgRhVMPmI6qJirnryjGCDzhFanRSjzA0dYOrfyaa MHquDvLEtxmunx/RpipyxXMkQI4ZeOPQ6BZnazrZPop3WsCwyhGHRJYuOROv32Ra0He8hY c/q9XTZLue/Sl9sHf2qkQExj2FbNwII= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aa38REvmK5S3+j3Zy/vUzY/XryNOBNttaU4QwgDik0U=; b=ZD1zCV09Oq+I4rJmtS5wN0PRm0 fJdNb3aM9r36OOMvAs/5QRE/5R5VZWc8WcrWXNXB+1rD/feUafNjoeT60278cBB2T/W/Kr2EiUt11 D2iXWz/8ZfP0lmqUMo8xOGNjvC+GalOYOn3N3hA1c9r1pSAfVpnAHYjFFw9z2v7dNaPK4Z06kJRye 2oPeRc2z/bU6dwFsUnziV3hqKQCrc5mpRYF1pPl6XkNuTB8LHKimYLg6oUADJ3zSuPtreFTGjCz0q QHpK+JajFA/UTuV8pjoX/vmdNJ1UgZvhs4E7UBuRlMC7hmmUNZW1CXkFHwtY84I/sp3S8xQ46V2n4 L/KIfjZg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rPqb4-00EFWM-Lp; Tue, 16 Jan 2024 21:03:46 +0000 Date: Tue, 16 Jan 2024 21:03:46 +0000 From: Matthew Wilcox To: Zhongkun He Cc: Nhat Pham , Yosry Ahmed , akpm@linux-foundation.org, hannes@cmpxchg.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chris Li Subject: Re: [External] Re: [PATCH] mm: zswap: fix the lack of page lru flag in zswap_writeback_entry Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: A566120016 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: sqz7s31c91cj4scyiwfpe9wc1reijps5 X-HE-Tag: 1705439045-578932 X-HE-Meta: U2FsdGVkX19Ddy0ZUsA5YzhVhJ6bvmDEOU86reubRAADfimhK5k9Q0yoE2615EkbgNFfUcPS5rIpOtzmB9w9a7KOrX1uNdTlhj3iQEs8swlrbu60TvCBeB+XQ8UB9BGJbyiK53wncY4WsHH0Rhl9/GEJkBlE5+kUtPjfCnJSeTcahAjZ97w6D3kBKVyziOqiUHLIkRIFGI1+oPN5z78HL2fHicAX9bDlhot8I53Ni/KErhYtNDOa0FqGMMZOjoKhMQpOErNq8wfgoYacT1idNkGJEhwNL/v7k1KHfrGN1I8QL2u0hjt5w75g8V0tDnGkluW+I03Zo7+PATMP7P8wvP/PuFMhGWWmjIfiHTpK2Fi3udNSQ9Bj2Y+Mi/WmpE1Mw3xGS0vPIcSjDk/c0wz14stV3/WxN6QXWP8qYbmyU3++prk43qa2rDaLhx/+E2CyiNI+B2lJD8iRiKJIu8xicI5hWOsA0gyHJcGxslZzbZ2HdU3QX1I/IGkAgA+VA118Y1v3IHfvnleQxn1Myd0uj7QIA1MqTxG8/wcfwt8M3d7K8H7GCq8BZ8wK++9nNyvDs4NWV0nWbDSBHTwesJ+BEsalKDCftG4Dx6EdJIxX51CZ7TGzhT3vlDm5Pa5/2Ji9YyHsEBFfZVOBf12ORntpJzFXsob6uJq3xH66cAb34a7uOkQLzItnaSdfGLejIj3PVhDsJEZCwfksmhsHZv+N0gYZNI2hfRxzfbyCLDfiQePIr+bEvlpyvp+dNJECvE0hOBPy8KHuWb4feiuMk5Zx0mD1XUSIatESAHghrR/Gsyg8Ng7ICGKXYhx1zDMIVLhuX1Vge4Hgqx5c/hs0vxWgKuTumdod8GtdD7kKBEgWG7b+6W6dj0YJIC21pub+kAizL9UGKxklb3CSkujn1Lyl85FHdYO7RRcqduAiLNz01qQm0KmMaSjrp/4VoBIJ9IRJphyLXXtUGxiWOb9pe8+ hyTrXOEe abFU56ChSolQL31t2lg6+Q3M81dsq+bL1wjZN0JxA/PU3N4C40UcpfSCNFdyrzfZ4c0tTMcviEGBZ++pWlqLlc04YBxbVnm3rymM/wJNRWjz+XmVT6YT8D2PlODXNDK6S985biFCLQZvON9jqaYFArTsJ47NW6UPJYhUyfC9OfJxDRBSA4fFjQE+uvspy9j5b3jflGWEjRm3mqMISwUQBsyYZOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 16, 2024 at 09:40:05PM +0800, Zhongkun He wrote: > 2) __read_swap_cache_async has six parameters, so there is no space to > add a new one, add_to_lru_head. That's easy enough. Define a new set of flags, make one of them the equivalent of skip_if_exists. Something like: typedef unsigned int __bitwise read_swap_t; #define READ_SWAP_SKIP_EXISTING ((__force read_swap_t)0x00000001) #define READ_SWAP_ADD_TAIL ((__force read_swap_t)0x00000002) There's only six callers of __read_swap_cache_async() to convert, so not really a big deal.