From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3058C4706C for ; Tue, 16 Jan 2024 08:39:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37AA96B006E; Tue, 16 Jan 2024 03:39:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 32BFD6B0074; Tue, 16 Jan 2024 03:39:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F2546B007B; Tue, 16 Jan 2024 03:39:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0DEE96B006E for ; Tue, 16 Jan 2024 03:39:50 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BFCFD805E4 for ; Tue, 16 Jan 2024 08:39:49 +0000 (UTC) X-FDA: 81684526098.09.71E431E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 0DA9040009 for ; Tue, 16 Jan 2024 08:39:47 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=akc4r1LU; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705394388; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MjD/D9BDOc2zNikcvdOzeLq1I8/Yv/P6iCtAqsKgyqw=; b=ZrjkFlHLmLIk8I90KwBHn5TTrakgGiOMbP9Il1v9qtwRYSp/POltEBPNeuXSEyHTC3cueu tm6pN46edgILyDVn9kZlmMGlLzxHcyDeVl36G6hfscS60Zo9Nt4UmW/K47Hc7b3LLAFaJ5 aA0tPt1eJp02HYSdPzZuK14qwAZDEO8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=akc4r1LU; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705394388; a=rsa-sha256; cv=none; b=Kw6XdUYDj1hNhkliWAyniwCiKVaHQmXY4QUi5gEsiAR07ZFUPpCSSz8KMQ2C9HQdccDEjH zkb8PNBjkf30XqLedNgG7nE5fZKjwZ3pLFLC8bXGqTR+Ush02goONQfySfhQAbI9MZDM+/ FQAVdBMbCcVMolNknIVFmIXXX11AstA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0A73161092; Tue, 16 Jan 2024 08:39:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFED1C433F1; Tue, 16 Jan 2024 08:39:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705394386; bh=zMBkNvcbW1+IjSGQQV5Zw6ssVa4un4ZiyvEjDOZ0/UQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=akc4r1LUSBobkRaqvTAjbmScrg3YVE9bgsGUF/R4Deev/WicJd81uP8RUtACPi+1Y ijs7qcDxLzOAa+xAz7a6M747uoIxAQo5W1buqO6IbRYpNLARGM1LZlKLpCzpaPanoJ HtCh/TOB3AMTxe/irtQDm0KrDJXZGhVCf9X6hsMyQiNY6/4nMdfzHmAGTM9to2Z7Fx tN28jAtzPrfmeKqGxcxuV+Rqc/NBoc4Yb262+SXGE0k7qlzQxm5ZY15dboItZUG56h o9+hrfGKOlQwMVMafr2ueLWjfs1fsjjVFRKsFgLCJKj8lC1tFdXaOcXSzeLm+7qHff o+GRrPnB19CCA== Date: Tue, 16 Jan 2024 10:39:04 +0200 From: Mike Rapoport To: Jiaxun Yang Cc: linux-mm@kvack.org, Bibo Mao , linux-mips@vger.kernel.org, Paul Burton , Li Xuefeng , Yang Tiezhu , Gao Juxin , Huacai Chen , Huang Pei , Thomas Bogendoerfer , linux-kernel@vger.kernel.org, Yajun Deng Subject: Re: memblock_reserve for unadded region (was: [PATCH] MIPS: loongson64: fix boot failure) Message-ID: References: <20231225093025.23215-1-huangpei@loongson.cn> <731134fd-4b3d-418c-84ee-80646bffcc01@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <731134fd-4b3d-418c-84ee-80646bffcc01@flygoat.com> X-Rspamd-Queue-Id: 0DA9040009 X-Rspam-User: X-Stat-Signature: kjn6jxmy4feuuh3qpjyngt8qgcjgnsro X-Rspamd-Server: rspam01 X-HE-Tag: 1705394387-663914 X-HE-Meta: U2FsdGVkX18t9mtI2s5DLR6p8xnTKDoZmftp0bhRcsoZnF024YNry0H9Bs5mrjEcUcRnPJzScPWRC2rQXAwjrfGXMUiWnHByBZLZKSS7wrvunOUOt/AXjB/LcmXW+KldZxS//u1jgzrTx39wj19kTMoiY8Ad1HG595cRzbT4kjaeCkFsO9OjiGmrsX1ZLY/fEDAUofqopbmjvLhMCuUIcgdGc9DL90p6UhwZqo7E/sx/2CXsHPxaU/BPm4qqRfTRZdltFR0BPScRiio+f4upMNi6E/lEeca6Kpy4ZZq9zN9SEc/jGZ6V7+EugRQc/k42TNE0YvJIxFe8g1f7QfqJMUO65vq0oFjWHxRm5sDqBP6+qMiqbs9NtObdiRRY0vjL2MfyJZDcELjk1oK5LciDrHwQA/cpTJ5qV4NeFyyurIC7zWvgfo0nEghS6TYXmkgifpUb9ti0ft6LEnDSoSaMtbW0iTuCXub0BD9SQ7SCJRh909vA/4sIZITjooFFnQY8NAMZqQmqNeP4ZVBwONpVGGFCkDuOQeGIeG2euYbhalSqSPdqJ4ONnxNKFHh9c1kvXP5cewCWkvq/6ziTRxlJqLk0EPpIh6KqrGqOgfQwiV7FlKuOo7dQkKQCe/b6hjgfEB9L2v3FeybgWAma88xb3YrVslCxtoR/LD2xX3tkn/OSUN2N09iDYDusV+v7Y8GvQJ85jnUUJANI03vLzGbXHbRzsKunkzXvGRJzltrdSdWQTGcCBq1Xk6vuSUxqpqLKXlCgS+Qq8lVmQiJSm7fRUJoR+g7/Am2ykoCFHSg1Dtjn5g8Blz2+I+d1csORI70ODIYz/gipBBjWSw8DIDjf+fjMQc/6G5F1yj1/Jm9EaMlzIJ9pbmtaajXxWqsvgjsuEdQdXhTg1Ai/vWslOt424HZuly44YLxLOqo0TyD57yfx1LXvCTYaQltvSP+oFYNeH25eua/foVmxOQK9aW9 MurZbHgg HSFDrGY6uT03g6J7ghotNVFuxnBMqrUk9rrpDRzgqRXqNReRIBJu8fKW2vfDJrWC1wsXNLVEH0vIxNGh7zyTKDfNHFwJvvkzGZNQIxRw66UpnxhLLr4ft7lzkoZUEGzQlwQzkbb80zSorRwqiIII0TVTg1j/UJ9HB9HXX9SJJpa83ViekRZl4nt7DKweoB/2iBRUdWIC8rq7cCgcrPdQBsaUwvNU0vm6oF/gCSrbGyW1qxO9Q+vgi8MOXqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 15, 2024 at 02:08:21PM +0000, Jiaxun Yang wrote: > Hi mm folks, > > Just a quick question, what is the expected behavior of memblock_reserve > a region that is not added to memblock with memblock_add? > > I'm unable to find any documentation about memblock_reserve in comments and > boot-time-mm, but as per my understanding to the code, this should be a > legit usage? Yes, memblock allows reserving memory that was not added to memblock with memblock_add(). > In practical we run into uninitialized nid of reserved block problem, should > we fix it > in our usage, or on memblock side? Apparently it's a bug in memblock :( If you revert 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()") does the issue disappear? > Thanks > > 在 2023/12/25 09:30, Huang Pei 写道: > > Since commit 61167ad5fecd("mm: pass nid to reserve_bootmem_region()), > > loongson64 booting failed with CONFIG_DEFERRED_STRUCT_PAGE_INIT like > > this: > > ---------------------------------------------------------------------- > > Call Trace: > > [] reserve_bootmem_region+0xa8/0x184 > > [] memblock_free_all+0x104/0x2a8 > > [] mem_init+0x84/0x94 > > [] mm_core_init+0xf8/0x308 > > [] start_kernel+0x43c/0x86c > > > > Code: 10400028 2402fff0 de420000 0203182b 14600022 > > 64420070 00003025 24040003 > > > > ---[ end trace 0000000000000000 ]--- > > Kernel panic - not syncing: Attempted to kill the idle task! > > ---[ end Kernel panic - not syncing: Attempted to kill the idle task! ]--- > > ---------------------------------------------------------------------- > > > > The root cause is no memory region "0x0-0x1fffff" paired with > > memory-reserved region "0x0-0x1fffff" and "0x0-0xfff", with "memblock > > =debug": > > > > ---------------------------------------------------------------------- > > memory[0x0] [0x0000000000200000-0x000000000effffff], > > 0x000000000ee00000 bytes on node 0 flags: 0x0 !!!!here > > memory[0x1] [0x0000000090000000-0x00000000fdffffff], > > 0x000000006e000000 bytes on node 0 flags: 0x0 > > memory[0x2] [0x0000000100000000-0x000000027fffffff], > > 0x0000000180000000 bytes on node 0 flags: 0x0 > > memory[0x3] [0x0000100000000000-0x000010000fffffff], > > 0x0000000010000000 bytes on node 1 flags: 0x0 > > memory[0x4] [0x0000100090000000-0x000010027fffffff], > > 0x00000001f0000000 bytes on node 1 flags: 0x0 > > reserved.cnt = 0x1f > > reserved[0x0] [0x0000000000000000-0x000000000190c80a], > > 0x000000000190c80b bytes flags: 0x0 !!!!oops 0x0-0x1fffff not in memory[0] > > reserved[0x1] [0x000000000190c810-0x000000000190eea3], > > 0x0000000000002694 bytes flags: 0x0 > > ---------------------------------------------------------------------- > > > > It caused memory-reserved region "0x0-0x1fffff" without valid node id > > in "memblock_get_region_node" from "memmap_init_reserved_pages", lead to > > "reserve_bootmem_region-> init_reserved_page -> early_pfn_to_nid()" > > accessing "node_data" out of bound. > > > > To fix this bug, we should remove unnecessary memory block reservation. > > > > +. no need to reserve 0x0-0x1fffff below kernel loading address, since > > it is not registered by "memblock_add_node" > > > > +. no need to reserve 0x0-0xfff for exception handling if it is not > > registered by "memblock_add" either. > > > > Fixes: commit 61167ad5fecd("mm: pass nid to reserve_bootmem_region()) > > Signed-off-by: Huang Pei > > --- > > arch/mips/kernel/traps.c | 3 ++- > > arch/mips/loongson64/numa.c | 2 -- > > 2 files changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c > > index 246c6a6b0261..9b632b4c10c3 100644 > > --- a/arch/mips/kernel/traps.c > > +++ b/arch/mips/kernel/traps.c > > @@ -2007,7 +2007,8 @@ unsigned long vi_handlers[64]; > > void reserve_exception_space(phys_addr_t addr, unsigned long size) > > { > > - memblock_reserve(addr, size); > > + if(memblock_is_region_memory(addr, size)) > > + memblock_reserve(addr, size); > > } > > void __init *set_except_vector(int n, void *addr) > > diff --git a/arch/mips/loongson64/numa.c b/arch/mips/loongson64/numa.c > > index 8f61e93c0c5b..0f516dde81da 100644 > > --- a/arch/mips/loongson64/numa.c > > +++ b/arch/mips/loongson64/numa.c > > @@ -130,8 +130,6 @@ static void __init node_mem_init(unsigned int node) > > memblock_reserve((node_addrspace_offset | 0xfe000000), > > 32 << 20); > > - /* Reserve pfn range 0~node[0]->node_start_pfn */ > > - memblock_reserve(0, PAGE_SIZE * start_pfn); > > } > > } > > -- > --- > Jiaxun Yang > -- Sincerely yours, Mike.