From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D89AC3DA79 for ; Mon, 15 Jan 2024 20:31:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7565F6B007B; Mon, 15 Jan 2024 15:31:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DF506B007E; Mon, 15 Jan 2024 15:31:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 532306B0080; Mon, 15 Jan 2024 15:31:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4279A6B007B for ; Mon, 15 Jan 2024 15:31:44 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 221F5405C8 for ; Mon, 15 Jan 2024 20:31:44 +0000 (UTC) X-FDA: 81682691328.23.2B66937 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id EFB14C0028 for ; Mon, 15 Jan 2024 20:31:41 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q48+waAV; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of leobras@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=leobras@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705350702; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oo1lY+LUrPGNJa+47ZTljwNXvGKmrXfZHob6MgR5Xqo=; b=W9FRuYW7/OCkBlGs7f//3i1c/6NOwV6KvG7xfo8HiEedW8k4CIQD1nn0vo23dp135lS5qn Sk1VEg73r9dgEzRkvyHofObWUWtZA8jBh9VQ+aK1OVCTAQ/+Ffm2S0yFhGwxLdg5Zca+Yt lh69GgojjAK/q8r1G5U5ymZpjE0ueeo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q48+waAV; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of leobras@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=leobras@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705350702; a=rsa-sha256; cv=none; b=vAsQu6zud6Qz/pPXTXCTXpfFUf5gymgCmbqkmBnCh+SwBvmaW5et6gBa6+dupBQV0/m05Z sYjE0bwWRoEHeEFkh8SXaBWVzMg4+j79ZDQNnLsf0MjofnGlBa4obzywSL6PiVb20moTmH FgrMG3XMOkWMWWbZCEdnKhcl+GbqICs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705350701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oo1lY+LUrPGNJa+47ZTljwNXvGKmrXfZHob6MgR5Xqo=; b=Q48+waAVi+zmq6oeg7w6ivioee5uFrtiUBzMaEou4uj9uN6r55BXeKZqF9nirFL5eEa/fW IW1ndXDFtE7UYTGInqJ70XD+7XzBoZZBTNdjk4ocfWe16fV/sMshcx7j6HDNEX1rIBC6YP tXDqZLrmEM+XxzHNn0SPawmG90MEwuY= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-340-f0yTcwBYOBWCQ2avB_QXVg-1; Mon, 15 Jan 2024 15:31:39 -0500 X-MC-Unique: f0yTcwBYOBWCQ2avB_QXVg-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-429ad752bb7so88319911cf.1 for ; Mon, 15 Jan 2024 12:31:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705350699; x=1705955499; h=content-transfer-encoding:content-disposition:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oo1lY+LUrPGNJa+47ZTljwNXvGKmrXfZHob6MgR5Xqo=; b=r8kf+r0/GjfmrC2/cJD1+ouQCT1qXonX5g0r2O97p8h48MQQRJam4L510eNOf2R1qS 2ZreS+Ie1KTvSxiLjrrDsMCBgIFT5mFp5QVtwntDSXcNnKHgPjU0O3QKIzA7bp4Dh8Ko 67A6kqzr3eUUsLtPT0Dlb1Pv6Qx4Q5WJcnMnkFIYEO9lrTfLncp+kcPgrVWJe1sZKGZI ibc1bSzysSCayydzq/sPAKNp0I9/WAZl2EE/vZE0TlUa+QP6sui335u6WWCNrzGxlu+V 9xbjsccQerEYHMgbkwto2YR7Y0JPDehh/Lt0GaGAs/N6nAmJi+i9EFFVkeC0bxyydKpy rrIg== X-Gm-Message-State: AOJu0Yz4+/ZbQB1DyixG+PxKKznm894trYDX9T6cNFdiXwerhXqvMskQ Vd42CY77XBW+mtijsXdl1/FXCsNY6QaOhwjWlhXJyfLOYKVrIwfYKw3L/LzG6lRagUtDJgW4DoX RyQT6FJezTyaaQ1Kj468= X-Received: by 2002:ac8:4e4e:0:b0:429:fa83:f4c6 with SMTP id e14-20020ac84e4e000000b00429fa83f4c6mr1096574qtw.39.1705350699497; Mon, 15 Jan 2024 12:31:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IF1lwPkU57DLGFNnwilIHpZk2wzak6MjnE6mfdGCBA9zzIH6qjYFqNMw/TYhiKlJvicPTHWSA== X-Received: by 2002:ac8:4e4e:0:b0:429:fa83:f4c6 with SMTP id e14-20020ac84e4e000000b00429fa83f4c6mr1096561qtw.39.1705350699222; Mon, 15 Jan 2024 12:31:39 -0800 (PST) Received: from LeoBras.redhat.com ([2804:1b3:a803:26a5:3f32:e12b:5335:3c2d]) by smtp.gmail.com with ESMTPSA id jz4-20020a05622a81c400b00427f02d072bsm4132051qtb.95.2024.01.15.12.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 12:31:38 -0800 (PST) From: Leonardo Bras To: Kent Overstreet Cc: Leonardo Bras , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 16/50] sched.h: Move (spin|rwlock)_needbreak() to spinlock.h Date: Mon, 15 Jan 2024 17:31:34 -0300 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231216032651.3553101-6-kent.overstreet@linux.dev> References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216032651.3553101-1-kent.overstreet@linux.dev> <20231216032651.3553101-6-kent.overstreet@linux.dev> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 6yrr94q5ukeg13xmsm7ino9asqxumiax X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EFB14C0028 X-HE-Tag: 1705350701-233107 X-HE-Meta: U2FsdGVkX18gK9h5QOi7temN4FFDxUjj1e4YJoeDR2jH6GyzwKLigWPhxwEpaSjg96f9y8vyfuFc/eutaWCEZIubLAzU9cnfX2hNQcK/cfNc6dAXyOvOiC5aFoxHqr3PjznktQ7RXNIfgsuv17ltSNaVcjdFwD7nP7cnIa7kKkAXwnKNx6Uz0e47tULptNejNVoLiZexUOxcTifq01ljYjl9vD8po7v0QpPu4WK/8eOjh8h1vcCfqRnIkI2IdYYAPTAgfoMOLWE/qWKFe0lRJ8d9qKhHtndgNpQbNpe5L06Lx0uzXZgGelsJGEiQiawgUsek5a6iAraXHBeZyVmTeAy9bV6+GjCqUk7ETvtsmcPrtuTkHZKXTwLnhNZ5ry/CaqL38FAatHJfIV/4/N962S0r5dmGvlw5lXRuz4F72iNeWLcJeeL8OrCoXHKDzoqhokil4KxJpOYkm6WvUi8NlnS+WQBCnjvoswJdOaSaM01lM9+/ddEoTDuTFnABszerPh6CEAq5YVH45AEzkHAvx8H4bMFoQVoFhEVcGk8pl8FNXxRsmqefD3rDa64tZ1IyAPF7s9n/tFV3cfwSuB5ySE74RufPtpLyY5uxP+buuSWMYQQUxjjj18plLSdzIoeppBOcPvy0ypbMh/zUZ5A80eRirhYbfnizXz2MEC462nSEiics9qy8SEpQ9qd7dkRd1Qb3iM20s2K4UHHvKA7ay/uw7jQPSZbAWP1OqgMqPQOo/b+6kq5RdR2ZC/iC69TJKMX3mvrrZq9ikgBLd4argAk2dTlRGX2NgiFx+4l9dcuFVLGYanO+HJ2Pd2P4HfRGV8aOjyS72YzFjSt63VdFefKqDDFd/PYqAX6udTxEpPU31MPoxUAM8sNoXpvLakkVYg65n9aLG5k1d5yGiyY5Ovwa6ke7PzVP9py93uaV+MzwjZElrYX5dEvt/suKQjZu60/0SzM5l2be5Hz1dZr 4YhbfsPf YxPiywxG8PYXPysKzA2mIYtCOb/XNoaLCdCfFMXYKUN2NjM4XArsROagyWtLvwthRmuNzWp3fxPc3jLki5g/xF8ObqK6M5cUkMGZDBi+j5WqTkGBoLAOo+SSiLVMEBqV6bbs/pmTwpyL1wkSQtHT+tia+ayhycSVnXn0ftlDFoCPLNtUdtZMOHLZ4LlAsJcvCxpg+2qr3HR0uvztuRJh1d+JxtfdsMgBTwO6KGu59WmsgPjBrItRJ6o4ZLSWBE9C6Foo7F7TG0mG6wOcUTDBW9m4PdJDiUXaa0DcNTkDAuPsUy63PybBHa38KSA4Ltq05Elax19QdV5FF/HlocQozPnAV91iaE0nb/Iuv9KE7NZJto/uV+yYH3+Olwke9PxfIP3bTdXLl4oBNRkPkLwWidQAVVMj0JUdV5qvC/Red6Pi7DSuocXFNL13LNj7njbLIcildgkF1uNVdynSVExH2f4xGBpq4+S4jevWBeRXcf7MI0k3e6RrAYf21aV+27uXVAfpbImTGRUzwbEUunJr6hRyGN857KxyH08xbKyjXhK2saMURH9bLsEu1W6XUVJkpeZdnDY7ZQUdqhGK1BvEpU6xW2Nohpxd79kvb0+F1LgJeO1Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000299, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 15, 2023 at 10:26:15PM -0500, Kent Overstreet wrote: > This lets us kill the dependency on spinlock.h. > > Signed-off-by: Kent Overstreet > --- > include/linux/sched.h | 31 ------------------------------- > include/linux/spinlock.h | 31 +++++++++++++++++++++++++++++++ > 2 files changed, 31 insertions(+), 31 deletions(-) > > diff --git a/include/linux/sched.h b/include/linux/sched.h > index 5a5b7b122682..7501a3451a20 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -2227,37 +2227,6 @@ static inline bool preempt_model_preemptible(void) > return preempt_model_full() || preempt_model_rt(); > } > > -/* > - * Does a critical section need to be broken due to another > - * task waiting?: (technically does not depend on CONFIG_PREEMPTION, > - * but a general need for low latency) > - */ > -static inline int spin_needbreak(spinlock_t *lock) > -{ > -#ifdef CONFIG_PREEMPTION > - return spin_is_contended(lock); > -#else > - return 0; > -#endif > -} > - > -/* > - * Check if a rwlock is contended. > - * Returns non-zero if there is another task waiting on the rwlock. > - * Returns zero if the lock is not contended or the system / underlying > - * rwlock implementation does not support contention detection. > - * Technically does not depend on CONFIG_PREEMPTION, but a general need > - * for low latency. > - */ > -static inline int rwlock_needbreak(rwlock_t *lock) > -{ > -#ifdef CONFIG_PREEMPTION > - return rwlock_is_contended(lock); > -#else > - return 0; > -#endif > -} > - > static __always_inline bool need_resched(void) > { > return unlikely(tif_need_resched()); > diff --git a/include/linux/spinlock.h b/include/linux/spinlock.h > index 31d3d747a9db..0c71f06454d9 100644 > --- a/include/linux/spinlock.h > +++ b/include/linux/spinlock.h > @@ -449,6 +449,37 @@ static __always_inline int spin_is_contended(spinlock_t *lock) > return raw_spin_is_contended(&lock->rlock); > } > > +/* > + * Does a critical section need to be broken due to another > + * task waiting?: (technically does not depend on CONFIG_PREEMPTION, > + * but a general need for low latency) > + */ > +static inline int spin_needbreak(spinlock_t *lock) > +{ > +#ifdef CONFIG_PREEMPTION > + return spin_is_contended(lock); > +#else > + return 0; > +#endif > +} > + > +/* > + * Check if a rwlock is contended. > + * Returns non-zero if there is another task waiting on the rwlock. > + * Returns zero if the lock is not contended or the system / underlying > + * rwlock implementation does not support contention detection. > + * Technically does not depend on CONFIG_PREEMPTION, but a general need > + * for low latency. > + */ > +static inline int rwlock_needbreak(rwlock_t *lock) > +{ > +#ifdef CONFIG_PREEMPTION > + return rwlock_is_contended(lock); > +#else > + return 0; > +#endif > +} > + > #define assert_spin_locked(lock) assert_raw_spin_locked(&(lock)->rlock) > > #else /* !CONFIG_PREEMPT_RT */ > -- > 2.43.0 Hello Kent, This patch is breaking PREEMPT_RT builds, but it can be easily fixed. I sent a patch on the fix, please take a look: https://lore.kernel.org/all/20240115201935.2326400-1-leobras@redhat.com/ Thanks! Leo