From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DDF1C4706C for ; Sat, 13 Jan 2024 09:19:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFCB36B0093; Sat, 13 Jan 2024 04:19:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C8CBA6B0095; Sat, 13 Jan 2024 04:19:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B51AD6B0096; Sat, 13 Jan 2024 04:19:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A2A2F6B0093 for ; Sat, 13 Jan 2024 04:19:42 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6CFEF140572 for ; Sat, 13 Jan 2024 09:19:42 +0000 (UTC) X-FDA: 81673740204.21.9A311C4 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by imf25.hostedemail.com (Postfix) with ESMTP id E03BEA0009 for ; Sat, 13 Jan 2024 09:19:39 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hEgAQF72; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf25.hostedemail.com: domain of ak@linux.intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=ak@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705137580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9lYQKT++pGy+ATA5JMUYS6sYp9tJrbUHXHjxYVq1w4w=; b=WEmIzkOrlB54V5qR8XaIfkRh+O2S+jxOlSLjLkKLeO9iHSoeVTr9wqe/IOWlq1wMnHIPLK 6f1r6C6Z83mB9D45CO6jA+aV29qI4vKXal63lew2Q6uyXM6hdEYQ8t+4WjAXJyx7zPgq4s 5daLB2z+RGIUGtmMekCfa+yILg6I7MY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hEgAQF72; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf25.hostedemail.com: domain of ak@linux.intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=ak@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705137580; a=rsa-sha256; cv=none; b=o1XWrcs05JIrYQeMyzid9OMtfo63u1evcIYlDNMtvQCWNQWx2OTbuIYnA7TxBuxVUMU+JD W+aDulc90Lq5gL3QM7qwmmQBDLKiFEPWpxqvcQpDor0mmCJxNbsch6K40LMowUkQCEQ5rV jV0Fk0717wBS+h19QRUvEYZAhgHusRQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705137580; x=1736673580; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=40I2MKqfAkOFazQVYRT6HU5athsSbMattEgJmLpYaKc=; b=hEgAQF721QTJ6ZukkhYkF1NAtuIUOKrjGue2eePNLQ8SueiGCWIBfJsH Z7tJfbMWrnz8xgdgLFCsxrlKWd0ch6ayTjF5y764DFoqGhhWdg6Q0Ds7V NFAVaUXMG+fCiFjPdIJ1+pNpzES83P3BQtzMcmDG/nA1r07hJgQAkNVCP U41S11iCWOUjWn4L/JwjNcN9Js6Z+cigK6saBuLreRVBRdPsYKPS1bAFO wft/MxQMCgghA+lNYh6F2ndcYDO9Ga1jZboceUcgly2NUzickdwRR+/Mj sC+Z3OVxVO8z87VaRtUxM9hAJswQXYVTBQwAPmXYpUE0tUTbudBPHECCX g==; X-IronPort-AV: E=McAfee;i="6600,9927,10951"; a="403130397" X-IronPort-AV: E=Sophos;i="6.04,192,1695711600"; d="scan'208";a="403130397" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2024 01:19:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10951"; a="853513285" X-IronPort-AV: E=Sophos;i="6.04,192,1695711600"; d="scan'208";a="853513285" Received: from tassilo.jf.intel.com (HELO tassilo) ([10.54.38.190]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2024 01:19:37 -0800 Date: Sat, 13 Jan 2024 01:19:36 -0800 From: Andi Kleen To: Marco Elver Cc: Andrey Konovalov , Oscar Salvador , andrey.konovalov@linux.dev, Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH v4 12/22] lib/stackdepot: use read/write lock Message-ID: References: <87sf34lrn3.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: E03BEA0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: szsztzraccs31t8fce793xi7ngk4zimr X-HE-Tag: 1705137579-933455 X-HE-Meta: U2FsdGVkX1/axnLDb+7ai7BC1H25nysNvGZwo/KrjNp11XstzaGftugiVvgkXo1HBAZiKi70r+4LEN926adH5pFy3YXrUz+uHaCLilnIjV436ChzI9b4050VwFH4EYVvKGE2huJC0PJxseiyQnPcj/WU/b9ttvvbInXnvyfB2q20fNRbSCsXCr7RPmefa2mr7vyggDK6nFTMSgWL6IBShCaX6D6pCmcmN7z+bhINODXtahroxRysBJcZ9UWlvIFoQGhwtU0fRb35YZSC8ZDbfM4CsPrr1NJ9U+YiWzz3zrFE8peUGeuDDJA0WcLsXoF+w5AzXpeR3tCqafAOLFcedGPSXqQetY+CQnj/8/+bK5QtzBDZ5cb5hKTmyTTD/vBqveFMoCbsvVuNRB152HjvlTahhAl4IKXR94sNMqVif0rbtrSqeJyhMsFcIPXqEbuDbTDHZy2teNsNImO3MfGGY1JDrZxnybxsWvsqY8PSNRv4kGCy8F1lU01hm1GLU8i4uwu0kGdnBy5GVoPar3fUX56dDwOCgoUVH7xXn/m9mhK3MiFtD+bzV4cuttKsOGw01fr+P+0GBRqHRPb5UIyu2T9blecUPljyFCydcBZUd5UyUBNc/PATLfPNlrJPCXcpOf6SXyaRkrnwwXfK9fK957zRka5MVQTq+IEAKgEuyBFSxgQgY0OSYs0JwhJ+PO0hzsO4ujawrOiVOsDsc0zSxiB2uCHDP/VcXeO5lDTyB26WiqUi9yfJV1ZIV58Q2b2VDRYyLqIqg49mR1eiEyPMwlUVEE8Yc501DambXjvh2Frmk7beKaNSB+jA4MftmWTuGLAoLbW0d45XLGAGz45dJlWmcQiV8GywA8BQ1famfMwS8Dw8HLCXO/5Jd1mjPdZ902PnyrgTqp4+4AWCYsN+/VsGZ8zIl+36QHCAUZWfh/e5wBfJBHZY8JwZVC2sig66sKPfREEjlu0fHjX+zEP Lr098sIh UjvTsVGku6NZbG9Q7h71sZ+3a7rWelM5yUqzMu7fExKEqafWUFdoWwLDV624W2Sor5LNa2jmj1IEygqb4n3P9CVV6HdW1eyYiPzLmF3NzBPf7C1Nh3ZEG0blrDrDOMfpoN+R6DPBOgP+KxkIeDThBA0kipA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jan 13, 2024 at 10:12:21AM +0100, Marco Elver wrote: > On Sat, 13 Jan 2024 at 02:24, Andi Kleen wrote: > > > > On Fri, Jan 12, 2024 at 11:15:05PM +0100, Marco Elver wrote: > > > + /* > > > + * Stack traces of size 0 are never saved, and we can simply use > > > + * the size field as an indicator if this is a new unused stack > > > + * record in the freelist. > > > + */ > > > + stack->size = 0; > > > > I would use WRITE_ONCE here too, at least for TSan. > > This is written with the pool_lock held. ...which doesn't help because the readers don't take it? -Andi