From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B99AC4706C for ; Fri, 12 Jan 2024 17:10:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 856076B0083; Fri, 12 Jan 2024 12:10:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8063B6B0085; Fri, 12 Jan 2024 12:10:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CD146B0087; Fri, 12 Jan 2024 12:10:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5D8D76B0083 for ; Fri, 12 Jan 2024 12:10:56 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 964B81C1817 for ; Fri, 12 Jan 2024 17:10:55 +0000 (UTC) X-FDA: 81671298870.25.AB8ED91 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) by imf08.hostedemail.com (Postfix) with ESMTP id 8E3D3160005 for ; Fri, 12 Jan 2024 17:10:53 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Azs5GhsS; spf=pass (imf08.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705079453; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=McdqJF13JJY95fe2wVB3NPXE39DtpV52lmmGUDjCt/8=; b=zzXo0DlhGmoX+I3xt9dKGyv8HbSdN185SIhjqgnsGdl3ZIY0/+/r5lr78/Pgn7HnXNsBIu sPb0maHcBxgFmHfKS6hGgPoFlzIK5iQkxUJD/rE6xRnTrNTrSbe2LAV2jhtWfaW/x0rodf DhcKlAav7y1JmiUqOiHL0ajeXEP3UDg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705079453; a=rsa-sha256; cv=none; b=votQNfOBUAidd41q3VWE07Z+GzB80NL83QfDh+xL30thV9G7XFhlaXnPoB4CTRU1utSv4D YsHb9G1ZkQy4g3PyfP0hlno9KwWK3c4UzFXpzyTQA9WcwzYYzqvkRlbIMiU6JhPW+DrS8a 7174IZnu23vVOgpduYo85F/kowRIwps= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Azs5GhsS; spf=pass (imf08.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Fri, 12 Jan 2024 09:10:33 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1705079451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=McdqJF13JJY95fe2wVB3NPXE39DtpV52lmmGUDjCt/8=; b=Azs5GhsSQc0JX1eVWdKhQOMnykKCEd0TUAy5wBRqscrGBpynqnH9NrztgOh9i4qcO4ySG5 JCfXydZMdgx15mjGt63BsD9HBndIph9DkxlorF1HV18ImX9uxbRs2qO3pyfDiSz8yEtYsx 2tt8hW1AI1BDy8SQGP2BvUcqYYj+by0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Michal Hocko Cc: Johannes Weiner , Andrew Morton , Shakeel Butt , Muchun Song , Tejun Heo , Dan Schatzberg , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcontrol: don't throttle dying tasks on memory.high Message-ID: References: <20240111132902.389862-1-hannes@cmpxchg.org> <20240111192807.GA424308@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: yr1jfw8i5pgghrhz9gxwytommdprqzgc X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8E3D3160005 X-Rspam-User: X-HE-Tag: 1705079453-302819 X-HE-Meta: U2FsdGVkX1/uVkJScJ/JRfR2zJa91gjsMdtCc4r1fDdkQD1DG/L6j4sdX3t785OYnyYHkQa2ItpG+YOdlUkCDLBWPFX4NGy/WhpcACzYAnR8cjKyzhns+tqUaGvZl4rarPItu8JuwbHhM2G+iwq64mNV8+H+dSBNF2QOSoihp+Npyt1f6+FJt/hZCQVQp+c6/76DNCjRvvlGbWOpAg52HX43Wy+Swd00qaxqJ6+WwzkgZVJALrPdbhSwXwFe+4noho3FeAK8jw/TYnqNAP8AnXvDnN/9/ZdbLpPOfUUJdgeK8U0wDNQwnUsFgOTNkfFva33SrVHTH4FJ2J/ICdsafZLrdB8MZQ2QYN/L03dNmc+P/Jg1Gl5rOGMgKTDB6slcfs9NCsdSwasyJV795PvZKs3p2/rJXecy7N2vV/SMz0D8iuGFvJm+TkRHzghYWOI7d+mLilHtQEAqUk3kFMr/Nb/RUDDEur5Z1m8kPQByPRqhpLFwS/QKAAlOlOFCVLHGz870Jj4pv5B+INpJbFtBqHznpsUUW//oZZmJKl1mJ+oGI+YqKkONekG5zyF5FUuN2WiTk+HsfcoG/jUVVCkl7dZnebkRZvduGt/Ha6Dog4nUIUsQgm97a0kHeZmWKrkAoTqciEkQYH90RvwReuNpWUnXjSRioqIiL0H0fzGU2gS5Q+Bewy4W2677pCa8X8jG0/PoSgK2pGDSEas9ijJguVMGv/goqPe9G3ZDy+8dssSxp0NCSHKJAf+Zm7kqRhaoWWpfaMqmPqE3C2OXlL+s62r98kuYUEn1gj4b5ezHd7gTOg4Qrk31kXKpy7y9MtTqmOPVEd6eej+cXPhG7DBFfIVhSbQF63sDsJmeH5BMwegdS7K6maRaKVyQ7qMZivNMMmge0aCTCg6tdLmM4WUMrRuWyDibfeDvbJsNmMzOD8ZCbgguCSNX3HQZZGntWVCbc/hfyrKiyxLO2gLXa5J 7zlmS5RO ux6sSZwSCPTfpJioyjcZMQLpC340N6iSyEwY6arkVBW4ovW4uaA6iXzP+pqmC4bD60zt8oc0ZJksZha/3IeXFEWpGE4K4mm7BdRruRG/Fk/MOTBS0yXgArgcrrdHMVhCV5kQFSILMwiyCXr0KqjbzI8KANBbCwvv00SIe+9wc7ltUy+BZRHPXjWsUwMDNlqyjusqAZQaUx9vZ1GbfeIXjezNzoRLbQrC0625rafctQNm4tVJvWPTUctel89fyHcUlIBsQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 12, 2024 at 06:06:39PM +0100, Michal Hocko wrote: > On Thu 11-01-24 14:28:07, Johannes Weiner wrote: > [...] > > @@ -2867,11 +2882,17 @@ static int try_charge_memcg(struct mem_cgroup *memcg, gfp_t gfp_mask, > > } > > } while ((memcg = parent_mem_cgroup(memcg))); > > > > + /* > > + * Reclaim is set up above to be called from the userland > > + * return path. But also attempt synchronous reclaim to avoid > > + * excessive overrun while the task is still inside the > > + * kernel. If this is successful, the return path will see it > > + * when it rechecks the overage and simply bail out. > > + */ > > if (current->memcg_nr_pages_over_high > MEMCG_CHARGE_BATCH && > > !(current->flags & PF_MEMALLOC) && > > - gfpflags_allow_blocking(gfp_mask)) { > > + gfpflags_allow_blocking(gfp_mask)) > > mem_cgroup_handle_over_high(gfp_mask); > > Have you lost the check for the dying task here? It was moved into mem_cgroup_handle_over_high()'s body.