From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76F00C47258 for ; Fri, 12 Jan 2024 17:06:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BADC86B006E; Fri, 12 Jan 2024 12:06:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B5DEC6B0074; Fri, 12 Jan 2024 12:06:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FE406B007D; Fri, 12 Jan 2024 12:06:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8C6DA6B006E for ; Fri, 12 Jan 2024 12:06:44 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 619BBC066E for ; Fri, 12 Jan 2024 17:06:44 +0000 (UTC) X-FDA: 81671288328.01.5876F0F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf13.hostedemail.com (Postfix) with ESMTP id 166032001E for ; Fri, 12 Jan 2024 17:06:41 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=CzJmzX9u; dkim=pass header.d=suse.com header.s=susede1 header.b=CzJmzX9u; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705079202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J9TtdXtQR+ltHvURBV7RXOVWC44VVGVh8yNJ9YJwFIw=; b=0QqHZSb7/7E3cSULeR87bO6r6B3xtrojzCg9F9zYYqBVviacRzGvfzwgdlnm+0XnWR5PO9 PcTY8vf/3arNTPfGex4c8jrPgPUNNUQUwnrGc75jFbCC7o5kSoi8l7D093aM2LFkcSIv5C yEa9f1SkdhoIvUGO4iF7Frvx+r29Vrw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=CzJmzX9u; dkim=pass header.d=suse.com header.s=susede1 header.b=CzJmzX9u; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705079202; a=rsa-sha256; cv=none; b=snejCPBhtJpllMjY3pE65Uqsrocxs/gyw1aP58uNCBRduldICyl9TrmpFwQC3Na8/W3bH9 ZomMRALgDVuHvIdggoyFQ4B1SywbgxgIyyRGGA9NcHPdxRvqQ4X8Bum+QNqIZE4uoaa2EB ccq+cP1m3E5ilFCKLHO/l8aX2dZAEGA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 242151F396; Fri, 12 Jan 2024 17:06:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1705079200; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J9TtdXtQR+ltHvURBV7RXOVWC44VVGVh8yNJ9YJwFIw=; b=CzJmzX9u/E6mMsRugcI6NK+0u8PnDPix0v9Q/Rj9A8iPbOT0dNbc6jqgkpKGS4zmknQo6Y nIqjvMm6yUu7OqvNEShPQ9pXBdcSSFJug7d5GEvNFQ38jwbAZZn+TEs+VcHT4RSYo93MS1 eTper5Sk6OKwn1MnaARO0/lLWHv0xW0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1705079200; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J9TtdXtQR+ltHvURBV7RXOVWC44VVGVh8yNJ9YJwFIw=; b=CzJmzX9u/E6mMsRugcI6NK+0u8PnDPix0v9Q/Rj9A8iPbOT0dNbc6jqgkpKGS4zmknQo6Y nIqjvMm6yUu7OqvNEShPQ9pXBdcSSFJug7d5GEvNFQ38jwbAZZn+TEs+VcHT4RSYo93MS1 eTper5Sk6OKwn1MnaARO0/lLWHv0xW0= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EB05013782; Fri, 12 Jan 2024 17:06:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id f6NVNp9xoWUGNAAAD6G6ig (envelope-from ); Fri, 12 Jan 2024 17:06:39 +0000 Date: Fri, 12 Jan 2024 18:06:39 +0100 From: Michal Hocko To: Johannes Weiner Cc: Roman Gushchin , Andrew Morton , Shakeel Butt , Muchun Song , Tejun Heo , Dan Schatzberg , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcontrol: don't throttle dying tasks on memory.high Message-ID: References: <20240111132902.389862-1-hannes@cmpxchg.org> <20240111192807.GA424308@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111192807.GA424308@cmpxchg.org> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 166032001E X-Stat-Signature: ypsi5j971zx1dygzracy11md9yh68bca X-Rspam-User: X-HE-Tag: 1705079201-190954 X-HE-Meta: U2FsdGVkX1/g030oz5OgIw+WXTIWKbS+HR8aBURQvRrFWXdHtAvl5NxuVnAwK0WlAELpGNDIXn+8juxrL7ygX5Y8NET8S7VdNbIGpk6iWJ4spgj837fUhvad4JhBzT3pfFn8kSu9j/qLBfx3TTle9/NCx0sD8tB4KCYnWSxrX+n37QPfUHK3SrP53QK47rqiboewiRnYYnFhMm+bnHe1rn0Hit1dookrscTcBGVCnCXmlbfbeK2orn1lFv5Wdm9nkciMNM7YEIbZ2k2kBMi0zRCNFZP3q0lf9uDDgiL66ManettzMkFb1YOEtckidFP3EstLKka4drrVnD/x0+lYMCEYqDnmCpRLOsmzBAnNmr0cyb+I7IQgTh/Co3RxnZcAz7VV17VCT1NCUYfdJAmSQfuhHP5WkMP+3c3zNrplyPtypRdWHNuC6VvsntaS0A45q+czO8V4KZXWG072JoBi7fngmQwniGf7yHJQO6XFyBkheyYt1ZWYTRKNbH8PQ4VBwilXxrjLesq0+14SdrPwmpVkB+/Pqt7p1G37s//2tvCL9nJ85SAMHeDqU7qeOJCEoktHpKg9u9RTmVkCBcWRd8YqMeRdDODkmHCKNKtCQxhvPp1g4GS46Al4dA9gFCKx1bv9nbJF48k4VIJgO0MKe33iWD/8pV1itgkLJWQFvnfvz5ip7ET4v+KrOXpqjctTAEcovFtnXEqT82zvrPmx+gjcX+9gD6GlHcr9W7ftwS4wxh+x1EXZQT45+YjuN8EdnrJ7JAEeMIOqbgAOcaFopVo7et6T5P++aLkLby0R6O3WJ8shAtQkj9YY8WNFOHp8UA6GVPbt+ejEqV/bdHdkvisvylLPAQGLZVspJLMdq6NXUFHYlsLxgt8i6vEYhoDk0ll7EjB2PVCgclL8we62WRq0KsW86FnLmslo9gQyIQvqaCw8ZNJ1uVRgmmEC3crDcABMEe4L7sldgkfCCz4 eCFDoOff rWtQQCZOE54ulNUm985zKNIDMXov3C+rIBAQjMr+8Qcxflk98s/lfAlaG4HnWlNxuYRo1Wfqynw2yTgng0McSwQ8k+tc+nsP0RAXov1X0+vuL/h0QJ3R4uK4aNcraNehp+BxUZ54Rtf1pkzMGpiQj1x7bnzryfw3sOPDonGTIlBcGOhCYGs3QmPYXNLfCj8rxDa6TB8B2EbX4o6tmNm38/mZop3jB8vLS9rlXzLwGc/wlDgQ0eK+nIyba4hMMMLiAk1FIjqewEw+05pS9gsuoCicQuFGRN/CMYi9Mv76+/YeV7rw7Ot9x8em/5+fKaF5v3mL50MLLA9b5bnwQeu28ykTrgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 11-01-24 14:28:07, Johannes Weiner wrote: [...] > @@ -2867,11 +2882,17 @@ static int try_charge_memcg(struct mem_cgroup *memcg, gfp_t gfp_mask, > } > } while ((memcg = parent_mem_cgroup(memcg))); > > + /* > + * Reclaim is set up above to be called from the userland > + * return path. But also attempt synchronous reclaim to avoid > + * excessive overrun while the task is still inside the > + * kernel. If this is successful, the return path will see it > + * when it rechecks the overage and simply bail out. > + */ > if (current->memcg_nr_pages_over_high > MEMCG_CHARGE_BATCH && > !(current->flags & PF_MEMALLOC) && > - gfpflags_allow_blocking(gfp_mask)) { > + gfpflags_allow_blocking(gfp_mask)) > mem_cgroup_handle_over_high(gfp_mask); Have you lost the check for the dying task here? Other than that looks good to me. -- Michal Hocko SUSE Labs